All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] ASoC: rk817: fix compile warning in rk817_probe()
@ 2021-06-03  1:36 ` Yang Yingliang
  0 siblings, 0 replies; 3+ messages in thread
From: Yang Yingliang @ 2021-06-03  1:36 UTC (permalink / raw)
  To: linux-kernel, alsa-devel; +Cc: lee.jones, broonie, macromorgan

Fix the compile warning by return ret:

  sound/soc/codecs/rk817_codec.c:418:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
    418 |  int ret;
        |      ^~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 sound/soc/codecs/rk817_codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/rk817_codec.c b/sound/soc/codecs/rk817_codec.c
index 17e672b85ee5..56de5ec5f03b 100644
--- a/sound/soc/codecs/rk817_codec.c
+++ b/sound/soc/codecs/rk817_codec.c
@@ -430,7 +430,7 @@ static int rk817_probe(struct snd_soc_component *component)
 
 	snd_soc_component_set_pll(component, 0, 0, 0, 0);
 
-	return 0;
+	return ret;
 }
 
 static void rk817_remove(struct snd_soc_component *component)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH -next] ASoC: rk817: fix compile warning in rk817_probe()
@ 2021-06-03  1:36 ` Yang Yingliang
  0 siblings, 0 replies; 3+ messages in thread
From: Yang Yingliang @ 2021-06-03  1:36 UTC (permalink / raw)
  To: linux-kernel, alsa-devel; +Cc: broonie, lee.jones, macromorgan

Fix the compile warning by return ret:

  sound/soc/codecs/rk817_codec.c:418:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
    418 |  int ret;
        |      ^~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 sound/soc/codecs/rk817_codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/rk817_codec.c b/sound/soc/codecs/rk817_codec.c
index 17e672b85ee5..56de5ec5f03b 100644
--- a/sound/soc/codecs/rk817_codec.c
+++ b/sound/soc/codecs/rk817_codec.c
@@ -430,7 +430,7 @@ static int rk817_probe(struct snd_soc_component *component)
 
 	snd_soc_component_set_pll(component, 0, 0, 0, 0);
 
-	return 0;
+	return ret;
 }
 
 static void rk817_remove(struct snd_soc_component *component)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH -next] ASoC: rk817: fix compile warning in rk817_probe()
  2021-06-03  1:36 ` Yang Yingliang
  (?)
@ 2021-06-04 14:15 ` Chris Morgan
  -1 siblings, 0 replies; 3+ messages in thread
From: Chris Morgan @ 2021-06-04 14:15 UTC (permalink / raw)
  To: Yang Yingliang; +Cc: alsa-devel, broonie, lee.jones, linux-kernel

On Thu, Jun 03, 2021 at 09:36:05AM +0800, Yang Yingliang wrote:
> Fix the compile warning by return ret:
> 
>   sound/soc/codecs/rk817_codec.c:418:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>     418 |  int ret;
>         |      ^~~
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  sound/soc/codecs/rk817_codec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/rk817_codec.c b/sound/soc/codecs/rk817_codec.c
> index 17e672b85ee5..56de5ec5f03b 100644
> --- a/sound/soc/codecs/rk817_codec.c
> +++ b/sound/soc/codecs/rk817_codec.c
> @@ -430,7 +430,7 @@ static int rk817_probe(struct snd_soc_component *component)
>  
>  	snd_soc_component_set_pll(component, 0, 0, 0, 0);
>  
> -	return 0;
> +	return ret;
>  }
>  
>  static void rk817_remove(struct snd_soc_component *component)
> -- 
> 2.25.1
> 

This should be fixed by 
ef7570b67541 ASoC: rk817: fix a warning in rk817_probe()

https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?h=tb-mfd-asoc-5.14-1&id=ef7570b67541d8b938df1e45f56e54be70bf1360

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-04 14:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03  1:36 [PATCH -next] ASoC: rk817: fix compile warning in rk817_probe() Yang Yingliang
2021-06-03  1:36 ` Yang Yingliang
2021-06-04 14:15 ` Chris Morgan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.