From: kernel test robot <lkp@intel.com>
To: Olga Kornievskaia <olga.kornievskaia@gmail.com>,
trond.myklebust@hammerspace.com, anna.schumaker@netapp.com
Cc: kbuild-all@lists.01.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v8 10/13] sunrpc: add dst_attr attributes to the sysfs xprt directory
Date: Thu, 3 Jun 2021 09:10:09 +0800 [thread overview]
Message-ID: <202106030959.8kEUXc5j-lkp@intel.com> (raw)
In-Reply-To: <20210601220915.18975-11-olga.kornievskaia@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3495 bytes --]
Hi Olga,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on nfs/linux-next]
[also build test WARNING on v5.13-rc4 next-20210602]
[cannot apply to nfsd/nfsd-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Olga-Kornievskaia/create-sysfs-files-for-changing-IP-address/20210602-061025
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: x86_64-randconfig-s021-20210603 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/587333d27097360f103c2eaa1bf836d1b4c5e5c5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Olga-Kornievskaia/create-sysfs-files-for-changing-IP-address/20210602-061025
git checkout 587333d27097360f103c2eaa1bf836d1b4c5e5c5
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> net/sunrpc/sysfs.c:118:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
>> net/sunrpc/sysfs.c:118:9: sparse: char const [noderef] __rcu *
>> net/sunrpc/sysfs.c:118:9: sparse: char const *
vim +118 net/sunrpc/sysfs.c
84
85 static ssize_t rpc_sysfs_xprt_dstaddr_store(struct kobject *kobj,
86 struct kobj_attribute *attr,
87 const char *buf, size_t count)
88 {
89 struct rpc_xprt *xprt = rpc_sysfs_xprt_kobj_get_xprt(kobj);
90 struct sockaddr *saddr;
91 char *dst_addr;
92 int port;
93 struct xprt_addr *saved_addr;
94
95 if (!xprt)
96 return 0;
97 if (!(xprt->xprt_class->ident == XPRT_TRANSPORT_TCP ||
98 xprt->xprt_class->ident == XPRT_TRANSPORT_RDMA)) {
99 xprt_put(xprt);
100 return -EOPNOTSUPP;
101 }
102
103 if (wait_on_bit_lock(&xprt->state, XPRT_LOCKED, TASK_KILLABLE)) {
104 count = -EINTR;
105 goto out_put;
106 }
107 saddr = (struct sockaddr *)&xprt->addr;
108 port = rpc_get_port(saddr);
109
110 dst_addr = kstrndup(buf, count - 1, GFP_KERNEL);
111 if (!dst_addr)
112 goto out_err;
113 saved_addr = kzalloc(sizeof(*saved_addr), GFP_KERNEL);
114 if (!saved_addr)
115 goto out_err_free;
116 saved_addr->addr =
117 rcu_dereference_raw(xprt->address_strings[RPC_DISPLAY_ADDR]);
> 118 rcu_assign_pointer(xprt->address_strings[RPC_DISPLAY_ADDR], dst_addr);
119 call_rcu(&saved_addr->rcu, free_xprt_addr);
120 xprt->addrlen = rpc_pton(xprt->xprt_net, buf, count - 1, saddr,
121 sizeof(*saddr));
122 rpc_set_port(saddr, port);
123
124 xprt_force_disconnect(xprt);
125 out:
126 xprt_release_write(xprt, NULL);
127 out_put:
128 xprt_put(xprt);
129 return count;
130 out_err_free:
131 kfree(dst_addr);
132 out_err:
133 count = -ENOMEM;
134 goto out;
135 }
136
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34392 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v8 10/13] sunrpc: add dst_attr attributes to the sysfs xprt directory
Date: Thu, 03 Jun 2021 09:10:09 +0800 [thread overview]
Message-ID: <202106030959.8kEUXc5j-lkp@intel.com> (raw)
In-Reply-To: <20210601220915.18975-11-olga.kornievskaia@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3590 bytes --]
Hi Olga,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on nfs/linux-next]
[also build test WARNING on v5.13-rc4 next-20210602]
[cannot apply to nfsd/nfsd-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Olga-Kornievskaia/create-sysfs-files-for-changing-IP-address/20210602-061025
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: x86_64-randconfig-s021-20210603 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/587333d27097360f103c2eaa1bf836d1b4c5e5c5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Olga-Kornievskaia/create-sysfs-files-for-changing-IP-address/20210602-061025
git checkout 587333d27097360f103c2eaa1bf836d1b4c5e5c5
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> net/sunrpc/sysfs.c:118:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
>> net/sunrpc/sysfs.c:118:9: sparse: char const [noderef] __rcu *
>> net/sunrpc/sysfs.c:118:9: sparse: char const *
vim +118 net/sunrpc/sysfs.c
84
85 static ssize_t rpc_sysfs_xprt_dstaddr_store(struct kobject *kobj,
86 struct kobj_attribute *attr,
87 const char *buf, size_t count)
88 {
89 struct rpc_xprt *xprt = rpc_sysfs_xprt_kobj_get_xprt(kobj);
90 struct sockaddr *saddr;
91 char *dst_addr;
92 int port;
93 struct xprt_addr *saved_addr;
94
95 if (!xprt)
96 return 0;
97 if (!(xprt->xprt_class->ident == XPRT_TRANSPORT_TCP ||
98 xprt->xprt_class->ident == XPRT_TRANSPORT_RDMA)) {
99 xprt_put(xprt);
100 return -EOPNOTSUPP;
101 }
102
103 if (wait_on_bit_lock(&xprt->state, XPRT_LOCKED, TASK_KILLABLE)) {
104 count = -EINTR;
105 goto out_put;
106 }
107 saddr = (struct sockaddr *)&xprt->addr;
108 port = rpc_get_port(saddr);
109
110 dst_addr = kstrndup(buf, count - 1, GFP_KERNEL);
111 if (!dst_addr)
112 goto out_err;
113 saved_addr = kzalloc(sizeof(*saved_addr), GFP_KERNEL);
114 if (!saved_addr)
115 goto out_err_free;
116 saved_addr->addr =
117 rcu_dereference_raw(xprt->address_strings[RPC_DISPLAY_ADDR]);
> 118 rcu_assign_pointer(xprt->address_strings[RPC_DISPLAY_ADDR], dst_addr);
119 call_rcu(&saved_addr->rcu, free_xprt_addr);
120 xprt->addrlen = rpc_pton(xprt->xprt_net, buf, count - 1, saddr,
121 sizeof(*saddr));
122 rpc_set_port(saddr, port);
123
124 xprt_force_disconnect(xprt);
125 out:
126 xprt_release_write(xprt, NULL);
127 out_put:
128 xprt_put(xprt);
129 return count;
130 out_err_free:
131 kfree(dst_addr);
132 out_err:
133 count = -ENOMEM;
134 goto out;
135 }
136
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34392 bytes --]
next prev parent reply other threads:[~2021-06-03 1:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 22:09 [PATCH v8 00/13] create sysfs files for changing IP address Olga Kornievskaia
2021-06-01 22:09 ` [PATCH v8 01/13] sunrpc: Create a sunrpc directory under /sys/kernel/ Olga Kornievskaia
2021-06-01 22:09 ` [PATCH v8 02/13] sunrpc: Create a client/ subdirectory in the sunrpc sysfs Olga Kornievskaia
2021-06-01 22:09 ` [PATCH v8 03/13] sunrpc: Create per-rpc_clnt sysfs kobjects Olga Kornievskaia
2021-06-01 22:09 ` [PATCH v8 04/13] sunrpc: add xprt id Olga Kornievskaia
2021-06-01 22:09 ` [PATCH v8 05/13] sunrpc: add IDs to multipath Olga Kornievskaia
2021-06-01 22:09 ` [PATCH v8 06/13] sunrpc: keep track of the xprt_class in rpc_xprt structure Olga Kornievskaia
2021-06-01 22:09 ` [PATCH v8 07/13] sunrpc: add xprt_switch direcotry to sunrpc's sysfs Olga Kornievskaia
2021-06-01 22:09 ` [PATCH v8 08/13] sunrpc: add a symlink from rpc-client directory to the xprt_switch Olga Kornievskaia
2021-06-01 22:09 ` [PATCH v8 09/13] sunrpc: add add sysfs directory per xprt under each xprt_switch Olga Kornievskaia
2021-06-01 22:09 ` [PATCH v8 10/13] sunrpc: add dst_attr attributes to the sysfs xprt directory Olga Kornievskaia
2021-06-02 9:28 ` kernel test robot
2021-06-02 9:28 ` kernel test robot
2021-06-03 1:10 ` kernel test robot [this message]
2021-06-03 1:10 ` kernel test robot
2021-06-01 22:09 ` [PATCH v8 11/13] sunrpc: provide transport info in the sysfs directory Olga Kornievskaia
2021-06-01 22:09 ` [PATCH v8 12/13] sunrpc: provide multipath " Olga Kornievskaia
2021-06-01 22:09 ` [PATCH v8 13/13] sunrpc: provide showing transport's state " Olga Kornievskaia
2021-06-02 1:17 [PATCH v8 10/13] sunrpc: add dst_attr attributes to the sysfs xprt directory kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106030959.8kEUXc5j-lkp@intel.com \
--to=lkp@intel.com \
--cc=anna.schumaker@netapp.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-nfs@vger.kernel.org \
--cc=olga.kornievskaia@gmail.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.