Re: [PATCH 1/3 v4] crypto: ixp4xx: convert to platform driver

[Herbert Xu <herbert@gondor.apana.org.au>]

On Tue, May 25, 2021 at 10:30:46AM +0200, Linus Walleij wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The ixp4xx_crypto driver traditionally registers a bare platform
> device without attaching it to a driver, and detects the hardware
> at module init time by reading an SoC specific hardware register.
> 
> Change this to the conventional method of registering the platform
> device from the platform code itself when the device is present,
> turning the module_init/module_exit functions into probe/release
> driver callbacks.
> 
> This enables compile-testing as well as potentially having ixp4xx
> coexist with other ARMv5 platforms in the same kernel in the future.
> 
> Cc: Corentin Labbe <clabbe@baylibre.com>
> Tested-by: Corentin Labbe <clabbe@baylibre.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v3->v4:
> - No changes, just resending with the other patches.
> ChangeLog v2->v3:
> - No changes, just resending with the other patches.
> ChangeLog v1->v2:
> - Rebase on Corentin's patches in the cryptodev tree
> - Drop the compile test Kconfig, it will not compile for
>   anything not IXP4xx anyway because it needs the NPE and QMGR
>   to be compiled in and those only exist on IXP4xx.
> ---
>  arch/arm/mach-ixp4xx/common.c  | 26 ++++++++++++++++++++++++
>  drivers/crypto/ixp4xx_crypto.c | 37 ++++++++++++----------------------
>  2 files changed, 39 insertions(+), 24 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt