* [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends
@ 2021-06-04 1:40 ` Kees Cook
0 siblings, 0 replies; 10+ messages in thread
From: Kees Cook @ 2021-06-04 1:40 UTC (permalink / raw)
To: Daniel Vetter
Cc: Kees Cook, Rob Herring, Emma Anholt, David Airlie, linux-kernel,
dri-devel
VEXPRESS_CONFIG needs to either be missing, built-in, or modular when
pl111 is modular. Update the Kconfig to reflect the need.
Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG")
Signed-off-by: Kees Cook <keescook@chromium.org>
---
v2: use expected Kconfig style to express this. :)
v1: https://lore.kernel.org/lkml/20210603215819.3904733-1-keescook@chromium.org
---
drivers/gpu/drm/pl111/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig
index c5210a5bef1b..3aae387a96af 100644
--- a/drivers/gpu/drm/pl111/Kconfig
+++ b/drivers/gpu/drm/pl111/Kconfig
@@ -2,7 +2,8 @@
config DRM_PL111
tristate "DRM Support for PL111 CLCD Controller"
depends on DRM
- depends on VEXPRESS_CONFIG
+ depends on ARM || ARM64 || COMPILE_TEST
+ depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n
depends on COMMON_CLK
select DRM_KMS_HELPER
select DRM_KMS_CMA_HELPER
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends
@ 2021-06-04 1:40 ` Kees Cook
0 siblings, 0 replies; 10+ messages in thread
From: Kees Cook @ 2021-06-04 1:40 UTC (permalink / raw)
To: Daniel Vetter
Cc: Kees Cook, Emma Anholt, David Airlie, linux-kernel, dri-devel
VEXPRESS_CONFIG needs to either be missing, built-in, or modular when
pl111 is modular. Update the Kconfig to reflect the need.
Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG")
Signed-off-by: Kees Cook <keescook@chromium.org>
---
v2: use expected Kconfig style to express this. :)
v1: https://lore.kernel.org/lkml/20210603215819.3904733-1-keescook@chromium.org
---
drivers/gpu/drm/pl111/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig
index c5210a5bef1b..3aae387a96af 100644
--- a/drivers/gpu/drm/pl111/Kconfig
+++ b/drivers/gpu/drm/pl111/Kconfig
@@ -2,7 +2,8 @@
config DRM_PL111
tristate "DRM Support for PL111 CLCD Controller"
depends on DRM
- depends on VEXPRESS_CONFIG
+ depends on ARM || ARM64 || COMPILE_TEST
+ depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n
depends on COMMON_CLK
select DRM_KMS_HELPER
select DRM_KMS_CMA_HELPER
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends
2021-06-04 1:40 ` Kees Cook
@ 2021-06-04 7:44 ` Linus Walleij
-1 siblings, 0 replies; 10+ messages in thread
From: Linus Walleij @ 2021-06-04 7:44 UTC (permalink / raw)
To: Kees Cook
Cc: Daniel Vetter, Emma Anholt, David Airlie, linux-kernel,
open list:DRM PANEL DRIVERS
On Fri, Jun 4, 2021 at 3:41 AM Kees Cook <keescook@chromium.org> wrote:
> VEXPRESS_CONFIG needs to either be missing, built-in, or modular when
> pl111 is modular. Update the Kconfig to reflect the need.
>
> Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG")
Yeah that doesn't work, thanks for fixing this!
> Signed-off-by: Kees Cook <keescook@chromium.org>
> - depends on VEXPRESS_CONFIG
> + depends on ARM || ARM64 || COMPILE_TEST
> + depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n
That's the right solution,
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends
@ 2021-06-04 7:44 ` Linus Walleij
0 siblings, 0 replies; 10+ messages in thread
From: Linus Walleij @ 2021-06-04 7:44 UTC (permalink / raw)
To: Kees Cook
Cc: David Airlie, open list:DRM PANEL DRIVERS, Emma Anholt, linux-kernel
On Fri, Jun 4, 2021 at 3:41 AM Kees Cook <keescook@chromium.org> wrote:
> VEXPRESS_CONFIG needs to either be missing, built-in, or modular when
> pl111 is modular. Update the Kconfig to reflect the need.
>
> Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG")
Yeah that doesn't work, thanks for fixing this!
> Signed-off-by: Kees Cook <keescook@chromium.org>
> - depends on VEXPRESS_CONFIG
> + depends on ARM || ARM64 || COMPILE_TEST
> + depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n
That's the right solution,
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends
2021-06-04 7:44 ` Linus Walleij
@ 2021-06-04 9:15 ` Daniel Vetter
-1 siblings, 0 replies; 10+ messages in thread
From: Daniel Vetter @ 2021-06-04 9:15 UTC (permalink / raw)
To: Linus Walleij
Cc: Kees Cook, Daniel Vetter, Emma Anholt, David Airlie,
linux-kernel, open list:DRM PANEL DRIVERS
On Fri, Jun 04, 2021 at 09:44:59AM +0200, Linus Walleij wrote:
> On Fri, Jun 4, 2021 at 3:41 AM Kees Cook <keescook@chromium.org> wrote:
>
> > VEXPRESS_CONFIG needs to either be missing, built-in, or modular when
> > pl111 is modular. Update the Kconfig to reflect the need.
> >
> > Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG")
>
> Yeah that doesn't work, thanks for fixing this!
>
> > Signed-off-by: Kees Cook <keescook@chromium.org>
>
> > - depends on VEXPRESS_CONFIG
> > + depends on ARM || ARM64 || COMPILE_TEST
> > + depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n
>
> That's the right solution,
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Since I screwed up already, care to also push this to drm-misc-next?
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends
@ 2021-06-04 9:15 ` Daniel Vetter
0 siblings, 0 replies; 10+ messages in thread
From: Daniel Vetter @ 2021-06-04 9:15 UTC (permalink / raw)
To: Linus Walleij
Cc: Kees Cook, Emma Anholt, David Airlie, linux-kernel,
open list:DRM PANEL DRIVERS
On Fri, Jun 04, 2021 at 09:44:59AM +0200, Linus Walleij wrote:
> On Fri, Jun 4, 2021 at 3:41 AM Kees Cook <keescook@chromium.org> wrote:
>
> > VEXPRESS_CONFIG needs to either be missing, built-in, or modular when
> > pl111 is modular. Update the Kconfig to reflect the need.
> >
> > Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG")
>
> Yeah that doesn't work, thanks for fixing this!
>
> > Signed-off-by: Kees Cook <keescook@chromium.org>
>
> > - depends on VEXPRESS_CONFIG
> > + depends on ARM || ARM64 || COMPILE_TEST
> > + depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n
>
> That's the right solution,
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Since I screwed up already, care to also push this to drm-misc-next?
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends
2021-06-04 1:40 ` Kees Cook
@ 2021-06-04 12:38 ` Rob Herring
-1 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2021-06-04 12:38 UTC (permalink / raw)
To: Kees Cook
Cc: Daniel Vetter, Emma Anholt, David Airlie, linux-kernel, dri-devel
On Thu, Jun 3, 2021 at 8:40 PM Kees Cook <keescook@chromium.org> wrote:
>
> VEXPRESS_CONFIG needs to either be missing, built-in, or modular when
> pl111 is modular. Update the Kconfig to reflect the need.
>
> Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG")
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> v2: use expected Kconfig style to express this. :)
> v1: https://lore.kernel.org/lkml/20210603215819.3904733-1-keescook@chromium.org
> ---
> drivers/gpu/drm/pl111/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends
@ 2021-06-04 12:38 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2021-06-04 12:38 UTC (permalink / raw)
To: Kees Cook; +Cc: David Airlie, dri-devel, Emma Anholt, linux-kernel
On Thu, Jun 3, 2021 at 8:40 PM Kees Cook <keescook@chromium.org> wrote:
>
> VEXPRESS_CONFIG needs to either be missing, built-in, or modular when
> pl111 is modular. Update the Kconfig to reflect the need.
>
> Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG")
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> v2: use expected Kconfig style to express this. :)
> v1: https://lore.kernel.org/lkml/20210603215819.3904733-1-keescook@chromium.org
> ---
> drivers/gpu/drm/pl111/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends
2021-06-04 9:15 ` Daniel Vetter
@ 2021-06-04 13:03 ` Linus Walleij
-1 siblings, 0 replies; 10+ messages in thread
From: Linus Walleij @ 2021-06-04 13:03 UTC (permalink / raw)
To: Linus Walleij, Kees Cook, Emma Anholt, David Airlie,
linux-kernel, open list:DRM PANEL DRIVERS
Cc: Daniel Vetter
On Fri, Jun 4, 2021 at 11:15 AM Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Jun 04, 2021 at 09:44:59AM +0200, Linus Walleij wrote:
> > On Fri, Jun 4, 2021 at 3:41 AM Kees Cook <keescook@chromium.org> wrote:
> >
> > > VEXPRESS_CONFIG needs to either be missing, built-in, or modular when
> > > pl111 is modular. Update the Kconfig to reflect the need.
> > >
> > > Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG")
> >
> > Yeah that doesn't work, thanks for fixing this!
> >
> > > Signed-off-by: Kees Cook <keescook@chromium.org>
> >
> > > - depends on VEXPRESS_CONFIG
> > > + depends on ARM || ARM64 || COMPILE_TEST
> > > + depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n
> >
> > That's the right solution,
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Since I screwed up already, care to also push this to drm-misc-next?
OK I applied and pushed it!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends
@ 2021-06-04 13:03 ` Linus Walleij
0 siblings, 0 replies; 10+ messages in thread
From: Linus Walleij @ 2021-06-04 13:03 UTC (permalink / raw)
To: Linus Walleij, Kees Cook, Emma Anholt, David Airlie,
linux-kernel, open list:DRM PANEL DRIVERS
On Fri, Jun 4, 2021 at 11:15 AM Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Jun 04, 2021 at 09:44:59AM +0200, Linus Walleij wrote:
> > On Fri, Jun 4, 2021 at 3:41 AM Kees Cook <keescook@chromium.org> wrote:
> >
> > > VEXPRESS_CONFIG needs to either be missing, built-in, or modular when
> > > pl111 is modular. Update the Kconfig to reflect the need.
> > >
> > > Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG")
> >
> > Yeah that doesn't work, thanks for fixing this!
> >
> > > Signed-off-by: Kees Cook <keescook@chromium.org>
> >
> > > - depends on VEXPRESS_CONFIG
> > > + depends on ARM || ARM64 || COMPILE_TEST
> > > + depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n
> >
> > That's the right solution,
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Since I screwed up already, care to also push this to drm-misc-next?
OK I applied and pushed it!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-06-04 13:04 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 1:40 [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends Kees Cook
2021-06-04 1:40 ` Kees Cook
2021-06-04 7:44 ` Linus Walleij
2021-06-04 7:44 ` Linus Walleij
2021-06-04 9:15 ` Daniel Vetter
2021-06-04 9:15 ` Daniel Vetter
2021-06-04 13:03 ` Linus Walleij
2021-06-04 13:03 ` Linus Walleij
2021-06-04 12:38 ` Rob Herring
2021-06-04 12:38 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.