* [PATCH] net:cxgb3: fix incorrect work cancellation
@ 2021-06-04 11:36 Íñigo Huguet
2021-06-04 21:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Íñigo Huguet @ 2021-06-04 11:36 UTC (permalink / raw)
To: rajur, davem, kuba; +Cc: ihuguet, ivecera, netdev, linux-kernel, hdanton
In my last changes in commit 5e0b8928927f I introduced a copy-paste bug,
leading to cancel twice qresume_task work for OFLD queue, and never the
one for CTRL queue. This patch cancels correctly both works.
Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
---
drivers/net/ethernet/chelsio/cxgb3/sge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c
index fa91aa57b50a..d1dfccdf571d 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c
@@ -3310,7 +3310,7 @@ void t3_sge_stop(struct adapter *adap)
struct sge_qset *qs = &adap->sge.qs[i];
cancel_work_sync(&qs->txq[TXQ_OFLD].qresume_task);
- cancel_work_sync(&qs->txq[TXQ_OFLD].qresume_task);
+ cancel_work_sync(&qs->txq[TXQ_CTRL].qresume_task);
}
}
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net:cxgb3: fix incorrect work cancellation
2021-06-04 11:36 [PATCH] net:cxgb3: fix incorrect work cancellation Íñigo Huguet
@ 2021-06-04 21:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-04 21:50 UTC (permalink / raw)
To: =?utf-8?b?w43DsWlnbyBIdWd1ZXQgPGlodWd1ZXRAcmVkaGF0LmNvbT4=?=
Cc: rajur, davem, kuba, ivecera, netdev, linux-kernel, hdanton
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 4 Jun 2021 13:36:33 +0200 you wrote:
> In my last changes in commit 5e0b8928927f I introduced a copy-paste bug,
> leading to cancel twice qresume_task work for OFLD queue, and never the
> one for CTRL queue. This patch cancels correctly both works.
>
> Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
> ---
> drivers/net/ethernet/chelsio/cxgb3/sge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- net:cxgb3: fix incorrect work cancellation
https://git.kernel.org/netdev/net-next/c/d5a73dcf0901
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-04 21:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 11:36 [PATCH] net:cxgb3: fix incorrect work cancellation Íñigo Huguet
2021-06-04 21:50 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.