* [Buildroot] [PATCH 1/1] package/dc3dd: disable on riscv32
@ 2021-06-04 18:47 Fabrice Fontaine
2021-06-05 10:12 ` Yann E. MORIN
2021-06-10 20:14 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-06-04 18:47 UTC (permalink / raw)
To: buildroot
Disable dc3dd on riscv32 to avoid the following build failure:
In file included from getdate.y:40:
verify.h:132:30: error: negative width in bit-field 'verify_error_if_negative_size__'
132 | (struct { unsigned int verify_error_if_negative_size__: (R) ? 1 : -1; }))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fixes:
- http://autobuild.buildroot.org/results/267151dec9d2328a5f8c61ddf224219a4f617e5c
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/dc3dd/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/dc3dd/Config.in b/package/dc3dd/Config.in
index 0383897cd5..715451beb7 100644
--- a/package/dc3dd/Config.in
+++ b/package/dc3dd/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_DC3DD
bool "dc3dd"
+ depends on !BR2_RISCV_32
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on !BR2_TOOLCHAIN_USES_MUSL
help
@@ -11,5 +12,6 @@ config BR2_PACKAGE_DC3DD
https://sourceforge.net/projects/dc3dd/
comment "dc3dd needs a glibc or uClibc toolchain w/ threads"
+ depends on !BR2_RISCV_32
depends on !BR2_TOOLCHAIN_HAS_THREADS || \
BR2_TOOLCHAIN_USES_MUSL
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Buildroot] [PATCH 1/1] package/dc3dd: disable on riscv32
2021-06-04 18:47 [Buildroot] [PATCH 1/1] package/dc3dd: disable on riscv32 Fabrice Fontaine
@ 2021-06-05 10:12 ` Yann E. MORIN
2021-06-10 20:14 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-06-05 10:12 UTC (permalink / raw)
To: buildroot
Fabrice, All,
On 2021-06-04 20:47 +0200, Fabrice Fontaine spake thusly:
> Disable dc3dd on riscv32 to avoid the following build failure:
>
> In file included from getdate.y:40:
> verify.h:132:30: error: negative width in bit-field 'verify_error_if_negative_size__'
> 132 | (struct { unsigned int verify_error_if_negative_size__: (R) ? 1 : -1; }))
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
You left out the most important part of the error message:
verify.h:138:61: note: in expansion of macro 'verify_true'
138 | # define verify(R) extern int (* verify_function__ (void)) [verify_true (R)]
| ^~~~~~~~~~~
getdate.y:116:1: note: in expansion of macro 'verify'
116 | verify (LONG_MIN <= TYPE_MINIMUM (time_t) && TYPE_MAXIMUM (time_t) <= LONG_MAX);
| ^~~~~~
This is again the case where riscv32 has never had a 32-bit wide time,
and got 64-bit from the onset.
I've added this extra info to the commit log and applied to master,
thanks.
Regards,
Yann E. MORIN.
> Fixes:
> - http://autobuild.buildroot.org/results/267151dec9d2328a5f8c61ddf224219a4f617e5c
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/dc3dd/Config.in | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/dc3dd/Config.in b/package/dc3dd/Config.in
> index 0383897cd5..715451beb7 100644
> --- a/package/dc3dd/Config.in
> +++ b/package/dc3dd/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_DC3DD
> bool "dc3dd"
> + depends on !BR2_RISCV_32
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on !BR2_TOOLCHAIN_USES_MUSL
> help
> @@ -11,5 +12,6 @@ config BR2_PACKAGE_DC3DD
> https://sourceforge.net/projects/dc3dd/
>
> comment "dc3dd needs a glibc or uClibc toolchain w/ threads"
> + depends on !BR2_RISCV_32
> depends on !BR2_TOOLCHAIN_HAS_THREADS || \
> BR2_TOOLCHAIN_USES_MUSL
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread* [Buildroot] [PATCH 1/1] package/dc3dd: disable on riscv32
2021-06-04 18:47 [Buildroot] [PATCH 1/1] package/dc3dd: disable on riscv32 Fabrice Fontaine
2021-06-05 10:12 ` Yann E. MORIN
@ 2021-06-10 20:14 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-06-10 20:14 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Disable dc3dd on riscv32 to avoid the following build failure:
> In file included from getdate.y:40:
> verify.h:132:30: error: negative width in bit-field 'verify_error_if_negative_size__'
> 132 | (struct { unsigned int verify_error_if_negative_size__: (R) ? 1 : -1; }))
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Fixes:
> - http://autobuild.buildroot.org/results/267151dec9d2328a5f8c61ddf224219a4f617e5c
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-10 20:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 18:47 [Buildroot] [PATCH 1/1] package/dc3dd: disable on riscv32 Fabrice Fontaine
2021-06-05 10:12 ` Yann E. MORIN
2021-06-10 20:14 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.