* [PATCH 1/3] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Elite Dragonfly G2
@ 2021-06-05 8:25 ` Jeremy Szu
0 siblings, 0 replies; 12+ messages in thread
From: Jeremy Szu @ 2021-06-05 8:25 UTC (permalink / raw)
To: tiwai
Cc: moderated list:SOUND, Kailang Yang, Jeremy Szu, open list,
Huacai Chen, Jian-Hong Pan, Hui Wang
The HP Elite Dragonfly G2 using ALC285 codec which using 0x04 to control
mute LED and 0x01 to control micmute LED.
In the other hand, there is no output from right channel of speaker.
Therefore, add a quirk to make it works.
Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 43e37145eb5d..9f65171a902d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8310,6 +8310,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360),
SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENVY_GPIO),
+ SND_PCI_QUIRK(0x103c, 0x8716, "HP Elite Dragonfly G2 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8730, "HP ProBook 445 G7", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
--
2.31.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/3] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP EliteBook x360 1040 G8
2021-06-05 8:25 ` Jeremy Szu
@ 2021-06-05 8:25 ` Jeremy Szu
-1 siblings, 0 replies; 12+ messages in thread
From: Jeremy Szu @ 2021-06-05 8:25 UTC (permalink / raw)
To: tiwai
Cc: Jeremy Szu, Jaroslav Kysela, Kailang Yang, Hui Wang,
Jian-Hong Pan, Chris Chiu, Huacai Chen, moderated list:SOUND,
open list
The HP EliteBook x360 1040 G8 using ALC285 codec which using 0x04 to control
mute LED and 0x01 to control micmute LED.
In the other hand, there is no output from right channel of speaker.
Therefore, add a quirk to make it works.
Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 9f65171a902d..11324163ebe1 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8311,6 +8311,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENVY_GPIO),
SND_PCI_QUIRK(0x103c, 0x8716, "HP Elite Dragonfly G2 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
+ SND_PCI_QUIRK(0x103c, 0x8720, "HP EliteBook x360 1040 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8730, "HP ProBook 445 G7", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
--
2.31.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/3] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP EliteBook x360 1040 G8
@ 2021-06-05 8:25 ` Jeremy Szu
0 siblings, 0 replies; 12+ messages in thread
From: Jeremy Szu @ 2021-06-05 8:25 UTC (permalink / raw)
To: tiwai
Cc: Chris Chiu, moderated list:SOUND, Kailang Yang, Jeremy Szu,
open list, Huacai Chen, Jian-Hong Pan, Hui Wang
The HP EliteBook x360 1040 G8 using ALC285 codec which using 0x04 to control
mute LED and 0x01 to control micmute LED.
In the other hand, there is no output from right channel of speaker.
Therefore, add a quirk to make it works.
Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 9f65171a902d..11324163ebe1 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8311,6 +8311,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENVY_GPIO),
SND_PCI_QUIRK(0x103c, 0x8716, "HP Elite Dragonfly G2 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
+ SND_PCI_QUIRK(0x103c, 0x8720, "HP EliteBook x360 1040 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8730, "HP ProBook 445 G7", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
--
2.31.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 2/3] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP EliteBook x360 1040 G8
2021-06-05 8:25 ` Jeremy Szu
@ 2021-06-05 12:52 ` Takashi Iwai
-1 siblings, 0 replies; 12+ messages in thread
From: Takashi Iwai @ 2021-06-05 12:52 UTC (permalink / raw)
To: Jeremy Szu
Cc: tiwai, Jaroslav Kysela, Kailang Yang, Hui Wang, Jian-Hong Pan,
Chris Chiu, Huacai Chen, moderated list:SOUND, open list
On Sat, 05 Jun 2021 10:25:37 +0200,
Jeremy Szu wrote:
>
> The HP EliteBook x360 1040 G8 using ALC285 codec which using 0x04 to control
> mute LED and 0x01 to control micmute LED.
> In the other hand, there is no output from right channel of speaker.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP EliteBook x360 1040 G8
@ 2021-06-05 12:52 ` Takashi Iwai
0 siblings, 0 replies; 12+ messages in thread
From: Takashi Iwai @ 2021-06-05 12:52 UTC (permalink / raw)
To: Jeremy Szu
Cc: Chris Chiu, moderated list:SOUND, Kailang Yang, open list,
Huacai Chen, Jian-Hong Pan, tiwai, Hui Wang
On Sat, 05 Jun 2021 10:25:37 +0200,
Jeremy Szu wrote:
>
> The HP EliteBook x360 1040 G8 using ALC285 codec which using 0x04 to control
> mute LED and 0x01 to control micmute LED.
> In the other hand, there is no output from right channel of speaker.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 3/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 840 Aero G8
2021-06-05 8:25 ` Jeremy Szu
@ 2021-06-05 8:25 ` Jeremy Szu
-1 siblings, 0 replies; 12+ messages in thread
From: Jeremy Szu @ 2021-06-05 8:25 UTC (permalink / raw)
To: tiwai
Cc: Jeremy Szu, Jaroslav Kysela, Kailang Yang, Hui Wang,
Jian-Hong Pan, Chris Chiu, Huacai Chen, moderated list:SOUND,
open list
The HP EliteBook 840 Aero G8 using ALC285 codec which using 0x04 to
control mute LED and 0x01 to control micmute LED.
In the other hand, there is no output from right channel of speaker.
Therefore, add a quirk to make it works.
Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 11324163ebe1..215beb3ac678 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8330,6 +8330,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x886d, "HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
--
2.31.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 3/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 840 Aero G8
@ 2021-06-05 8:25 ` Jeremy Szu
0 siblings, 0 replies; 12+ messages in thread
From: Jeremy Szu @ 2021-06-05 8:25 UTC (permalink / raw)
To: tiwai
Cc: Chris Chiu, moderated list:SOUND, Kailang Yang, Jeremy Szu,
open list, Huacai Chen, Jian-Hong Pan, Hui Wang
The HP EliteBook 840 Aero G8 using ALC285 codec which using 0x04 to
control mute LED and 0x01 to control micmute LED.
In the other hand, there is no output from right channel of speaker.
Therefore, add a quirk to make it works.
Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 11324163ebe1..215beb3ac678 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8330,6 +8330,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x886d, "HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
--
2.31.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 3/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 840 Aero G8
2021-06-05 8:25 ` Jeremy Szu
@ 2021-06-05 12:52 ` Takashi Iwai
-1 siblings, 0 replies; 12+ messages in thread
From: Takashi Iwai @ 2021-06-05 12:52 UTC (permalink / raw)
To: Jeremy Szu
Cc: tiwai, Jaroslav Kysela, Kailang Yang, Hui Wang, Jian-Hong Pan,
Chris Chiu, Huacai Chen, moderated list:SOUND, open list
On Sat, 05 Jun 2021 10:25:38 +0200,
Jeremy Szu wrote:
>
> The HP EliteBook 840 Aero G8 using ALC285 codec which using 0x04 to
> control mute LED and 0x01 to control micmute LED.
> In the other hand, there is no output from right channel of speaker.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 840 Aero G8
@ 2021-06-05 12:52 ` Takashi Iwai
0 siblings, 0 replies; 12+ messages in thread
From: Takashi Iwai @ 2021-06-05 12:52 UTC (permalink / raw)
To: Jeremy Szu
Cc: Chris Chiu, moderated list:SOUND, Kailang Yang, open list,
Huacai Chen, Jian-Hong Pan, tiwai, Hui Wang
On Sat, 05 Jun 2021 10:25:38 +0200,
Jeremy Szu wrote:
>
> The HP EliteBook 840 Aero G8 using ALC285 codec which using 0x04 to
> control mute LED and 0x01 to control micmute LED.
> In the other hand, there is no output from right channel of speaker.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Elite Dragonfly G2
2021-06-05 8:25 ` Jeremy Szu
@ 2021-06-05 12:52 ` Takashi Iwai
-1 siblings, 0 replies; 12+ messages in thread
From: Takashi Iwai @ 2021-06-05 12:52 UTC (permalink / raw)
To: Jeremy Szu
Cc: tiwai, Jaroslav Kysela, Kailang Yang, Hui Wang, Jian-Hong Pan,
Huacai Chen, moderated list:SOUND, open list
On Sat, 05 Jun 2021 10:25:36 +0200,
Jeremy Szu wrote:
>
> The HP Elite Dragonfly G2 using ALC285 codec which using 0x04 to control
> mute LED and 0x01 to control micmute LED.
> In the other hand, there is no output from right channel of speaker.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Elite Dragonfly G2
@ 2021-06-05 12:52 ` Takashi Iwai
0 siblings, 0 replies; 12+ messages in thread
From: Takashi Iwai @ 2021-06-05 12:52 UTC (permalink / raw)
To: Jeremy Szu
Cc: moderated list:SOUND, Kailang Yang, open list, Huacai Chen,
Jian-Hong Pan, tiwai, Hui Wang
On Sat, 05 Jun 2021 10:25:36 +0200,
Jeremy Szu wrote:
>
> The HP Elite Dragonfly G2 using ALC285 codec which using 0x04 to control
> mute LED and 0x01 to control micmute LED.
> In the other hand, there is no output from right channel of speaker.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 12+ messages in thread