* [PATCH] drm/etnaviv: remove no need NULL check
@ 2021-06-05 12:24 Bernard Zhao
2021-06-07 6:57 ` Christian Gmeiner
0 siblings, 1 reply; 3+ messages in thread
From: Bernard Zhao @ 2021-06-05 12:24 UTC (permalink / raw)
To: Lucas Stach, Russell King, Christian Gmeiner, David Airlie,
Daniel Vetter, etnaviv, dri-devel, linux-kernel
Cc: Bernard Zhao
NULL check before kvfree functions is not needed.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
index d05c35994579..bd0d66ebf314 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
@@ -612,14 +612,10 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
err_submit_cmds:
if (ret && (out_fence_fd >= 0))
put_unused_fd(out_fence_fd);
- if (stream)
- kvfree(stream);
- if (bos)
- kvfree(bos);
- if (relocs)
- kvfree(relocs);
- if (pmrs)
- kvfree(pmrs);
+ kvfree(stream);
+ kvfree(bos);
+ kvfree(relocs);
+ kvfree(pmrs);
return ret;
}
--
2.31.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/etnaviv: remove no need NULL check
2021-06-05 12:24 [PATCH] drm/etnaviv: remove no need NULL check Bernard Zhao
@ 2021-06-07 6:57 ` Christian Gmeiner
0 siblings, 0 replies; 3+ messages in thread
From: Christian Gmeiner @ 2021-06-07 6:57 UTC (permalink / raw)
To: Bernard Zhao
Cc: Lucas Stach, Russell King, David Airlie, Daniel Vetter,
The etnaviv authors, DRI mailing list, LKML
Am Sa., 5. Juni 2021 um 14:24 Uhr schrieb Bernard Zhao <bernard@vivo.com>:
>
> NULL check before kvfree functions is not needed.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> index d05c35994579..bd0d66ebf314 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> @@ -612,14 +612,10 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
> err_submit_cmds:
> if (ret && (out_fence_fd >= 0))
> put_unused_fd(out_fence_fd);
> - if (stream)
> - kvfree(stream);
> - if (bos)
> - kvfree(bos);
> - if (relocs)
> - kvfree(relocs);
> - if (pmrs)
> - kvfree(pmrs);
> + kvfree(stream);
> + kvfree(bos);
> + kvfree(relocs);
> + kvfree(pmrs);
>
> return ret;
> }
> --
> 2.31.0
>
Thanks for the patch, but there is an other one queued up in
etnaviv/next that fixes the same issue:
https://git.pengutronix.de/cgit/lst/linux/commit/?h=etnaviv/next&id=bdf622e0fade2cec72c948c708763378b656c01d
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/etnaviv: remove no need NULL check
@ 2021-06-07 6:57 ` Christian Gmeiner
0 siblings, 0 replies; 3+ messages in thread
From: Christian Gmeiner @ 2021-06-07 6:57 UTC (permalink / raw)
To: Bernard Zhao
Cc: David Airlie, The etnaviv authors, DRI mailing list, LKML, Russell King
Am Sa., 5. Juni 2021 um 14:24 Uhr schrieb Bernard Zhao <bernard@vivo.com>:
>
> NULL check before kvfree functions is not needed.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> index d05c35994579..bd0d66ebf314 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> @@ -612,14 +612,10 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
> err_submit_cmds:
> if (ret && (out_fence_fd >= 0))
> put_unused_fd(out_fence_fd);
> - if (stream)
> - kvfree(stream);
> - if (bos)
> - kvfree(bos);
> - if (relocs)
> - kvfree(relocs);
> - if (pmrs)
> - kvfree(pmrs);
> + kvfree(stream);
> + kvfree(bos);
> + kvfree(relocs);
> + kvfree(pmrs);
>
> return ret;
> }
> --
> 2.31.0
>
Thanks for the patch, but there is an other one queued up in
etnaviv/next that fixes the same issue:
https://git.pengutronix.de/cgit/lst/linux/commit/?h=etnaviv/next&id=bdf622e0fade2cec72c948c708763378b656c01d
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-07 6:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-05 12:24 [PATCH] drm/etnaviv: remove no need NULL check Bernard Zhao
2021-06-07 6:57 ` Christian Gmeiner
2021-06-07 6:57 ` Christian Gmeiner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.