* [PATCH] drm/msm: remove no need local variable
@ 2021-06-05 12:35 Bernard Zhao
2021-06-05 21:25 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Bernard Zhao @ 2021-06-05 12:35 UTC (permalink / raw)
To: Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Kuogee Hsieh,
Stephen Boyd, Bernard Zhao, Guenter Roeck, Chandan Uddaraju,
Abhinav Kumar, linux-arm-msm, dri-devel, freedreno, linux-kernel
Unneeded variable: "ret". Return "0" on line 880
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/gpu/drm/msm/dp/dp_panel.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
index 9cc816663668..8cb3d016101c 100644
--- a/drivers/gpu/drm/msm/dp/dp_panel.c
+++ b/drivers/gpu/drm/msm/dp/dp_panel.c
@@ -351,7 +351,6 @@ void dp_panel_dump_regs(struct dp_panel *dp_panel)
int dp_panel_timing_cfg(struct dp_panel *dp_panel)
{
- int rc = 0;
u32 data, total_ver, total_hor;
struct dp_catalog *catalog;
struct dp_panel_private *panel;
@@ -404,7 +403,7 @@ int dp_panel_timing_cfg(struct dp_panel *dp_panel)
dp_catalog_panel_timing_cfg(catalog);
panel->panel_on = true;
- return rc;
+ return 0;
}
int dp_panel_init_panel_info(struct dp_panel *dp_panel)
--
2.31.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm: remove no need local variable
2021-06-05 12:35 [PATCH] drm/msm: remove no need local variable Bernard Zhao
@ 2021-06-05 21:25 ` Stephen Boyd
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2021-06-05 21:25 UTC (permalink / raw)
To: Abhinav Kumar, Bernard Zhao, Chandan Uddaraju, Daniel Vetter,
David Airlie, Guenter Roeck, Kuogee Hsieh, Rob Clark, Sean Paul,
dri-devel, freedreno, linux-arm-msm, linux-kernel
Quoting Bernard Zhao (2021-06-05 05:35:20)
> Unneeded variable: "ret". Return "0" on line 880
But the variable is "rc".
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
Otherwise
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm: remove no need local variable
@ 2021-06-05 21:25 ` Stephen Boyd
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2021-06-05 21:25 UTC (permalink / raw)
To: Abhinav Kumar, Bernard Zhao, Chandan Uddaraju, Daniel Vetter,
David Airlie, Guenter Roeck, Kuogee Hsieh, Rob Clark, Sean Paul,
dri-devel, freedreno, linux-arm-msm, linux-kernel
Quoting Bernard Zhao (2021-06-05 05:35:20)
> Unneeded variable: "ret". Return "0" on line 880
But the variable is "rc".
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
Otherwise
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-05 21:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-05 12:35 [PATCH] drm/msm: remove no need local variable Bernard Zhao
2021-06-05 21:25 ` Stephen Boyd
2021-06-05 21:25 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.