All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	linux-kernel@vger.kernel.org,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Ard Biesheuvel <ardb@kernel.org>
Subject: arch/arm/boot/compressed/fdt_check_mem_start.c:62:10: warning: no previous prototype for function 'fdt_check_mem_start'
Date: Sun, 6 Jun 2021 09:46:21 +0800	[thread overview]
Message-ID: <202106060913.WGXdGviT-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2980 bytes --]

Hi Geert,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   f5b6eb1e018203913dfefcf6fa988649ad11ad6e
commit: 0673cb38951215060d7993b43ad3c45cd413c2c3 ARM: 9045/1: uncompress: Validate start of physical memory against passed DTB
date:   4 months ago
config: arm-randconfig-r036-20210606 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8ec9aa236e325fd4629cfeefac2919302e14d61a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0673cb38951215060d7993b43ad3c45cd413c2c3
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 0673cb38951215060d7993b43ad3c45cd413c2c3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/arm/boot/compressed/fdt_check_mem_start.c:62:10: warning: no previous prototype for function 'fdt_check_mem_start' [-Wmissing-prototypes]
   uint32_t fdt_check_mem_start(uint32_t mem_start, const void *fdt)
            ^
   arch/arm/boot/compressed/fdt_check_mem_start.c:62:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   uint32_t fdt_check_mem_start(uint32_t mem_start, const void *fdt)
   ^
   static 
   1 warning generated.


vim +/fdt_check_mem_start +62 arch/arm/boot/compressed/fdt_check_mem_start.c

    46	
    47	/*
    48	 * Check the start of physical memory
    49	 *
    50	 * Traditionally, the start address of physical memory is obtained by masking
    51	 * the program counter.  However, this does require that this address is a
    52	 * multiple of 128 MiB, precluding booting Linux on platforms where this
    53	 * requirement is not fulfilled.
    54	 * Hence validate the calculated address against the memory information in the
    55	 * DTB, and, if out-of-range, replace it by the real start address.
    56	 * To preserve backwards compatibility (systems reserving a block of memory
    57	 * at the start of physical memory, kdump, ...), the traditional method is
    58	 * always used if it yields a valid address.
    59	 *
    60	 * Return value: start address of physical memory to use
    61	 */
  > 62	uint32_t fdt_check_mem_start(uint32_t mem_start, const void *fdt)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35287 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: arch/arm/boot/compressed/fdt_check_mem_start.c:62:10: warning: no previous prototype for function 'fdt_check_mem_start'
Date: Sun, 06 Jun 2021 09:46:21 +0800	[thread overview]
Message-ID: <202106060913.WGXdGviT-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3042 bytes --]

Hi Geert,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   f5b6eb1e018203913dfefcf6fa988649ad11ad6e
commit: 0673cb38951215060d7993b43ad3c45cd413c2c3 ARM: 9045/1: uncompress: Validate start of physical memory against passed DTB
date:   4 months ago
config: arm-randconfig-r036-20210606 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8ec9aa236e325fd4629cfeefac2919302e14d61a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0673cb38951215060d7993b43ad3c45cd413c2c3
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 0673cb38951215060d7993b43ad3c45cd413c2c3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/arm/boot/compressed/fdt_check_mem_start.c:62:10: warning: no previous prototype for function 'fdt_check_mem_start' [-Wmissing-prototypes]
   uint32_t fdt_check_mem_start(uint32_t mem_start, const void *fdt)
            ^
   arch/arm/boot/compressed/fdt_check_mem_start.c:62:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   uint32_t fdt_check_mem_start(uint32_t mem_start, const void *fdt)
   ^
   static 
   1 warning generated.


vim +/fdt_check_mem_start +62 arch/arm/boot/compressed/fdt_check_mem_start.c

    46	
    47	/*
    48	 * Check the start of physical memory
    49	 *
    50	 * Traditionally, the start address of physical memory is obtained by masking
    51	 * the program counter.  However, this does require that this address is a
    52	 * multiple of 128 MiB, precluding booting Linux on platforms where this
    53	 * requirement is not fulfilled.
    54	 * Hence validate the calculated address against the memory information in the
    55	 * DTB, and, if out-of-range, replace it by the real start address.
    56	 * To preserve backwards compatibility (systems reserving a block of memory
    57	 * at the start of physical memory, kdump, ...), the traditional method is
    58	 * always used if it yields a valid address.
    59	 *
    60	 * Return value: start address of physical memory to use
    61	 */
  > 62	uint32_t fdt_check_mem_start(uint32_t mem_start, const void *fdt)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35287 bytes --]

             reply	other threads:[~2021-06-06  1:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-06  1:46 kernel test robot [this message]
2021-06-06  1:46 ` arch/arm/boot/compressed/fdt_check_mem_start.c:62:10: warning: no previous prototype for function 'fdt_check_mem_start' kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2021-08-14  5:42 kernel test robot
2021-08-14  5:42 ` kernel test robot
2021-08-21  8:45 ` Geert Uytterhoeven
2021-08-21  8:45   ` Geert Uytterhoeven
2021-08-23  9:14   ` Chen, Rong A
2021-08-25 17:41   ` Nick Desaulniers
2021-08-25 17:41     ` Nick Desaulniers
2021-08-26  7:02     ` Ard Biesheuvel
2021-08-26  7:02       ` Ard Biesheuvel
2021-02-27  2:46 kernel test robot
2021-02-27  2:46 ` kernel test robot
2021-02-27  9:54 ` Geert Uytterhoeven
2021-02-27  9:54   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202106060913.WGXdGviT-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=ardb@kernel.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=geert+renesas@glider.be \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.