All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC][PATCH 0/3] ALSA: pcm/firewire: allow to queue period elapse event in process context
@ 2021-06-06  9:18 Takashi Sakamoto
  2021-06-06  9:18 ` [RFC][PATCH 1/3] ALSA: pcm: add snd_pcm_period_elapsed() variant without acquiring lock of PCM substream Takashi Sakamoto
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Takashi Sakamoto @ 2021-06-06  9:18 UTC (permalink / raw)
  To: tiwai; +Cc: alsa-devel, clemens

Hi,

All of drivers in ALSA firewire stack processes two chances to process
isochronous packets in any isochronous context; in software IRQ context
for 1394 OHCI, and in process context of ALSA PCM application.

In the process context, callbacks of .pointer and .ack are utilized. The
callbacks are done by ALSA PCM core under acquiring lock of PCM substream,

In design of ALSA PCM core, call of snd_pcm_period_elapsed() is used for
drivers to awaken user processes from waiting for available frames. The
function voluntarily acquires lock of PCM substream, therefore it is not
called in the process context since it causes dead lock. As a workaround
to avoid the dead lock, all of drivers in ALSA firewire stack uses
workqueue to delegate the call.

This patchset is my attempt for the issue. A variant of 
'snd_pcm_period_elapsed()' without lock acquisition is going to be added,
named 'snd_pcm_period_elapsed_without_lock()'. This is used in callbacks
of .pointer and .ack of snd_pcm_ops structure.

The patchset is still under my test, but it looks to work well in my
easy and rough test. Before posting for merge, I'd like to get your
comment to the idea. When evaluating, please merge below two histories:
 * 64584f329352 (for-next)
 * 9981b20a5e36 (for-linus)

Takashi Sakamoto (3):
  ALSA: pcm: add snd_pcm_period_elapsed() variant without acquiring lock
    of PCM substream
  ALSA: firewire-lib: queue event of period elapse in process context
  ALSA: firewire-lib: obsolete workqueue for period update

 include/sound/pcm.h           | 53 ++++++++++++++++++++++++++++++++++-
 sound/core/pcm_lib.c          | 25 +++--------------
 sound/firewire/amdtp-stream.c | 46 +++++++++---------------------
 sound/firewire/amdtp-stream.h |  1 -
 4 files changed, 70 insertions(+), 55 deletions(-)

-- 
2.27.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-06-07  3:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-06  9:18 [RFC][PATCH 0/3] ALSA: pcm/firewire: allow to queue period elapse event in process context Takashi Sakamoto
2021-06-06  9:18 ` [RFC][PATCH 1/3] ALSA: pcm: add snd_pcm_period_elapsed() variant without acquiring lock of PCM substream Takashi Sakamoto
2021-06-06  9:18 ` [RFC][PATCH 2/3] ALSA: firewire-lib: queue event of period elapse in process context Takashi Sakamoto
2021-06-06  9:18 ` [RFC][PATCH 3/3] ALSA: firewire-lib: obsolete workqueue for period update Takashi Sakamoto
2021-06-06 10:20 ` [RFC][PATCH 0/3] ALSA: pcm/firewire: allow to queue period elapse event in process context Takashi Iwai
2021-06-07  3:05   ` Takashi Sakamoto

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.