* [PATCH] ASoC: Remove unneeded semicolon in rk817_codec.c
@ 2021-06-04 3:00 Wan Jiabing
2021-06-04 14:26 ` Mark Brown
0 siblings, 1 reply; 7+ messages in thread
From: Wan Jiabing @ 2021-06-04 3:00 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Lee Jones, Chris Morgan, Wan Jiabing, alsa-devel, linux-kernel
Fix following coccicheck warning:
./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
sound/soc/codecs/rk817_codec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rk817_codec.c b/sound/soc/codecs/rk817_codec.c
index fd3a5ba034a9..414d21f22a05 100644
--- a/sound/soc/codecs/rk817_codec.c
+++ b/sound/soc/codecs/rk817_codec.c
@@ -46,7 +46,7 @@ static int rk817_init(struct snd_soc_component *component)
if (rk817->mic_in_differential) {
snd_soc_component_update_bits(component, RK817_CODEC_AMIC_CFG0, MIC_DIFF_MASK,
MIC_DIFF_EN);
- };
+ }
return 0;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: Remove unneeded semicolon in rk817_codec.c
2021-06-04 3:00 [PATCH] ASoC: Remove unneeded semicolon in rk817_codec.c Wan Jiabing
@ 2021-06-04 14:26 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2021-06-04 14:26 UTC (permalink / raw)
To: Wan Jiabing
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Lee Jones,
Chris Morgan, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
On Fri, Jun 04, 2021 at 11:00:23AM +0800, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: Remove unneeded semicolon in rk817_codec.c
@ 2021-06-04 14:26 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2021-06-04 14:26 UTC (permalink / raw)
To: Wan Jiabing
Cc: alsa-devel, linux-kernel, Takashi Iwai, Liam Girdwood,
Chris Morgan, Lee Jones
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
On Fri, Jun 04, 2021 at 11:00:23AM +0800, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re:Re: [PATCH] ASoC: Remove unneeded semicolon in rk817_codec.c
2021-06-04 14:26 ` Mark Brown
@ 2021-06-05 0:58 ` Jiabing Wan
-1 siblings, 0 replies; 7+ messages in thread
From: Jiabing Wan @ 2021-06-05 0:58 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Lee Jones,
Chris Morgan, alsa-devel, linux-kernel
Hi, Mark
>On Fri, Jun 04, 2021 at 11:00:23AM +0800, Wan Jiabing wrote:
>> Fix following coccicheck warning:
>> ./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon
>
>This doesn't apply against current code, please check and resend.
I fixed this based on next-20210603.
And this also applies against next-20210604.
It might be my fault that I didn't decribe the version clearly.
Should I write some description at subject line when working on ASoC of linux-next?
Thanks,
Jiabing
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re:Re: [PATCH] ASoC: Remove unneeded semicolon in rk817_codec.c
@ 2021-06-05 0:58 ` Jiabing Wan
0 siblings, 0 replies; 7+ messages in thread
From: Jiabing Wan @ 2021-06-05 0:58 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, linux-kernel, Takashi Iwai, Liam Girdwood,
Chris Morgan, Lee Jones
Hi, Mark
>On Fri, Jun 04, 2021 at 11:00:23AM +0800, Wan Jiabing wrote:
>> Fix following coccicheck warning:
>> ./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon
>
>This doesn't apply against current code, please check and resend.
I fixed this based on next-20210603.
And this also applies against next-20210604.
It might be my fault that I didn't decribe the version clearly.
Should I write some description at subject line when working on ASoC of linux-next?
Thanks,
Jiabing
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Re: [PATCH] ASoC: Remove unneeded semicolon in rk817_codec.c
2021-06-05 0:58 ` Jiabing Wan
@ 2021-06-07 12:35 ` Mark Brown
-1 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2021-06-07 12:35 UTC (permalink / raw)
To: Jiabing Wan
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Lee Jones,
Chris Morgan, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
On Sat, Jun 05, 2021 at 08:58:31AM +0800, Jiabing Wan wrote:
> >On Fri, Jun 04, 2021 at 11:00:23AM +0800, Wan Jiabing wrote:
> >> Fix following coccicheck warning:
> >> ./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon
> >
> >This doesn't apply against current code, please check and resend.
> I fixed this based on next-20210603.
> And this also applies against next-20210604.
> It might be my fault that I didn't decribe the version clearly.
> Should I write some description at subject line when working on ASoC of linux-next?
I tried to apply this against my current -next targetted code, it's
possible some change happened since the last time -next was built.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Re: [PATCH] ASoC: Remove unneeded semicolon in rk817_codec.c
@ 2021-06-07 12:35 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2021-06-07 12:35 UTC (permalink / raw)
To: Jiabing Wan
Cc: alsa-devel, linux-kernel, Takashi Iwai, Liam Girdwood,
Chris Morgan, Lee Jones
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
On Sat, Jun 05, 2021 at 08:58:31AM +0800, Jiabing Wan wrote:
> >On Fri, Jun 04, 2021 at 11:00:23AM +0800, Wan Jiabing wrote:
> >> Fix following coccicheck warning:
> >> ./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon
> >
> >This doesn't apply against current code, please check and resend.
> I fixed this based on next-20210603.
> And this also applies against next-20210604.
> It might be my fault that I didn't decribe the version clearly.
> Should I write some description at subject line when working on ASoC of linux-next?
I tried to apply this against my current -next targetted code, it's
possible some change happened since the last time -next was built.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-06-07 12:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 3:00 [PATCH] ASoC: Remove unneeded semicolon in rk817_codec.c Wan Jiabing
2021-06-04 14:26 ` Mark Brown
2021-06-04 14:26 ` Mark Brown
2021-06-05 0:58 ` Jiabing Wan
2021-06-05 0:58 ` Jiabing Wan
2021-06-07 12:35 ` Mark Brown
2021-06-07 12:35 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.