All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] docs/tools/virtiofsd: Fix bad rst syntax
@ 2021-06-07 18:00 Thomas Huth
  2021-06-07 18:58 ` Dr. David Alan Gilbert
  2021-06-08  8:29 ` Stefan Hajnoczi
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2021-06-07 18:00 UTC (permalink / raw)
  To: qemu-devel, Stefan Hajnoczi, Dr. David Alan Gilbert; +Cc: qemu-trivial

For literal blocks, there has to be an empty line after the two colons,
and the block itself should be indented.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 docs/tools/virtiofsd.rst | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
index 265a39b0cf..4911e797cb 100644
--- a/docs/tools/virtiofsd.rst
+++ b/docs/tools/virtiofsd.rst
@@ -239,7 +239,7 @@ xattr-mapping Examples
 
 ::
 
--o xattrmap=":prefix:all::user.virtiofs.::bad:all:::"
+ -o xattrmap=":prefix:all::user.virtiofs.::bad:all:::"
 
 
 This uses two rules, using : as the field separator;
@@ -250,7 +250,8 @@ the host set.
 This is equivalent to the 'map' rule:
 
 ::
--o xattrmap=":map::user.virtiofs.:"
+
+ -o xattrmap=":map::user.virtiofs.:"
 
 2) Prefix 'trusted.' attributes, allow others through
 
@@ -277,7 +278,8 @@ through.
 This is equivalent to the 'map' rule:
 
 ::
--o xattrmap="/map/trusted./user.virtiofs./"
+
+ -o xattrmap="/map/trusted./user.virtiofs./"
 
 3) Hide 'security.' attributes, and allow everything else
 
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs/tools/virtiofsd: Fix bad rst syntax
  2021-06-07 18:00 [PATCH] docs/tools/virtiofsd: Fix bad rst syntax Thomas Huth
@ 2021-06-07 18:58 ` Dr. David Alan Gilbert
  2021-06-08  8:29 ` Stefan Hajnoczi
  1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2021-06-07 18:58 UTC (permalink / raw)
  To: Thomas Huth; +Cc: qemu-trivial, qemu-devel, Stefan Hajnoczi

* Thomas Huth (thuth@redhat.com) wrote:
> For literal blocks, there has to be an empty line after the two colons,
> and the block itself should be indented.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Thanks,


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  docs/tools/virtiofsd.rst | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
> index 265a39b0cf..4911e797cb 100644
> --- a/docs/tools/virtiofsd.rst
> +++ b/docs/tools/virtiofsd.rst
> @@ -239,7 +239,7 @@ xattr-mapping Examples
>  
>  ::
>  
> --o xattrmap=":prefix:all::user.virtiofs.::bad:all:::"
> + -o xattrmap=":prefix:all::user.virtiofs.::bad:all:::"
>  
>  
>  This uses two rules, using : as the field separator;
> @@ -250,7 +250,8 @@ the host set.
>  This is equivalent to the 'map' rule:
>  
>  ::
> --o xattrmap=":map::user.virtiofs.:"
> +
> + -o xattrmap=":map::user.virtiofs.:"
>  
>  2) Prefix 'trusted.' attributes, allow others through
>  
> @@ -277,7 +278,8 @@ through.
>  This is equivalent to the 'map' rule:
>  
>  ::
> --o xattrmap="/map/trusted./user.virtiofs./"
> +
> + -o xattrmap="/map/trusted./user.virtiofs./"
>  
>  3) Hide 'security.' attributes, and allow everything else
>  
> -- 
> 2.27.0
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs/tools/virtiofsd: Fix bad rst syntax
  2021-06-07 18:00 [PATCH] docs/tools/virtiofsd: Fix bad rst syntax Thomas Huth
  2021-06-07 18:58 ` Dr. David Alan Gilbert
@ 2021-06-08  8:29 ` Stefan Hajnoczi
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2021-06-08  8:29 UTC (permalink / raw)
  To: Thomas Huth; +Cc: qemu-trivial, qemu-devel, Dr. David Alan Gilbert

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

On Mon, Jun 07, 2021 at 08:00:15PM +0200, Thomas Huth wrote:
> For literal blocks, there has to be an empty line after the two colons,
> and the block itself should be indented.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  docs/tools/virtiofsd.rst | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-08  8:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-07 18:00 [PATCH] docs/tools/virtiofsd: Fix bad rst syntax Thomas Huth
2021-06-07 18:58 ` Dr. David Alan Gilbert
2021-06-08  8:29 ` Stefan Hajnoczi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.