* [PATCH -next] acpi/nvs: fix doc warnings in nvs.c
@ 2021-06-08 2:38 Baokun Li
2021-06-09 13:12 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Baokun Li @ 2021-06-08 2:38 UTC (permalink / raw)
To: rjw, lenb, linux-acpi, linux-kernel
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, libaokun1
Fixes the following W=1 kernel build warning(s):
drivers/acpi/nvs.c:94: warning: Function parameter or
member 'start' not described in 'suspend_nvs_register'
drivers/acpi/nvs.c:94: warning: Function parameter or
member 'size' not described in 'suspend_nvs_register'
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
drivers/acpi/nvs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/nvs.c b/drivers/acpi/nvs.c
index 9f8712a557b3..4609a8a2e42d 100644
--- a/drivers/acpi/nvs.c
+++ b/drivers/acpi/nvs.c
@@ -83,8 +83,8 @@ static LIST_HEAD(nvs_list);
/**
* suspend_nvs_register - register platform NVS memory region to save
- * @start - physical address of the region
- * @size - size of the region
+ * @start: physical address of the region
+ * @size: size of the region
*
* The NVS region need not be page-aligned (both ends) and we arrange
* things so that the data from page-aligned addresses in this region will
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] acpi/nvs: fix doc warnings in nvs.c
2021-06-08 2:38 [PATCH -next] acpi/nvs: fix doc warnings in nvs.c Baokun Li
@ 2021-06-09 13:12 ` Rafael J. Wysocki
2021-06-15 7:29 ` libaokun (A)
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2021-06-09 13:12 UTC (permalink / raw)
To: Baokun Li
Cc: Rafael J. Wysocki, Len Brown, ACPI Devel Maling List,
Linux Kernel Mailing List, Wei Yongjun, Yue Haibing, yangjihong1,
yu kuai
On Tue, Jun 8, 2021 at 4:29 AM Baokun Li <libaokun1@huawei.com> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/acpi/nvs.c:94: warning: Function parameter or
> member 'start' not described in 'suspend_nvs_register'
> drivers/acpi/nvs.c:94: warning: Function parameter or
> member 'size' not described in 'suspend_nvs_register'
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> drivers/acpi/nvs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/nvs.c b/drivers/acpi/nvs.c
> index 9f8712a557b3..4609a8a2e42d 100644
> --- a/drivers/acpi/nvs.c
> +++ b/drivers/acpi/nvs.c
> @@ -83,8 +83,8 @@ static LIST_HEAD(nvs_list);
>
> /**
> * suspend_nvs_register - register platform NVS memory region to save
> - * @start - physical address of the region
> - * @size - size of the region
> + * @start: physical address of the region
> + * @size: size of the region
The format of this kerneldoc comment is still not following the common
style after your change.
Please fix it completely.
> *
> * The NVS region need not be page-aligned (both ends) and we arrange
> * things so that the data from page-aligned addresses in this region will
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] acpi/nvs: fix doc warnings in nvs.c
2021-06-09 13:12 ` Rafael J. Wysocki
@ 2021-06-15 7:29 ` libaokun (A)
0 siblings, 0 replies; 3+ messages in thread
From: libaokun (A) @ 2021-06-15 7:29 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Rafael J. Wysocki, Len Brown, ACPI Devel Maling List,
Linux Kernel Mailing List, Wei Yongjun, Yue Haibing, yangjihong1,
yu kuai
Thank you for your advice.
I'm about to send a patch v2 with the changes suggested by you.
Best Regards.
在 2021/6/9 21:12, Rafael J. Wysocki 写道:
> On Tue, Jun 8, 2021 at 4:29 AM Baokun Li <libaokun1@huawei.com> wrote:
>> Fixes the following W=1 kernel build warning(s):
>>
>> drivers/acpi/nvs.c:94: warning: Function parameter or
>> member 'start' not described in 'suspend_nvs_register'
>> drivers/acpi/nvs.c:94: warning: Function parameter or
>> member 'size' not described in 'suspend_nvs_register'
>>
>> Signed-off-by: Baokun Li <libaokun1@huawei.com>
>> ---
>> drivers/acpi/nvs.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/acpi/nvs.c b/drivers/acpi/nvs.c
>> index 9f8712a557b3..4609a8a2e42d 100644
>> --- a/drivers/acpi/nvs.c
>> +++ b/drivers/acpi/nvs.c
>> @@ -83,8 +83,8 @@ static LIST_HEAD(nvs_list);
>>
>> /**
>> * suspend_nvs_register - register platform NVS memory region to save
>> - * @start - physical address of the region
>> - * @size - size of the region
>> + * @start: physical address of the region
>> + * @size: size of the region
> The format of this kerneldoc comment is still not following the common
> style after your change.
>
> Please fix it completely.
>
>> *
>> * The NVS region need not be page-aligned (both ends) and we arrange
>> * things so that the data from page-aligned addresses in this region will
>> --
>> 2.31.1
>>
> .
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-15 7:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 2:38 [PATCH -next] acpi/nvs: fix doc warnings in nvs.c Baokun Li
2021-06-09 13:12 ` Rafael J. Wysocki
2021-06-15 7:29 ` libaokun (A)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.