All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Kanchan Joshi <joshiiitr@gmail.com>,
	linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>,
	Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org,
	Yuanyuan Zhong <yzhong@purestorage.com>,
	Casey Chen <cachen@purestorage.com>,
	Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCHv3 2/4] nvme: use blk_execute_rq() for passthrough commands
Date: Tue, 8 Jun 2021 07:26:39 +0200	[thread overview]
Message-ID: <20210608052639.GC13828@lst.de> (raw)
In-Reply-To: <20210607161512.GB21631@redsun51.ssa.fujisawa.hgst.com>

On Tue, Jun 08, 2021 at 01:15:12AM +0900, Keith Busch wrote:
> > The new code doesn't retain this flag.
> > Looks good otherwise.
> 
> The flag is only used to select an apporpriate hctx. We've explicitly
> selected a polling hctx in this path already, so the flag is
> unnecessary.

I think setting the flag would still be useful, if only to prevent issues
with new callers and/or better document what we are doing.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Kanchan Joshi <joshiiitr@gmail.com>,
	linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>,
	Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org,
	Yuanyuan Zhong <yzhong@purestorage.com>,
	Casey Chen <cachen@purestorage.com>,
	Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCHv3 2/4] nvme: use blk_execute_rq() for passthrough commands
Date: Tue, 8 Jun 2021 07:26:39 +0200	[thread overview]
Message-ID: <20210608052639.GC13828@lst.de> (raw)
In-Reply-To: <20210607161512.GB21631@redsun51.ssa.fujisawa.hgst.com>

On Tue, Jun 08, 2021 at 01:15:12AM +0900, Keith Busch wrote:
> > The new code doesn't retain this flag.
> > Looks good otherwise.
> 
> The flag is only used to select an apporpriate hctx. We've explicitly
> selected a polling hctx in this path already, so the flag is
> unnecessary.

I think setting the flag would still be useful, if only to prevent issues
with new callers and/or better document what we are doing.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-06-08  5:26 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21 20:21 [PATCHv3 0/4] block and nvme passthrough error handling Keith Busch
2021-05-21 20:21 ` Keith Busch
2021-05-21 20:21 ` [PATCHv3 1/4] block: support polling through blk_execute_rq Keith Busch
2021-05-21 20:21   ` Keith Busch
2021-05-24  7:38   ` Christoph Hellwig
2021-05-24  7:38     ` Christoph Hellwig
2021-05-26  8:16   ` Ming Lei
2021-05-26  8:16     ` Ming Lei
2021-05-21 20:21 ` [PATCHv3 2/4] nvme: use blk_execute_rq() for passthrough commands Keith Busch
2021-05-21 20:21   ` Keith Busch
2021-05-24  7:38   ` Christoph Hellwig
2021-05-24  7:38     ` Christoph Hellwig
2021-05-26  8:24   ` Ming Lei
2021-05-26  8:24     ` Ming Lei
2021-05-26  8:47   ` Kanchan Joshi
2021-05-26  8:47     ` Kanchan Joshi
2021-06-07 16:15     ` Keith Busch
2021-06-07 16:15       ` Keith Busch
2021-06-08  5:26       ` Christoph Hellwig [this message]
2021-06-08  5:26         ` Christoph Hellwig
2021-05-21 20:21 ` [PATCHv3 3/4] block: return errors from blk_execute_rq() Keith Busch
2021-05-21 20:21   ` Keith Busch
2021-05-24  7:39   ` Christoph Hellwig
2021-05-24  7:39     ` Christoph Hellwig
2021-05-26  8:26   ` Ming Lei
2021-05-26  8:26     ` Ming Lei
2021-05-21 20:21 ` [PATCHv3 4/4] nvme: use return value " Keith Busch
2021-05-21 20:21   ` Keith Busch
2021-05-24  8:04   ` Christoph Hellwig
2021-05-24  8:04     ` Christoph Hellwig
2021-06-07 16:58     ` Keith Busch
2021-06-07 16:58       ` Keith Busch
2021-06-08  5:26       ` Christoph Hellwig
2021-06-08  5:26         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210608052639.GC13828@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=cachen@purestorage.com \
    --cc=joshiiitr@gmail.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=ming.lei@redhat.com \
    --cc=sagi@grimberg.me \
    --cc=yzhong@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.