All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] scsi: lpfc: lpfc_mem: Removed unnecessary 'return'
@ 2021-06-08  6:04 lijian_8010a29
  2021-06-08 16:22 ` James Smart
  2021-06-08 16:25 ` James Smart
  0 siblings, 2 replies; 3+ messages in thread
From: lijian_8010a29 @ 2021-06-08  6:04 UTC (permalink / raw)
  To: james.smart, dick.kennedy, jejb, martin.petersen
  Cc: linux-scsi, linux-kernel, lijian

From: lijian <lijian@yulong.com>

Removed unnecessary 'return'.

Signed-off-by: lijian <lijian@yulong.com>
---
 drivers/scsi/lpfc/lpfc_mem.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_mem.c b/drivers/scsi/lpfc/lpfc_mem.c
index be54fbf5146f..f5b4c4a81eba 100644
--- a/drivers/scsi/lpfc/lpfc_mem.c
+++ b/drivers/scsi/lpfc/lpfc_mem.c
@@ -269,7 +269,6 @@ lpfc_mem_free(struct lpfc_hba *phba)
 		mempool_destroy(phba->device_data_mem_pool);
 	}
 	phba->device_data_mem_pool = NULL;
-	return;
 }
 
 /**
@@ -338,8 +337,6 @@ lpfc_mem_free_all(struct lpfc_hba *phba)
 	/* Free the iocb lookup array */
 	kfree(psli->iocbq_lookup);
 	psli->iocbq_lookup = NULL;
-
-	return;
 }
 
 /**
@@ -405,7 +402,6 @@ __lpfc_mbuf_free(struct lpfc_hba * phba, void *virt, dma_addr_t dma)
 	} else {
 		dma_pool_free(phba->lpfc_mbuf_pool, virt, dma);
 	}
-	return;
 }
 
 /**
@@ -429,7 +425,6 @@ lpfc_mbuf_free(struct lpfc_hba * phba, void *virt, dma_addr_t dma)
 	spin_lock_irqsave(&phba->hbalock, iflags);
 	__lpfc_mbuf_free(phba, virt, dma);
 	spin_unlock_irqrestore(&phba->hbalock, iflags);
-	return;
 }
 
 /**
@@ -519,7 +514,6 @@ lpfc_els_hbq_free(struct lpfc_hba *phba, struct hbq_dmabuf *hbqbp)
 {
 	dma_pool_free(phba->lpfc_hbq_pool, hbqbp->dbuf.virt, hbqbp->dbuf.phys);
 	kfree(hbqbp);
-	return;
 }
 
 /**
@@ -682,7 +676,6 @@ lpfc_in_buf_free(struct lpfc_hba *phba, struct lpfc_dmabuf *mp)
 		lpfc_mbuf_free(phba, mp->virt, mp->phys);
 		kfree(mp);
 	}
-	return;
 }
 
 /**
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: lpfc: lpfc_mem: Removed unnecessary 'return'
  2021-06-08  6:04 [PATCH] scsi: lpfc: lpfc_mem: Removed unnecessary 'return' lijian_8010a29
@ 2021-06-08 16:22 ` James Smart
  2021-06-08 16:25 ` James Smart
  1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2021-06-08 16:22 UTC (permalink / raw)
  To: lijian_8010a29, dick.kennedy, jejb, martin.petersen
  Cc: linux-scsi, linux-kernel, lijian

[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]



On 6/7/2021 11:04 PM, lijian_8010a29@163.com wrote:
> From: lijian <lijian@yulong.com>
>
> Removed unnecessary 'return'.
>
> Signed-off-by: lijian <lijian@yulong.com>
> ---
>   drivers/scsi/lpfc/lpfc_mem.c | 7 -------
>   1 file changed, 7 deletions(-)
>
>

Looks good

Reviewed-by: James Smart <jsmart2021@gmail.com>

-- james


-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4206 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: lpfc: lpfc_mem: Removed unnecessary 'return'
  2021-06-08  6:04 [PATCH] scsi: lpfc: lpfc_mem: Removed unnecessary 'return' lijian_8010a29
  2021-06-08 16:22 ` James Smart
@ 2021-06-08 16:25 ` James Smart
  1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2021-06-08 16:25 UTC (permalink / raw)
  To: lijian_8010a29, dick.kennedy, jejb, martin.petersen
  Cc: linux-scsi, linux-kernel, lijian



On 6/7/2021 11:04 PM, lijian_8010a29@163.com wrote:
> From: lijian <lijian@yulong.com>
>
> Removed unnecessary 'return'.
>
> Signed-off-by: lijian <lijian@yulong.com>
> ---
>   drivers/scsi/lpfc/lpfc_mem.c | 7 -------
>   1 file changed, 7 deletions(-)
>
>
acking with the right email

Thanks

Reviewed-by: James Smart <jsmart2021@gmail.com>

-- james

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-08 16:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08  6:04 [PATCH] scsi: lpfc: lpfc_mem: Removed unnecessary 'return' lijian_8010a29
2021-06-08 16:22 ` James Smart
2021-06-08 16:25 ` James Smart

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.