* [PATCH 1/1] drm/amdgpu: fix shadow bo skip condition
@ 2021-06-08 10:06 Nirmoy Das
2021-06-08 10:59 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Nirmoy Das @ 2021-06-08 10:06 UTC (permalink / raw)
To: amd-gfx; +Cc: Nirmoy Das, Christian.Koenig
Create shadow BOs only for no-compute VM context and only for dGPU.
The existing if-condition would create shadow bo for compute context
on dGPU which not what we wanted.
Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 74c7d8b21c98..e2146caf6866 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -908,7 +908,7 @@ static int amdgpu_vm_pt_create(struct amdgpu_device *adev,
return r;
bo = &(*vmbo)->bo;
- if (vm->is_compute_context && (adev->flags & AMD_IS_APU)) {
+ if (vm->is_compute_context || (adev->flags & AMD_IS_APU)) {
(*vmbo)->shadow = NULL;
return 0;
}
--
2.31.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] drm/amdgpu: fix shadow bo skip condition
2021-06-08 10:06 [PATCH 1/1] drm/amdgpu: fix shadow bo skip condition Nirmoy Das
@ 2021-06-08 10:59 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2021-06-08 10:59 UTC (permalink / raw)
To: Nirmoy Das, amd-gfx
Am 08.06.21 um 12:06 schrieb Nirmoy Das:
> Create shadow BOs only for no-compute VM context and only for dGPU.
> The existing if-condition would create shadow bo for compute context
> on dGPU which not what we wanted.
>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 74c7d8b21c98..e2146caf6866 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -908,7 +908,7 @@ static int amdgpu_vm_pt_create(struct amdgpu_device *adev,
> return r;
>
> bo = &(*vmbo)->bo;
> - if (vm->is_compute_context && (adev->flags & AMD_IS_APU)) {
> + if (vm->is_compute_context || (adev->flags & AMD_IS_APU)) {
> (*vmbo)->shadow = NULL;
> return 0;
> }
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-08 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 10:06 [PATCH 1/1] drm/amdgpu: fix shadow bo skip condition Nirmoy Das
2021-06-08 10:59 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.