From: Jan Kara <jack@suse.cz> To: "Darrick J. Wong" <djwong@kernel.org> Cc: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@infradead.org>, Dave Chinner <david@fromorbit.com>, ceph-devel@vger.kernel.org, Chao Yu <yuchao0@huawei.com>, Damien Le Moal <damien.lemoal@wdc.com>, "Darrick J. Wong" <darrick.wong@oracle.com>, Jaegeuk Kim <jaegeuk@kernel.org>, Jeff Layton <jlayton@kernel.org>, Johannes Thumshirn <jth@kernel.org>, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-xfs@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>, Steve French <sfrench@samba.org>, Ted Tso <tytso@mit.edu>, Matthew Wilcox <willy@infradead.org>, Christoph Hellwig <hch@lst.de> Subject: Re: [PATCH 08/14] xfs: Convert to use invalidate_lock Date: Tue, 8 Jun 2021 14:23:40 +0200 [thread overview] Message-ID: <20210608122340.GH5562@quack2.suse.cz> (raw) In-Reply-To: <20210607155633.GI2945738@locust> On Mon 07-06-21 08:56:33, Darrick J. Wong wrote: > On Mon, Jun 07, 2021 at 04:52:18PM +0200, Jan Kara wrote: > > Use invalidate_lock instead of XFS internal i_mmap_lock. The intended > > purpose of invalidate_lock is exactly the same. Note that the locking in > > __xfs_filemap_fault() slightly changes as filemap_fault() already takes > > invalidate_lock. > > > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > CC: <linux-xfs@vger.kernel.org> > > CC: "Darrick J. Wong" <djwong@kernel.org> > > Signed-off-by: Jan Kara <jack@suse.cz> > > --- > > fs/xfs/xfs_file.c | 13 +++++++----- > > fs/xfs/xfs_inode.c | 50 ++++++++++++++++++++++++---------------------- > > fs/xfs/xfs_inode.h | 1 - > > fs/xfs/xfs_super.c | 2 -- > > 4 files changed, 34 insertions(+), 32 deletions(-) > > > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > > index 396ef36dcd0a..7cb7703c2209 100644 > > --- a/fs/xfs/xfs_file.c > > +++ b/fs/xfs/xfs_file.c > > @@ -1282,7 +1282,7 @@ xfs_file_llseek( > > * > > * mmap_lock (MM) > > * sb_start_pagefault(vfs, freeze) > > - * i_mmaplock (XFS - truncate serialisation) > > + * invalidate_lock (vfs/XFS_MMAPLOCK - truncate serialisation) > > * page_lock (MM) > > * i_lock (XFS - extent map serialisation) > > */ > > @@ -1303,24 +1303,27 @@ __xfs_filemap_fault( > > file_update_time(vmf->vma->vm_file); > > } > > > > - xfs_ilock(XFS_I(inode), XFS_MMAPLOCK_SHARED); > > if (IS_DAX(inode)) { > > pfn_t pfn; > > > > + xfs_ilock(XFS_I(inode), XFS_MMAPLOCK_SHARED); > > ret = dax_iomap_fault(vmf, pe_size, &pfn, NULL, > > (write_fault && !vmf->cow_page) ? > > &xfs_direct_write_iomap_ops : > > &xfs_read_iomap_ops); > > if (ret & VM_FAULT_NEEDDSYNC) > > ret = dax_finish_sync_fault(vmf, pe_size, pfn); > > + xfs_iunlock(XFS_I(inode), XFS_MMAPLOCK_SHARED); > > I've been wondering if iomap_page_mkwrite and dax_iomap_fault should be > taking these locks? I guess that would violate the premise that iomap > requires that callers arrange for concurrency control (i.e. iomap > doesn't take locks). Well, iomap does take page locks but I agree that generally it stays away from high-level locks. So keeping invalidate_lock out of it makes more sense to me as well. > Code changes look fine, though. > > Reviewed-by: Darrick J. Wong <djwong@kernel.org> Thanks! Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz> To: "Darrick J. Wong" <djwong@kernel.org> Cc: linux-cifs@vger.kernel.org, Damien Le Moal <damien.lemoal@wdc.com>, linux-ext4@vger.kernel.org, Jan Kara <jack@suse.cz>, "Darrick J. Wong" <darrick.wong@oracle.com>, Jeff Layton <jlayton@kernel.org>, Steve French <sfrench@samba.org>, Dave Chinner <david@fromorbit.com>, Matthew Wilcox <willy@infradead.org>, linux-f2fs-devel@lists.sourceforge.net, Christoph Hellwig <hch@infradead.org>, linux-mm@kvack.org, Miklos Szeredi <miklos@szeredi.hu>, Ted Tso <tytso@mit.edu>, linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>, ceph-devel@vger.kernel.org, Johannes Thumshirn <jth@kernel.org>, Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org Subject: Re: [f2fs-dev] [PATCH 08/14] xfs: Convert to use invalidate_lock Date: Tue, 8 Jun 2021 14:23:40 +0200 [thread overview] Message-ID: <20210608122340.GH5562@quack2.suse.cz> (raw) In-Reply-To: <20210607155633.GI2945738@locust> On Mon 07-06-21 08:56:33, Darrick J. Wong wrote: > On Mon, Jun 07, 2021 at 04:52:18PM +0200, Jan Kara wrote: > > Use invalidate_lock instead of XFS internal i_mmap_lock. The intended > > purpose of invalidate_lock is exactly the same. Note that the locking in > > __xfs_filemap_fault() slightly changes as filemap_fault() already takes > > invalidate_lock. > > > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > CC: <linux-xfs@vger.kernel.org> > > CC: "Darrick J. Wong" <djwong@kernel.org> > > Signed-off-by: Jan Kara <jack@suse.cz> > > --- > > fs/xfs/xfs_file.c | 13 +++++++----- > > fs/xfs/xfs_inode.c | 50 ++++++++++++++++++++++++---------------------- > > fs/xfs/xfs_inode.h | 1 - > > fs/xfs/xfs_super.c | 2 -- > > 4 files changed, 34 insertions(+), 32 deletions(-) > > > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > > index 396ef36dcd0a..7cb7703c2209 100644 > > --- a/fs/xfs/xfs_file.c > > +++ b/fs/xfs/xfs_file.c > > @@ -1282,7 +1282,7 @@ xfs_file_llseek( > > * > > * mmap_lock (MM) > > * sb_start_pagefault(vfs, freeze) > > - * i_mmaplock (XFS - truncate serialisation) > > + * invalidate_lock (vfs/XFS_MMAPLOCK - truncate serialisation) > > * page_lock (MM) > > * i_lock (XFS - extent map serialisation) > > */ > > @@ -1303,24 +1303,27 @@ __xfs_filemap_fault( > > file_update_time(vmf->vma->vm_file); > > } > > > > - xfs_ilock(XFS_I(inode), XFS_MMAPLOCK_SHARED); > > if (IS_DAX(inode)) { > > pfn_t pfn; > > > > + xfs_ilock(XFS_I(inode), XFS_MMAPLOCK_SHARED); > > ret = dax_iomap_fault(vmf, pe_size, &pfn, NULL, > > (write_fault && !vmf->cow_page) ? > > &xfs_direct_write_iomap_ops : > > &xfs_read_iomap_ops); > > if (ret & VM_FAULT_NEEDDSYNC) > > ret = dax_finish_sync_fault(vmf, pe_size, pfn); > > + xfs_iunlock(XFS_I(inode), XFS_MMAPLOCK_SHARED); > > I've been wondering if iomap_page_mkwrite and dax_iomap_fault should be > taking these locks? I guess that would violate the premise that iomap > requires that callers arrange for concurrency control (i.e. iomap > doesn't take locks). Well, iomap does take page locks but I agree that generally it stays away from high-level locks. So keeping invalidate_lock out of it makes more sense to me as well. > Code changes look fine, though. > > Reviewed-by: Darrick J. Wong <djwong@kernel.org> Thanks! Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-06-08 12:23 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-07 14:52 [PATCH 0/14 v7] fs: Hole punch vs page cache filling races Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 01/14] mm: Fix comments mentioning i_mutex Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 15:31 ` Darrick J. Wong 2021-06-07 15:31 ` [f2fs-dev] " Darrick J. Wong 2021-06-10 9:06 ` Ming Lei 2021-06-10 9:06 ` [f2fs-dev] " Ming Lei 2021-06-10 10:40 ` Jan Kara 2021-06-10 10:40 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 02/14] documentation: Sync file_operations members with reality Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 03/14] mm: Protect operations adding pages to page cache with invalidate_lock Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 16:09 ` Darrick J. Wong 2021-06-07 16:09 ` [f2fs-dev] " Darrick J. Wong 2021-06-08 12:19 ` Jan Kara 2021-06-08 12:19 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 04/14] mm: Add functions to lock invalidate_lock for two mappings Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 15:46 ` Darrick J. Wong 2021-06-07 15:46 ` [f2fs-dev] " Darrick J. Wong 2021-06-07 14:52 ` [PATCH 05/14] ext4: Convert to use mapping->invalidate_lock Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 06/14] ext2: Convert to using invalidate_lock Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 07/14] xfs: Refactor xfs_isilocked() Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 15:49 ` Darrick J. Wong 2021-06-07 15:49 ` [f2fs-dev] " Darrick J. Wong 2021-06-08 22:18 ` Dave Chinner 2021-06-08 22:18 ` [f2fs-dev] " Dave Chinner 2021-06-07 14:52 ` [PATCH 08/14] xfs: Convert to use invalidate_lock Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 15:56 ` Darrick J. Wong 2021-06-07 15:56 ` [f2fs-dev] " Darrick J. Wong 2021-06-08 12:23 ` Jan Kara [this message] 2021-06-08 12:23 ` Jan Kara 2021-06-07 14:52 ` [PATCH 09/14] xfs: Convert double locking of MMAPLOCK to use VFS helpers Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 15:57 ` Darrick J. Wong 2021-06-07 15:57 ` [f2fs-dev] " Darrick J. Wong 2021-06-07 14:52 ` [PATCH 10/14] zonefs: Convert to using invalidate_lock Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 11/14] f2fs: " Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 12/14] fuse: " Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-10 12:42 ` Miklos Szeredi 2021-06-10 12:42 ` [f2fs-dev] " Miklos Szeredi 2021-06-10 12:42 ` Miklos Szeredi 2021-06-07 14:52 ` [PATCH 13/14] ceph: Fix race between hole punch and page fault Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 14/14] cifs: " Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-08 11:54 ` [PATCH 0/14 v7] fs: Hole punch vs page cache filling races Jan Kara 2021-06-08 11:54 ` [f2fs-dev] " Jan Kara 2021-06-15 9:17 [PATCH 0/14 v8] " Jan Kara 2021-06-15 9:17 ` [PATCH 08/14] xfs: Convert to use invalidate_lock Jan Kara 2021-07-12 16:55 [PATCH 0/14 v9] fs: Hole punch vs page cache filling races Jan Kara 2021-07-12 16:55 ` [PATCH 08/14] xfs: Convert to use invalidate_lock Jan Kara 2021-07-15 13:40 [PATCH 0/14 v10] fs: Hole punch vs page cache filling races Jan Kara 2021-07-15 13:40 ` [PATCH 08/14] xfs: Convert to use invalidate_lock Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210608122340.GH5562@quack2.suse.cz \ --to=jack@suse.cz \ --cc=ceph-devel@vger.kernel.org \ --cc=damien.lemoal@wdc.com \ --cc=darrick.wong@oracle.com \ --cc=david@fromorbit.com \ --cc=djwong@kernel.org \ --cc=hch@infradead.org \ --cc=hch@lst.de \ --cc=jaegeuk@kernel.org \ --cc=jlayton@kernel.org \ --cc=jth@kernel.org \ --cc=linux-cifs@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-xfs@vger.kernel.org \ --cc=miklos@szeredi.hu \ --cc=sfrench@samba.org \ --cc=tytso@mit.edu \ --cc=willy@infradead.org \ --cc=yuchao0@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.