* Re: [PATCH v2] arm64: dts: mt8183: add jpeg enc node for mt8183
@ 2021-06-09 7:46 ` Matthias Brugger
0 siblings, 0 replies; 9+ messages in thread
From: Matthias Brugger @ 2021-06-09 7:46 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Rob Herring, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, maoguang.meng, yong.wu, tfiga
On 09/06/2021 06:48, Hsin-Yi Wang wrote:
> From: Maoguang Meng <maoguang.meng@mediatek.com>
>
> Add jpeg encoder device tree node.
>
> Signed-off-by: Maoguang Meng <maoguang.meng@mediatek.com>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> v2: rebase to latest
> v1: https://patchwork.kernel.org/project/linux-media/patch/20200914094012.5817-1-maoguang.meng@mediatek.com/
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index c5e822b6b77a3..fffe0c52909ce 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1329,6 +1329,17 @@ larb4: larb@17010000 {
> power-domains = <&spm MT8183_POWER_DOMAIN_VENC>;
> };
>
> + venc_jpg: venc_jpg@17030000 {
> + compatible = "mediatek,mt8183-jpgenc", "mediatek,mtk-jpgenc";
We are missing "mediatek,mt8183-jpgenc" in mediatek-jpeg-encoder.txt. Would be
great if you could help to convert it to yaml before adding the new compatible.
Thanks!
Matthias
> + reg = <0 0x17030000 0 0x1000>;
> + interrupts = <GIC_SPI 249 IRQ_TYPE_LEVEL_LOW>;
> + iommus = <&iommu M4U_PORT_JPGENC_RDMA>,
> + <&iommu M4U_PORT_JPGENC_BSDMA>;
> + power-domains = <&spm MT8183_POWER_DOMAIN_VENC>;
> + clocks = <&vencsys CLK_VENC_JPGENC>;
> + clock-names = "jpgenc";
> + };
> +
> ipu_conn: syscon@19000000 {
> compatible = "mediatek,mt8183-ipu_conn", "syscon";
> reg = <0 0x19000000 0 0x1000>;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] arm64: dts: mt8183: add jpeg enc node for mt8183
@ 2021-06-09 7:46 ` Matthias Brugger
0 siblings, 0 replies; 9+ messages in thread
From: Matthias Brugger @ 2021-06-09 7:46 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Rob Herring, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, maoguang.meng, yong.wu, tfiga
On 09/06/2021 06:48, Hsin-Yi Wang wrote:
> From: Maoguang Meng <maoguang.meng@mediatek.com>
>
> Add jpeg encoder device tree node.
>
> Signed-off-by: Maoguang Meng <maoguang.meng@mediatek.com>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> v2: rebase to latest
> v1: https://patchwork.kernel.org/project/linux-media/patch/20200914094012.5817-1-maoguang.meng@mediatek.com/
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index c5e822b6b77a3..fffe0c52909ce 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1329,6 +1329,17 @@ larb4: larb@17010000 {
> power-domains = <&spm MT8183_POWER_DOMAIN_VENC>;
> };
>
> + venc_jpg: venc_jpg@17030000 {
> + compatible = "mediatek,mt8183-jpgenc", "mediatek,mtk-jpgenc";
We are missing "mediatek,mt8183-jpgenc" in mediatek-jpeg-encoder.txt. Would be
great if you could help to convert it to yaml before adding the new compatible.
Thanks!
Matthias
> + reg = <0 0x17030000 0 0x1000>;
> + interrupts = <GIC_SPI 249 IRQ_TYPE_LEVEL_LOW>;
> + iommus = <&iommu M4U_PORT_JPGENC_RDMA>,
> + <&iommu M4U_PORT_JPGENC_BSDMA>;
> + power-domains = <&spm MT8183_POWER_DOMAIN_VENC>;
> + clocks = <&vencsys CLK_VENC_JPGENC>;
> + clock-names = "jpgenc";
> + };
> +
> ipu_conn: syscon@19000000 {
> compatible = "mediatek,mt8183-ipu_conn", "syscon";
> reg = <0 0x19000000 0 0x1000>;
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] arm64: dts: mt8183: add jpeg enc node for mt8183
2021-06-09 7:46 ` Matthias Brugger
(?)
@ 2021-06-09 10:46 ` Hsin-Yi Wang
-1 siblings, 0 replies; 9+ messages in thread
From: Hsin-Yi Wang @ 2021-06-09 10:46 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Devicetree List,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/Mediatek SoC support, lkml, maoguang.meng,
Yong Wu, Tomasz Figa
On Wed, Jun 9, 2021 at 3:46 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
>
>
> On 09/06/2021 06:48, Hsin-Yi Wang wrote:
> > From: Maoguang Meng <maoguang.meng@mediatek.com>
> >
> > Add jpeg encoder device tree node.
> >
> > Signed-off-by: Maoguang Meng <maoguang.meng@mediatek.com>
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > ---
> > v2: rebase to latest
> > v1: https://patchwork.kernel.org/project/linux-media/patch/20200914094012.5817-1-maoguang.meng@mediatek.com/
> > ---
> > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index c5e822b6b77a3..fffe0c52909ce 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -1329,6 +1329,17 @@ larb4: larb@17010000 {
> > power-domains = <&spm MT8183_POWER_DOMAIN_VENC>;
> > };
> >
> > + venc_jpg: venc_jpg@17030000 {
> > + compatible = "mediatek,mt8183-jpgenc", "mediatek,mtk-jpgenc";
>
> We are missing "mediatek,mt8183-jpgenc" in mediatek-jpeg-encoder.txt. Would be
> great if you could help to convert it to yaml before adding the new compatible.
>
mediatek-jpeg-en(de)coder.txt converted to yaml:
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210609104053.617751-1-hsinyi@chromium.org/
> Thanks!
> Matthias
> > + reg = <0 0x17030000 0 0x1000>;
> > + interrupts = <GIC_SPI 249 IRQ_TYPE_LEVEL_LOW>;
> > + iommus = <&iommu M4U_PORT_JPGENC_RDMA>,
> > + <&iommu M4U_PORT_JPGENC_BSDMA>;
> > + power-domains = <&spm MT8183_POWER_DOMAIN_VENC>;
> > + clocks = <&vencsys CLK_VENC_JPGENC>;
> > + clock-names = "jpgenc";
> > + };
> > +
> > ipu_conn: syscon@19000000 {
> > compatible = "mediatek,mt8183-ipu_conn", "syscon";
> > reg = <0 0x19000000 0 0x1000>;
> >
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] arm64: dts: mt8183: add jpeg enc node for mt8183
@ 2021-06-09 10:46 ` Hsin-Yi Wang
0 siblings, 0 replies; 9+ messages in thread
From: Hsin-Yi Wang @ 2021-06-09 10:46 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Devicetree List,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/Mediatek SoC support, lkml, maoguang.meng,
Yong Wu, Tomasz Figa
On Wed, Jun 9, 2021 at 3:46 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
>
>
> On 09/06/2021 06:48, Hsin-Yi Wang wrote:
> > From: Maoguang Meng <maoguang.meng@mediatek.com>
> >
> > Add jpeg encoder device tree node.
> >
> > Signed-off-by: Maoguang Meng <maoguang.meng@mediatek.com>
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > ---
> > v2: rebase to latest
> > v1: https://patchwork.kernel.org/project/linux-media/patch/20200914094012.5817-1-maoguang.meng@mediatek.com/
> > ---
> > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index c5e822b6b77a3..fffe0c52909ce 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -1329,6 +1329,17 @@ larb4: larb@17010000 {
> > power-domains = <&spm MT8183_POWER_DOMAIN_VENC>;
> > };
> >
> > + venc_jpg: venc_jpg@17030000 {
> > + compatible = "mediatek,mt8183-jpgenc", "mediatek,mtk-jpgenc";
>
> We are missing "mediatek,mt8183-jpgenc" in mediatek-jpeg-encoder.txt. Would be
> great if you could help to convert it to yaml before adding the new compatible.
>
mediatek-jpeg-en(de)coder.txt converted to yaml:
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210609104053.617751-1-hsinyi@chromium.org/
> Thanks!
> Matthias
> > + reg = <0 0x17030000 0 0x1000>;
> > + interrupts = <GIC_SPI 249 IRQ_TYPE_LEVEL_LOW>;
> > + iommus = <&iommu M4U_PORT_JPGENC_RDMA>,
> > + <&iommu M4U_PORT_JPGENC_BSDMA>;
> > + power-domains = <&spm MT8183_POWER_DOMAIN_VENC>;
> > + clocks = <&vencsys CLK_VENC_JPGENC>;
> > + clock-names = "jpgenc";
> > + };
> > +
> > ipu_conn: syscon@19000000 {
> > compatible = "mediatek,mt8183-ipu_conn", "syscon";
> > reg = <0 0x19000000 0 0x1000>;
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] arm64: dts: mt8183: add jpeg enc node for mt8183
@ 2021-06-09 10:46 ` Hsin-Yi Wang
0 siblings, 0 replies; 9+ messages in thread
From: Hsin-Yi Wang @ 2021-06-09 10:46 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Devicetree List,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/Mediatek SoC support, lkml, maoguang.meng,
Yong Wu, Tomasz Figa
On Wed, Jun 9, 2021 at 3:46 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
>
>
> On 09/06/2021 06:48, Hsin-Yi Wang wrote:
> > From: Maoguang Meng <maoguang.meng@mediatek.com>
> >
> > Add jpeg encoder device tree node.
> >
> > Signed-off-by: Maoguang Meng <maoguang.meng@mediatek.com>
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > ---
> > v2: rebase to latest
> > v1: https://patchwork.kernel.org/project/linux-media/patch/20200914094012.5817-1-maoguang.meng@mediatek.com/
> > ---
> > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index c5e822b6b77a3..fffe0c52909ce 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -1329,6 +1329,17 @@ larb4: larb@17010000 {
> > power-domains = <&spm MT8183_POWER_DOMAIN_VENC>;
> > };
> >
> > + venc_jpg: venc_jpg@17030000 {
> > + compatible = "mediatek,mt8183-jpgenc", "mediatek,mtk-jpgenc";
>
> We are missing "mediatek,mt8183-jpgenc" in mediatek-jpeg-encoder.txt. Would be
> great if you could help to convert it to yaml before adding the new compatible.
>
mediatek-jpeg-en(de)coder.txt converted to yaml:
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210609104053.617751-1-hsinyi@chromium.org/
> Thanks!
> Matthias
> > + reg = <0 0x17030000 0 0x1000>;
> > + interrupts = <GIC_SPI 249 IRQ_TYPE_LEVEL_LOW>;
> > + iommus = <&iommu M4U_PORT_JPGENC_RDMA>,
> > + <&iommu M4U_PORT_JPGENC_BSDMA>;
> > + power-domains = <&spm MT8183_POWER_DOMAIN_VENC>;
> > + clocks = <&vencsys CLK_VENC_JPGENC>;
> > + clock-names = "jpgenc";
> > + };
> > +
> > ipu_conn: syscon@19000000 {
> > compatible = "mediatek,mt8183-ipu_conn", "syscon";
> > reg = <0 0x19000000 0 0x1000>;
> >
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 9+ messages in thread