Re: [Intel-gfx] [PATCH 25/31] drm/i915/gem: Don't allow changing the VM on running contexts (v2)

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4162 bytes --]

Hi Jason,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm/drm-next v5.13-rc5 next-20210608]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jason-Ekstrand/drm-i915-gem-ioctl-clean-ups-v6/20210609-123926
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-randconfig-s022-20210608 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/bb392954307892ab2d4913f113e90c85cf25ef16
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jason-Ekstrand/drm-i915-gem-ioctl-clean-ups-v6/20210609-123926
        git checkout bb392954307892ab2d4913f113e90c85cf25ef16
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:746:13: sparse: sparse: incompatible types in comparison expression (different address spaces):
>> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:746:13: sparse:    struct i915_address_space [noderef] __rcu *
>> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:746:13: sparse:    struct i915_address_space *
   drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:772:49: sparse: sparse: incompatible types in comparison expression (different address spaces):
   drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:772:49: sparse:    struct i915_address_space [noderef] __rcu *
   drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:772:49: sparse:    struct i915_address_space *

vim +746 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c

2889caa9232109a drivers/gpu/drm/i915/i915_gem_execbuffer.c     Chris Wilson   2017-06-16  736  
2889caa9232109a drivers/gpu/drm/i915/i915_gem_execbuffer.c     Chris Wilson   2017-06-16  737  static int eb_select_context(struct i915_execbuffer *eb)
2889caa9232109a drivers/gpu/drm/i915/i915_gem_execbuffer.c     Chris Wilson   2017-06-16  738  {
2889caa9232109a drivers/gpu/drm/i915/i915_gem_execbuffer.c     Chris Wilson   2017-06-16  739  	struct i915_gem_context *ctx;
2889caa9232109a drivers/gpu/drm/i915/i915_gem_execbuffer.c     Chris Wilson   2017-06-16  740  
2889caa9232109a drivers/gpu/drm/i915/i915_gem_execbuffer.c     Chris Wilson   2017-06-16  741  	ctx = i915_gem_context_lookup(eb->file->driver_priv, eb->args->rsvd1);
cedda38c8d96263 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Jason Ekstrand 2021-06-08  742  	if (unlikely(IS_ERR(ctx)))
cedda38c8d96263 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Jason Ekstrand 2021-06-08  743  		return PTR_ERR(ctx);
2889caa9232109a drivers/gpu/drm/i915/i915_gem_execbuffer.c     Chris Wilson   2017-06-16  744  
8f2a1057d6ec217 drivers/gpu/drm/i915/i915_gem_execbuffer.c     Chris Wilson   2019-04-25  745  	eb->gem_context = ctx;
a4e7ccdac38ec83 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson   2019-10-04 @746  	if (rcu_access_pointer(ctx->vm))
4f2c7337af638bd drivers/gpu/drm/i915/i915_gem_execbuffer.c     Chris Wilson   2018-09-01  747  		eb->invalid_flags |= EXEC_OBJECT_NEEDS_GTT;
2889caa9232109a drivers/gpu/drm/i915/i915_gem_execbuffer.c     Chris Wilson   2017-06-16  748  
2889caa9232109a drivers/gpu/drm/i915/i915_gem_execbuffer.c     Chris Wilson   2017-06-16  749  	return 0;
2889caa9232109a drivers/gpu/drm/i915/i915_gem_execbuffer.c     Chris Wilson   2017-06-16  750  }
2889caa9232109a drivers/gpu/drm/i915/i915_gem_execbuffer.c     Chris Wilson   2017-06-16  751  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32823 bytes --]