* [PATCH 1/1] scsi: tcm_qla2xxx: remove unnecessary oom message
@ 2021-06-10 8:05 Zhen Lei
0 siblings, 0 replies; only message in thread
From: Zhen Lei @ 2021-06-10 8:05 UTC (permalink / raw)
To: Nilesh Javali, GR-QLogic-Storage-Upstream,
James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: Zhen Lei
Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message
Remove it can help us save a bit of memory.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
index 03de1bcf1461d77..d537a7bc27f08b0 100644
--- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
+++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
@@ -1035,10 +1035,8 @@ static struct se_portal_group *tcm_qla2xxx_make_tpg(struct se_wwn *wwn,
}
tpg = kzalloc(sizeof(struct tcm_qla2xxx_tpg), GFP_KERNEL);
- if (!tpg) {
- pr_err("Unable to allocate struct tcm_qla2xxx_tpg\n");
+ if (!tpg)
return ERR_PTR(-ENOMEM);
- }
tpg->lport = lport;
tpg->lport_tpgt = tpgt;
/*
@@ -1151,10 +1149,8 @@ static struct se_portal_group *tcm_qla2xxx_npiv_make_tpg(struct se_wwn *wwn,
return ERR_PTR(-EINVAL);
tpg = kzalloc(sizeof(struct tcm_qla2xxx_tpg), GFP_KERNEL);
- if (!tpg) {
- pr_err("Unable to allocate struct tcm_qla2xxx_tpg\n");
+ if (!tpg)
return ERR_PTR(-ENOMEM);
- }
tpg->lport = lport;
tpg->lport_tpgt = tpgt;
@@ -1653,10 +1649,8 @@ static struct se_wwn *tcm_qla2xxx_make_lport(
return ERR_PTR(-EINVAL);
lport = kzalloc(sizeof(struct tcm_qla2xxx_lport), GFP_KERNEL);
- if (!lport) {
- pr_err("Unable to allocate struct tcm_qla2xxx_lport\n");
+ if (!lport)
return ERR_PTR(-ENOMEM);
- }
lport->lport_wwpn = wwpn;
tcm_qla2xxx_format_wwn(&lport->lport_name[0], TCM_QLA2XXX_NAMELEN,
wwpn);
@@ -1779,10 +1773,8 @@ static struct se_wwn *tcm_qla2xxx_npiv_make_lport(
return ERR_PTR(-EINVAL);
lport = kzalloc(sizeof(struct tcm_qla2xxx_lport), GFP_KERNEL);
- if (!lport) {
- pr_err("Unable to allocate struct tcm_qla2xxx_lport for NPIV\n");
+ if (!lport)
return ERR_PTR(-ENOMEM);
- }
lport->lport_npiv_wwpn = npiv_wwpn;
lport->lport_npiv_wwnn = npiv_wwnn;
sprintf(lport->lport_naa_name, "naa.%016llx", (unsigned long long) npiv_wwpn);
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-10 8:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10 8:05 [PATCH 1/1] scsi: tcm_qla2xxx: remove unnecessary oom message Zhen Lei
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.