* [PATCH] iommu/vt-d: Fix linker error on 32-bit
@ 2021-06-10 8:31 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2021-06-10 8:31 UTC (permalink / raw)
To: Joerg Roedel, Lu Baolu, Will Deacon
Cc: David Woodhouse, iommu, linux-kernel, Joerg Roedel
From: Joerg Roedel <jroedel@suse.de>
A recent commit broke the build on 32-bit x86. The linker throws these
messages:
ld: drivers/iommu/intel/perf.o: in function `dmar_latency_snapshot':
perf.c:(.text+0x40c): undefined reference to `__udivdi3'
ld: perf.c:(.text+0x458): undefined reference to `__udivdi3'
The reason are the 64-bit divides in dmar_latency_snapshot(). Use the
div_u64() helper function for those.
Fixes: 55ee5e67a59a ("iommu/vt-d: Add common code for dmar latency performance monitors")
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
drivers/iommu/intel/perf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/intel/perf.c b/drivers/iommu/intel/perf.c
index faaa96dda437..73b7ec705552 100644
--- a/drivers/iommu/intel/perf.c
+++ b/drivers/iommu/intel/perf.c
@@ -141,14 +141,14 @@ int dmar_latency_snapshot(struct intel_iommu *iommu, char *str, size_t size)
if (val == UINT_MAX)
val = 0;
else
- val /= 1000;
+ val = div_u64(val, 1000);
break;
case COUNTS_MAX:
- val /= 1000;
+ val = div_u64(val, 1000);
break;
case COUNTS_SUM:
if (lstat[i].samples)
- val /= (lstat[i].samples * 1000);
+ val = div_u64(val, (lstat[i].samples * 1000));
else
val = 0;
break;
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] iommu/vt-d: Fix linker error on 32-bit
@ 2021-06-10 8:31 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2021-06-10 8:31 UTC (permalink / raw)
To: Joerg Roedel, Lu Baolu, Will Deacon
Cc: iommu, Joerg Roedel, David Woodhouse, linux-kernel
From: Joerg Roedel <jroedel@suse.de>
A recent commit broke the build on 32-bit x86. The linker throws these
messages:
ld: drivers/iommu/intel/perf.o: in function `dmar_latency_snapshot':
perf.c:(.text+0x40c): undefined reference to `__udivdi3'
ld: perf.c:(.text+0x458): undefined reference to `__udivdi3'
The reason are the 64-bit divides in dmar_latency_snapshot(). Use the
div_u64() helper function for those.
Fixes: 55ee5e67a59a ("iommu/vt-d: Add common code for dmar latency performance monitors")
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
drivers/iommu/intel/perf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/intel/perf.c b/drivers/iommu/intel/perf.c
index faaa96dda437..73b7ec705552 100644
--- a/drivers/iommu/intel/perf.c
+++ b/drivers/iommu/intel/perf.c
@@ -141,14 +141,14 @@ int dmar_latency_snapshot(struct intel_iommu *iommu, char *str, size_t size)
if (val == UINT_MAX)
val = 0;
else
- val /= 1000;
+ val = div_u64(val, 1000);
break;
case COUNTS_MAX:
- val /= 1000;
+ val = div_u64(val, 1000);
break;
case COUNTS_SUM:
if (lstat[i].samples)
- val /= (lstat[i].samples * 1000);
+ val = div_u64(val, (lstat[i].samples * 1000));
else
val = 0;
break;
--
2.31.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-10 8:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10 8:31 [PATCH] iommu/vt-d: Fix linker error on 32-bit Joerg Roedel
2021-06-10 8:31 ` Joerg Roedel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.