[PATCH] io_uring: drop redundant IO_MODE_OFFLOAD check

[PATCH] io_uring: drop redundant IO_MODE_OFFLOAD check

[Stefan Hajnoczi]

check_engine_ops() already returns an error if io_submit_mode is
IO_MODE_OFFLOAD and the engine is marked FIO_NO_OFFLOAD.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 engines/io_uring.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/engines/io_uring.c b/engines/io_uring.c
index b962e804..9c091e37 100644
--- a/engines/io_uring.c
+++ b/engines/io_uring.c
@@ -728,12 +728,6 @@ static int fio_ioring_init(struct thread_data *td)
 	struct ioring_data *ld;
 	struct thread_options *to = &td->o;
 
-	if (to->io_submit_mode == IO_MODE_OFFLOAD) {
-		log_err("fio: io_submit_mode=offload is not compatible (or "
-			"useful) with io_uring\n");
-		return 1;
-	}
-
 	/* sqthread submission requires registered files */
 	if (o->sqpoll_thread)
 		o->registerfiles = 1;
-- 
2.31.1

Re: [PATCH] io_uring: drop redundant IO_MODE_OFFLOAD check

[Jens Axboe]

On 6/10/21 9:55 AM, Stefan Hajnoczi wrote:
> check_engine_ops() already returns an error if io_submit_mode is
> IO_MODE_OFFLOAD and the engine is marked FIO_NO_OFFLOAD.

Applied, thanks.

-- 
Jens Axboe