From: Mathieu Poirier <mathieu.poirier@linaro.org> To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com> Cc: ohad@wizery.com, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>, kernel test robot <lkp@intel.com> Subject: Re: [PATCH] remoteproc: imx-rproc: Fix IMX_REMOTEPROC configuration Date: Thu, 10 Jun 2021 10:09:03 -0600 [thread overview] Message-ID: <20210610160903.GB34238@p14s> (raw) In-Reply-To: <20210610031530.26326-1-peng.fan@oss.nxp.com> On Thu, Jun 10, 2021 at 11:15:30AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > When CONFIG_IMX_REMOTEPROC is y and CONFIG_HAVE_ARM_SMCCC > is not set, compiling errors are encountered as follows: > > drivers/remoteproc/imx_rproc.o: in function `imx_rproc_stop': > imx_rproc.c:(.text+0x140): undefined reference to `__arm_smccc_smc' > drivers/remoteproc/imx_rproc.o: in function `imx_rproc_detect_mode': > imx_rproc.c:(.text+0x272): undefined reference to `__arm_smccc_smc' > drivers/remoteproc/imx_rproc.o: in function `imx_rproc_start': > imx_rproc.c:(.text+0x5e0): undefined reference to `__arm_smccc_smc' > > __arm_smccc_smc is defined when HAVE_ARM_SMCCC is y, so > add dependency on HAVE_ARM_SMCCC in IMX_REMOTEPROC configuration. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/remoteproc/Kconfig | 1 + > 1 file changed, 1 insertion(+) Next time please add: Fixes: 79806d32d5aa ("remoteproc: imx_rproc: support i.MX8MN/P") Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig > index e68fcedc999c..9a6eedc3994a 100644 > --- a/drivers/remoteproc/Kconfig > +++ b/drivers/remoteproc/Kconfig > @@ -26,6 +26,7 @@ config REMOTEPROC_CDEV > config IMX_REMOTEPROC > tristate "i.MX remoteproc support" > depends on ARCH_MXC > + depends on HAVE_ARM_SMCCC > select MAILBOX > help > Say y here to support iMX's remote processors via the remote > -- > 2.30.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org> To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com> Cc: ohad@wizery.com, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>, kernel test robot <lkp@intel.com> Subject: Re: [PATCH] remoteproc: imx-rproc: Fix IMX_REMOTEPROC configuration Date: Thu, 10 Jun 2021 10:09:03 -0600 [thread overview] Message-ID: <20210610160903.GB34238@p14s> (raw) In-Reply-To: <20210610031530.26326-1-peng.fan@oss.nxp.com> On Thu, Jun 10, 2021 at 11:15:30AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > When CONFIG_IMX_REMOTEPROC is y and CONFIG_HAVE_ARM_SMCCC > is not set, compiling errors are encountered as follows: > > drivers/remoteproc/imx_rproc.o: in function `imx_rproc_stop': > imx_rproc.c:(.text+0x140): undefined reference to `__arm_smccc_smc' > drivers/remoteproc/imx_rproc.o: in function `imx_rproc_detect_mode': > imx_rproc.c:(.text+0x272): undefined reference to `__arm_smccc_smc' > drivers/remoteproc/imx_rproc.o: in function `imx_rproc_start': > imx_rproc.c:(.text+0x5e0): undefined reference to `__arm_smccc_smc' > > __arm_smccc_smc is defined when HAVE_ARM_SMCCC is y, so > add dependency on HAVE_ARM_SMCCC in IMX_REMOTEPROC configuration. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/remoteproc/Kconfig | 1 + > 1 file changed, 1 insertion(+) Next time please add: Fixes: 79806d32d5aa ("remoteproc: imx_rproc: support i.MX8MN/P") Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig > index e68fcedc999c..9a6eedc3994a 100644 > --- a/drivers/remoteproc/Kconfig > +++ b/drivers/remoteproc/Kconfig > @@ -26,6 +26,7 @@ config REMOTEPROC_CDEV > config IMX_REMOTEPROC > tristate "i.MX remoteproc support" > depends on ARCH_MXC > + depends on HAVE_ARM_SMCCC > select MAILBOX > help > Say y here to support iMX's remote processors via the remote > -- > 2.30.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-10 16:09 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-10 3:15 [PATCH] remoteproc: imx-rproc: Fix IMX_REMOTEPROC configuration Peng Fan (OSS) 2021-06-10 3:15 ` Peng Fan (OSS) 2021-06-10 16:09 ` Mathieu Poirier [this message] 2021-06-10 16:09 ` Mathieu Poirier 2021-06-10 18:30 ` patchwork-bot+linux-remoteproc
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210610160903.GB34238@p14s \ --to=mathieu.poirier@linaro.org \ --cc=bjorn.andersson@linaro.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=lkp@intel.com \ --cc=o.rempel@pengutronix.de \ --cc=ohad@wizery.com \ --cc=peng.fan@nxp.com \ --cc=peng.fan@oss.nxp.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.