* [PATCH] rpmsg: Fix rpmsg_create_ept return when RPMSG config is not defined
@ 2021-06-04 16:05 Arnaud Pouliquen
2021-06-10 17:10 ` Mathieu Poirier
0 siblings, 1 reply; 2+ messages in thread
From: Arnaud Pouliquen @ 2021-06-04 16:05 UTC (permalink / raw)
To: Bjorn Andersson, Ohad Ben-Cohen, Mathieu Poirier
Cc: linux-remoteproc, linux-kernel, linux-stm32, arnaud.pouliquen
This is a minor fix.
According to the description of the rpmsg_create_ept in rpmsg_core.c
the function should return NULL on error.
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
---
include/linux/rpmsg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/rpmsg.h b/include/linux/rpmsg.h
index d97dcd049f18..a8dcf8a9ae88 100644
--- a/include/linux/rpmsg.h
+++ b/include/linux/rpmsg.h
@@ -231,7 +231,7 @@ static inline struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev
/* This shouldn't be possible */
WARN_ON(1);
- return ERR_PTR(-ENXIO);
+ return NULL;
}
static inline int rpmsg_send(struct rpmsg_endpoint *ept, void *data, int len)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rpmsg: Fix rpmsg_create_ept return when RPMSG config is not defined
2021-06-04 16:05 [PATCH] rpmsg: Fix rpmsg_create_ept return when RPMSG config is not defined Arnaud Pouliquen
@ 2021-06-10 17:10 ` Mathieu Poirier
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Poirier @ 2021-06-10 17:10 UTC (permalink / raw)
To: Arnaud Pouliquen
Cc: Bjorn Andersson, Ohad Ben-Cohen, linux-remoteproc, linux-kernel,
linux-stm32
On Fri, Jun 04, 2021 at 06:05:49PM +0200, Arnaud Pouliquen wrote:
> This is a minor fix.
>
> According to the description of the rpmsg_create_ept in rpmsg_core.c
> the function should return NULL on error.
>
You are correct, and none of the client return an error code either.
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
> ---
> include/linux/rpmsg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/rpmsg.h b/include/linux/rpmsg.h
> index d97dcd049f18..a8dcf8a9ae88 100644
> --- a/include/linux/rpmsg.h
> +++ b/include/linux/rpmsg.h
> @@ -231,7 +231,7 @@ static inline struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev
> /* This shouldn't be possible */
> WARN_ON(1);
>
> - return ERR_PTR(-ENXIO);
> + return NULL;
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> }
>
> static inline int rpmsg_send(struct rpmsg_endpoint *ept, void *data, int len)
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-10 17:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 16:05 [PATCH] rpmsg: Fix rpmsg_create_ept return when RPMSG config is not defined Arnaud Pouliquen
2021-06-10 17:10 ` Mathieu Poirier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.