All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hwmon: (ntc_thermistor) Drop unused headers.
@ 2021-06-11 14:22 Jonathan Cameron
  2021-06-12 12:26 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Cameron @ 2021-06-11 14:22 UTC (permalink / raw)
  To: linux-hwmon, linux-iio; +Cc: Jean Delvare, Jonathan Cameron, Guenter Roeck

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

The IIO usage in this driver is purely consumer so it should only
be including linux/iio/consumer.h  Whilst here drop pm_runtime.h
as there is no runtime power management in the driver.

Found using include-what-you-use and manual inspection of the
suggestions.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Guenter Roeck <linux@roeck-us.net>
---
 drivers/hwmon/ntc_thermistor.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
index 8587189c7f15..18fd6f12ca16 100644
--- a/drivers/hwmon/ntc_thermistor.c
+++ b/drivers/hwmon/ntc_thermistor.c
@@ -8,7 +8,6 @@
 
 #include <linux/slab.h>
 #include <linux/module.h>
-#include <linux/pm_runtime.h>
 #include <linux/math64.h>
 #include <linux/platform_device.h>
 #include <linux/err.h>
@@ -17,9 +16,6 @@
 
 #include <linux/platform_data/ntc_thermistor.h>
 
-#include <linux/iio/iio.h>
-#include <linux/iio/machine.h>
-#include <linux/iio/driver.h>
 #include <linux/iio/consumer.h>
 
 #include <linux/hwmon.h>
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] hwmon: (ntc_thermistor) Drop unused headers.
  2021-06-11 14:22 [PATCH] hwmon: (ntc_thermistor) Drop unused headers Jonathan Cameron
@ 2021-06-12 12:26 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-06-12 12:26 UTC (permalink / raw)
  To: Jonathan Cameron; +Cc: linux-hwmon, linux-iio, Jean Delvare, Jonathan Cameron

On Fri, Jun 11, 2021 at 03:22:57PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> The IIO usage in this driver is purely consumer so it should only
> be including linux/iio/consumer.h  Whilst here drop pm_runtime.h
> as there is no runtime power management in the driver.
> 
> Found using include-what-you-use and manual inspection of the
> suggestions.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Guenter Roeck <linux@roeck-us.net>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/ntc_thermistor.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
> index 8587189c7f15..18fd6f12ca16 100644
> --- a/drivers/hwmon/ntc_thermistor.c
> +++ b/drivers/hwmon/ntc_thermistor.c
> @@ -8,7 +8,6 @@
>  
>  #include <linux/slab.h>
>  #include <linux/module.h>
> -#include <linux/pm_runtime.h>
>  #include <linux/math64.h>
>  #include <linux/platform_device.h>
>  #include <linux/err.h>
> @@ -17,9 +16,6 @@
>  
>  #include <linux/platform_data/ntc_thermistor.h>
>  
> -#include <linux/iio/iio.h>
> -#include <linux/iio/machine.h>
> -#include <linux/iio/driver.h>
>  #include <linux/iio/consumer.h>
>  
>  #include <linux/hwmon.h>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-12 12:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-11 14:22 [PATCH] hwmon: (ntc_thermistor) Drop unused headers Jonathan Cameron
2021-06-12 12:26 ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.