drivers/mtd/nand/raw/nand_base.c:5065 of_get_nand_secure_regions() warn: assigning (-19) to unsigned variable 'chip->nr_secure_regions'

drivers/mtd/nand/raw/nand_base.c:5065 of_get_nand_secure_regions() warn: assigning (-19) to unsigned variable 'chip->nr_secure_regions'

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 4260 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
CC: Miquel Raynal <miquel.raynal@bootlin.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ad347abe4a9876b1f65f408ab467137e88f77eb4
commit: 13b89768275d6ca9764bf91449e4cafe46ba706b mtd: rawnand: Add support for secure regions in NAND memory
date:   9 weeks ago
:::::: branch date: 5 hours ago
:::::: commit date: 9 weeks ago
config: x86_64-randconfig-m001-20210611 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/mtd/nand/raw/nand_base.c:5065 of_get_nand_secure_regions() warn: assigning (-19) to unsigned variable 'chip->nr_secure_regions'

Old smatch warnings:
drivers/mtd/nand/raw/nand_base.c:883 nand_setup_interface() warn: missing error code 'ret'

vim +5065 drivers/mtd/nand/raw/nand_base.c

d48f62b9a0a035 drivers/mtd/nand/nand_base.c     Boris Brezillon       2016-04-01  5055  
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5056  static int of_get_nand_secure_regions(struct nand_chip *chip)
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5057  {
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5058  	struct device_node *dn = nand_get_flash_node(chip);
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5059  	int nr_elem, i, j;
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5060  
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5061  	nr_elem = of_property_count_elems_of_size(dn, "secure-regions", sizeof(u64));
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5062  	if (!nr_elem)
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5063  		return 0;
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5064  
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02 @5065  	chip->nr_secure_regions = nr_elem / 2;
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5066  	chip->secure_regions = kcalloc(chip->nr_secure_regions, sizeof(*chip->secure_regions),
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5067  				       GFP_KERNEL);
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5068  	if (!chip->secure_regions)
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5069  		return -ENOMEM;
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5070  
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5071  	for (i = 0, j = 0; i < chip->nr_secure_regions; i++, j += 2) {
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5072  		of_property_read_u64_index(dn, "secure-regions", j,
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5073  					   &chip->secure_regions[i].offset);
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5074  		of_property_read_u64_index(dn, "secure-regions", j + 1,
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5075  					   &chip->secure_regions[i].size);
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5076  	}
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5077  
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5078  	return 0;
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5079  }
13b89768275d6c drivers/mtd/nand/raw/nand_base.c Manivannan Sadhasivam 2021-04-02  5080  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36240 bytes --]