* Re: [PATCH v2] fuzz: Display hexadecimal value with '0x' prefix
2021-06-12 19:58 [PATCH v2] fuzz: Display hexadecimal value with '0x' prefix Philippe Mathieu-Daudé
@ 2021-06-12 20:36 ` Richard Henderson
2021-06-13 2:23 ` Alexander Bulekov
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2021-06-12 20:36 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Laurent Vivier, Thomas Huth, qemu-trivial, Alexander Bulekov,
Bandan Das, Stefan Hajnoczi, Paolo Bonzini
On 6/12/21 12:58 PM, Philippe Mathieu-Daudé wrote:
> Use memory_region_size() to get the MemoryRegion size,
> and display it with the '0x' prefix.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> v2:
> - Use PRIx64 (lvivier)
> - Use memory_region_size()
> ---
> tests/qtest/fuzz/generic_fuzz.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] fuzz: Display hexadecimal value with '0x' prefix
2021-06-12 19:58 [PATCH v2] fuzz: Display hexadecimal value with '0x' prefix Philippe Mathieu-Daudé
2021-06-12 20:36 ` Richard Henderson
@ 2021-06-13 2:23 ` Alexander Bulekov
2021-06-13 6:00 ` Thomas Huth
2021-06-13 12:47 ` Laurent Vivier
3 siblings, 0 replies; 5+ messages in thread
From: Alexander Bulekov @ 2021-06-13 2:23 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Laurent Vivier, Thomas Huth, qemu-trivial, qemu-devel,
Bandan Das, Stefan Hajnoczi, Paolo Bonzini
On 210612 2158, Philippe Mathieu-Daudé wrote:
> Use memory_region_size() to get the MemoryRegion size,
> and display it with the '0x' prefix.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2:
> - Use PRIx64 (lvivier)
> - Use memory_region_size()
> ---
> tests/qtest/fuzz/generic_fuzz.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Alexander Bulekov <alxndr@bu.edu>
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] fuzz: Display hexadecimal value with '0x' prefix
2021-06-12 19:58 [PATCH v2] fuzz: Display hexadecimal value with '0x' prefix Philippe Mathieu-Daudé
2021-06-12 20:36 ` Richard Henderson
2021-06-13 2:23 ` Alexander Bulekov
@ 2021-06-13 6:00 ` Thomas Huth
2021-06-13 12:47 ` Laurent Vivier
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2021-06-13 6:00 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Laurent Vivier, qemu-trivial, Alexander Bulekov, Bandan Das,
Stefan Hajnoczi, Paolo Bonzini
On 12/06/2021 21.58, Philippe Mathieu-Daudé wrote:
> Use memory_region_size() to get the MemoryRegion size,
> and display it with the '0x' prefix.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2:
> - Use PRIx64 (lvivier)
> - Use memory_region_size()
> ---
> tests/qtest/fuzz/generic_fuzz.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuzz.c
> index cea7d4058e8..6c675227174 100644
> --- a/tests/qtest/fuzz/generic_fuzz.c
> +++ b/tests/qtest/fuzz/generic_fuzz.c
> @@ -841,9 +841,9 @@ static void generic_pre_fuzz(QTestState *s)
>
> g_hash_table_iter_init(&iter, fuzzable_memoryregions);
> while (g_hash_table_iter_next(&iter, (gpointer)&mr, NULL)) {
> - printf(" * %s (size %lx)\n",
> + printf(" * %s (size 0x%" PRIx64 ")\n",
> object_get_canonical_path_component(&(mr->parent_obj)),
> - (uint64_t)mr->size);
> + memory_region_size(mr));
> }
>
> if (!g_hash_table_size(fuzzable_memoryregions)) {
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] fuzz: Display hexadecimal value with '0x' prefix
2021-06-12 19:58 [PATCH v2] fuzz: Display hexadecimal value with '0x' prefix Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2021-06-13 6:00 ` Thomas Huth
@ 2021-06-13 12:47 ` Laurent Vivier
3 siblings, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2021-06-13 12:47 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Laurent Vivier, Thomas Huth, qemu-trivial, Alexander Bulekov,
Bandan Das, Stefan Hajnoczi, Paolo Bonzini
Le 12/06/2021 à 21:58, Philippe Mathieu-Daudé a écrit :
> Use memory_region_size() to get the MemoryRegion size,
> and display it with the '0x' prefix.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2:
> - Use PRIx64 (lvivier)
> - Use memory_region_size()
> ---
> tests/qtest/fuzz/generic_fuzz.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuzz.c
> index cea7d4058e8..6c675227174 100644
> --- a/tests/qtest/fuzz/generic_fuzz.c
> +++ b/tests/qtest/fuzz/generic_fuzz.c
> @@ -841,9 +841,9 @@ static void generic_pre_fuzz(QTestState *s)
>
> g_hash_table_iter_init(&iter, fuzzable_memoryregions);
> while (g_hash_table_iter_next(&iter, (gpointer)&mr, NULL)) {
> - printf(" * %s (size %lx)\n",
> + printf(" * %s (size 0x%" PRIx64 ")\n",
> object_get_canonical_path_component(&(mr->parent_obj)),
> - (uint64_t)mr->size);
> + memory_region_size(mr));
> }
>
> if (!g_hash_table_size(fuzzable_memoryregions)) {
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 5+ messages in thread