* [Buildroot] [git commit] package/perl-crypt-openssl-rsa: add missing dependency to openssl
@ 2021-06-12 21:32 Yann E. MORIN
2021-06-20 16:22 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Yann E. MORIN @ 2021-06-12 21:32 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=7c636d9c6601538920f6e46955168f41b458a287
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
perl-crypt-openssl-rsa inherits the dependency on openssl indirectly
from perl-crypt-openssl-random. Hwvere, perl-crypt-openssl-rsa needs
the openssl libraries for itself, so it must explicitly depend on it.
So far, this was totally unconsequential, but since commit a83d41867c8d
(package/libopenssl: add option to enable some features), features can
be configured out, of which RMD160 that perl-crypt-openssl-rsa needs.
If we were to add the select to that option (in a followup commit),
without a dependency to openssl, that would be very confusing in the
future.
So, add the explicit dependency now.
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
package/perl-crypt-openssl-rsa/Config.in | 1 +
package/perl-crypt-openssl-rsa/perl-crypt-openssl-rsa.mk | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/perl-crypt-openssl-rsa/Config.in b/package/perl-crypt-openssl-rsa/Config.in
index e58a921bcb..e2c0131345 100644
--- a/package/perl-crypt-openssl-rsa/Config.in
+++ b/package/perl-crypt-openssl-rsa/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_PERL_CRYPT_OPENSSL_RSA
bool "perl-crypt-openssl-rsa"
depends on !BR2_STATIC_LIBS
+ select BR2_PACKAGE_OPENSSL
select BR2_PACKAGE_PERL_CRYPT_OPENSSL_RANDOM # runtime
help
RSA encoding and decoding, using the openSSL libraries.
diff --git a/package/perl-crypt-openssl-rsa/perl-crypt-openssl-rsa.mk b/package/perl-crypt-openssl-rsa/perl-crypt-openssl-rsa.mk
index b161523421..23fd1ac381 100644
--- a/package/perl-crypt-openssl-rsa/perl-crypt-openssl-rsa.mk
+++ b/package/perl-crypt-openssl-rsa/perl-crypt-openssl-rsa.mk
@@ -9,7 +9,8 @@ PERL_CRYPT_OPENSSL_RSA_SOURCE = Crypt-OpenSSL-RSA-$(PERL_CRYPT_OPENSSL_RSA_VERSI
PERL_CRYPT_OPENSSL_RSA_SITE = $(BR2_CPAN_MIRROR)/authors/id/T/TO/TODDR
PERL_CRYPT_OPENSSL_RSA_DEPENDENCIES = \
host-perl-crypt-openssl-guess \
- perl-crypt-openssl-random
+ perl-crypt-openssl-random \
+ openssl
PERL_CRYPT_OPENSSL_RSA_LICENSE = Artistic or GPL-1.0+
PERL_CRYPT_OPENSSL_RSA_LICENSE_FILES = LICENSE
PERL_CRYPT_OPENSSL_RSA_DISTNAME = Crypt-OpenSSL-RSA
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [git commit] package/perl-crypt-openssl-rsa: add missing dependency to openssl
2021-06-12 21:32 [Buildroot] [git commit] package/perl-crypt-openssl-rsa: add missing dependency to openssl Yann E. MORIN
@ 2021-06-20 16:22 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2021-06-20 16:22 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=7c636d9c6601538920f6e46955168f41b458a287
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> perl-crypt-openssl-rsa inherits the dependency on openssl indirectly
> from perl-crypt-openssl-random. Hwvere, perl-crypt-openssl-rsa needs
> the openssl libraries for itself, so it must explicitly depend on it.
> So far, this was totally unconsequential, but since commit a83d41867c8d
> (package/libopenssl: add option to enable some features), features can
> be configured out, of which RMD160 that perl-crypt-openssl-rsa needs.
> If we were to add the select to that option (in a followup commit),
> without a dependency to openssl, that would be very confusing in the
> future.
> So, add the explicit dependency now.
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Committed to 2021.02.x and 2021.05.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-20 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-12 21:32 [Buildroot] [git commit] package/perl-crypt-openssl-rsa: add missing dependency to openssl Yann E. MORIN
2021-06-20 16:22 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.