From: Zhihao Cheng <chengzhihao1@huawei.com> To: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com> Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <chengzhihao1@huawei.com>, <yukuai3@huawei.com> Subject: [PATCH 2/6] Revert "mtd: fix: avoid race condition when accessing mtd->usecount" Date: Sun, 13 Jun 2021 19:30:31 +0800 [thread overview] Message-ID: <20210613113035.2329421-3-chengzhihao1@huawei.com> (raw) In-Reply-To: <20210613113035.2329421-1-chengzhihao1@huawei.com> This reverts commit 073db4a51ee43ccb827f54a4261c0583b028d5ab. --- drivers/mtd/mtd_blkdevs.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 16ccce3e7fdb..00b13f71ccf3 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -210,7 +210,6 @@ static int blktrans_open(struct block_device *bdev, fmode_t mode) return -ERESTARTSYS; /* FIXME: busy loop! -arnd*/ mutex_lock(&dev->lock); - mutex_lock(&mtd_table_mutex); if (dev->open) goto unlock; @@ -234,7 +233,6 @@ static int blktrans_open(struct block_device *bdev, fmode_t mode) unlock: dev->open++; - mutex_unlock(&mtd_table_mutex); mutex_unlock(&dev->lock); blktrans_dev_put(dev); return ret; @@ -245,7 +243,6 @@ static int blktrans_open(struct block_device *bdev, fmode_t mode) error_put: module_put(dev->tr->owner); kref_put(&dev->ref, blktrans_dev_release); - mutex_unlock(&mtd_table_mutex); mutex_unlock(&dev->lock); blktrans_dev_put(dev); return ret; @@ -259,7 +256,6 @@ static void blktrans_release(struct gendisk *disk, fmode_t mode) return; mutex_lock(&dev->lock); - mutex_lock(&mtd_table_mutex); if (--dev->open) goto unlock; @@ -273,7 +269,6 @@ static void blktrans_release(struct gendisk *disk, fmode_t mode) __put_mtd_device(dev->mtd); } unlock: - mutex_unlock(&mtd_table_mutex); mutex_unlock(&dev->lock); blktrans_dev_put(dev); } -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Zhihao Cheng <chengzhihao1@huawei.com> To: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com> Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <chengzhihao1@huawei.com>, <yukuai3@huawei.com> Subject: [PATCH 2/6] Revert "mtd: fix: avoid race condition when accessing mtd->usecount" Date: Sun, 13 Jun 2021 19:30:31 +0800 [thread overview] Message-ID: <20210613113035.2329421-3-chengzhihao1@huawei.com> (raw) In-Reply-To: <20210613113035.2329421-1-chengzhihao1@huawei.com> This reverts commit 073db4a51ee43ccb827f54a4261c0583b028d5ab. --- drivers/mtd/mtd_blkdevs.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 16ccce3e7fdb..00b13f71ccf3 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -210,7 +210,6 @@ static int blktrans_open(struct block_device *bdev, fmode_t mode) return -ERESTARTSYS; /* FIXME: busy loop! -arnd*/ mutex_lock(&dev->lock); - mutex_lock(&mtd_table_mutex); if (dev->open) goto unlock; @@ -234,7 +233,6 @@ static int blktrans_open(struct block_device *bdev, fmode_t mode) unlock: dev->open++; - mutex_unlock(&mtd_table_mutex); mutex_unlock(&dev->lock); blktrans_dev_put(dev); return ret; @@ -245,7 +243,6 @@ static int blktrans_open(struct block_device *bdev, fmode_t mode) error_put: module_put(dev->tr->owner); kref_put(&dev->ref, blktrans_dev_release); - mutex_unlock(&mtd_table_mutex); mutex_unlock(&dev->lock); blktrans_dev_put(dev); return ret; @@ -259,7 +256,6 @@ static void blktrans_release(struct gendisk *disk, fmode_t mode) return; mutex_lock(&dev->lock); - mutex_lock(&mtd_table_mutex); if (--dev->open) goto unlock; @@ -273,7 +269,6 @@ static void blktrans_release(struct gendisk *disk, fmode_t mode) __put_mtd_device(dev->mtd); } unlock: - mutex_unlock(&mtd_table_mutex); mutex_unlock(&dev->lock); blktrans_dev_put(dev); } -- 2.31.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-06-13 11:22 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-13 11:30 [PATCH 0/6] Fix deadlock in ftl formating on mtd Zhihao Cheng 2021-06-13 11:30 ` Zhihao Cheng 2021-06-13 11:30 ` [PATCH 1/6] Revert "mtd: blkdevs: fix potential deadlock + lockdep warnings" Zhihao Cheng 2021-06-13 11:30 ` Zhihao Cheng 2021-06-13 11:30 ` Zhihao Cheng [this message] 2021-06-13 11:30 ` [PATCH 2/6] Revert "mtd: fix: avoid race condition when accessing mtd->usecount" Zhihao Cheng 2021-06-13 11:30 ` [PATCH 3/6] Revert "mtd: mtd_blkdevs: don't increase 'open' count on error path" Zhihao Cheng 2021-06-13 11:30 ` Zhihao Cheng 2021-06-13 11:30 ` [PATCH 4/6] Revert "mtd: mtd_blkdevs: fix error path in blktrans_open" Zhihao Cheng 2021-06-13 11:30 ` Zhihao Cheng 2021-06-13 11:30 ` [PATCH 5/6] Revert "mtd: Remove redundant mutex from mtd_blkdevs.c" Zhihao Cheng 2021-06-13 11:30 ` Zhihao Cheng 2021-06-13 11:30 ` [PATCH 6/6] Revert "mtd: allow to unload the mtdtrans module if its block devices aren't open" Zhihao Cheng 2021-06-13 11:30 ` Zhihao Cheng 2021-06-13 15:12 ` [PATCH 0/6] Fix deadlock in ftl formating on mtd Miquel Raynal 2021-06-13 15:12 ` Miquel Raynal 2021-06-15 9:02 ` Zhihao Cheng 2021-06-15 9:02 ` Zhihao Cheng 2021-06-15 9:08 ` Zhihao Cheng 2021-06-15 9:08 ` Zhihao Cheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210613113035.2329421-3-chengzhihao1@huawei.com \ --to=chengzhihao1@huawei.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ --cc=yukuai3@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.