All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] leds: lgm: Fix up includes
@ 2021-06-13 23:16 Linus Walleij
  2021-06-23 21:24 ` Pavel Machek
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2021-06-13 23:16 UTC (permalink / raw)
  To: Pavel Machek; +Cc: linux-leds, Linus Walleij, Amireddy Mallikarjuna reddy

This driver is including the legacy GPIO header <linux/gpio.h>
but the only thing it is using from that header is the wrong
define for GPIOF_DIR_OUT.

Fix it up by using GPIO_LINE_DIRECTION_OUT and including the
correct consumer and driver headers.

Cc: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/leds/blink/leds-lgm-sso.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/blink/leds-lgm-sso.c b/drivers/leds/blink/leds-lgm-sso.c
index 6a63846d10b5..4c70f7d022ac 100644
--- a/drivers/leds/blink/leds-lgm-sso.c
+++ b/drivers/leds/blink/leds-lgm-sso.c
@@ -7,7 +7,8 @@
 
 #include <linux/bitfield.h>
 #include <linux/clk.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
+#include <linux/gpio/driver.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
 #include <linux/leds.h>
@@ -423,7 +424,7 @@ static void sso_gpio_free(struct gpio_chip *chip, unsigned int offset)
 
 static int sso_gpio_get_dir(struct gpio_chip *chip, unsigned int offset)
 {
-	return GPIOF_DIR_OUT;
+	return GPIO_LINE_DIRECTION_OUT;
 }
 
 static int
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] leds: lgm: Fix up includes
  2021-06-13 23:16 [PATCH] leds: lgm: Fix up includes Linus Walleij
@ 2021-06-23 21:24 ` Pavel Machek
  0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2021-06-23 21:24 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-leds, Amireddy Mallikarjuna reddy

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

On Mon 2021-06-14 01:16:47, Linus Walleij wrote:
> This driver is including the legacy GPIO header <linux/gpio.h>
> but the only thing it is using from that header is the wrong
> define for GPIOF_DIR_OUT.
> 
> Fix it up by using GPIO_LINE_DIRECTION_OUT and including the
> correct consumer and driver headers.
> 
> Cc: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Thanks, applied.
							Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-23 21:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-13 23:16 [PATCH] leds: lgm: Fix up includes Linus Walleij
2021-06-23 21:24 ` Pavel Machek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.