All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dasd: unexport dasd_set_target_state
@ 2021-06-14  6:04 Christoph Hellwig
  2021-06-17 12:40 ` Stefan Haberland
  0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2021-06-14  6:04 UTC (permalink / raw)
  To: sth, hoeppner; +Cc: linux-s390

dasd_set_target_state is only used inside of dasd_mod.ko, so don't
export it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/s390/block/dasd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
index c8df75e99f4c..e34c6cc61983 100644
--- a/drivers/s390/block/dasd.c
+++ b/drivers/s390/block/dasd.c
@@ -621,7 +621,6 @@ void dasd_set_target_state(struct dasd_device *device, int target)
 	mutex_unlock(&device->state_mutex);
 	dasd_put_device(device);
 }
-EXPORT_SYMBOL(dasd_set_target_state);
 
 /*
  * Enable devices with device numbers in [from..to].
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dasd: unexport dasd_set_target_state
  2021-06-14  6:04 [PATCH] dasd: unexport dasd_set_target_state Christoph Hellwig
@ 2021-06-17 12:40 ` Stefan Haberland
  2021-06-21  7:27   ` Christoph Hellwig
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Haberland @ 2021-06-17 12:40 UTC (permalink / raw)
  To: Christoph Hellwig, hoeppner; +Cc: linux-s390

Am 14.06.21 um 08:04 schrieb Christoph Hellwig:
> dasd_set_target_state is only used inside of dasd_mod.ko, so don't
> export it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---

Acked-by: Stefan Haberland <sth@linux.ibm.com>

Thanks,
Stefan


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dasd: unexport dasd_set_target_state
  2021-06-17 12:40 ` Stefan Haberland
@ 2021-06-21  7:27   ` Christoph Hellwig
  2021-06-21  7:37     ` Stefan Haberland
  0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2021-06-21  7:27 UTC (permalink / raw)
  To: Stefan Haberland; +Cc: Christoph Hellwig, hoeppner, linux-s390

On Thu, Jun 17, 2021 at 02:40:06PM +0200, Stefan Haberland wrote:
> Am 14.06.21 um 08:04 schrieb Christoph Hellwig:
> > dasd_set_target_state is only used inside of dasd_mod.ko, so don't
> > export it.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> 
> Acked-by: Stefan Haberland <sth@linux.ibm.com>

Can you pick this up through the s390 tree?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dasd: unexport dasd_set_target_state
  2021-06-21  7:27   ` Christoph Hellwig
@ 2021-06-21  7:37     ` Stefan Haberland
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Haberland @ 2021-06-21  7:37 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: hoeppner, linux-s390

Am 21.06.21 um 09:27 schrieb Christoph Hellwig:
> On Thu, Jun 17, 2021 at 02:40:06PM +0200, Stefan Haberland wrote:
>> Am 14.06.21 um 08:04 schrieb Christoph Hellwig:
>>> dasd_set_target_state is only used inside of dasd_mod.ko, so don't
>>> export it.
>>>
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>> ---
>> Acked-by: Stefan Haberland <sth@linux.ibm.com>
> Can you pick this up through the s390 tree?

Sure.
But FYI: I will send it to Jens since we bring DASD patches upstream
through the block tree.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-21  7:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-14  6:04 [PATCH] dasd: unexport dasd_set_target_state Christoph Hellwig
2021-06-17 12:40 ` Stefan Haberland
2021-06-21  7:27   ` Christoph Hellwig
2021-06-21  7:37     ` Stefan Haberland

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.