* [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test
@ 2021-06-14 15:35 Anson Jacob
2021-06-14 15:35 ` [igt-dev] [PATCH i-g-t 2/2] tests/amdgpu: Fix typo in amd_module_load Anson Jacob
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Anson Jacob @ 2021-06-14 15:35 UTC (permalink / raw)
To: igt-dev, Harry.Wentland, Rodrigo.Siqueira, markyacoub
Cc: Anson Jacob, Victor Lu
From: Victor Lu <victorchengchi.lu@amd.com>
Based off of i915/i915_module_load, unloads and loads the
amdgpu module.
Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
Acked-by: Anson Jacob <Anson.Jacob@amd.com>
---
lib/igt_kmod.c | 41 ++++++++++++++++++
lib/igt_kmod.h | 3 ++
tests/amdgpu/amd_module_load.c | 77 ++++++++++++++++++++++++++++++++++
tests/amdgpu/meson.build | 1 +
4 files changed, 122 insertions(+)
create mode 100644 tests/amdgpu/amd_module_load.c
diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index 55295fa5..69bdc810 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -433,6 +433,47 @@ igt_i915_driver_unload(void)
return IGT_EXIT_SUCCESS;
}
+int
+igt_amdgpu_driver_load(const char *opts)
+{
+ if (opts)
+ igt_info("Reloading amdgpu with %s\n\n", opts);
+
+ if (igt_kmod_load("amdgpu", opts)) {
+ igt_warn("Could not load amdgpu\n");
+ return IGT_EXIT_FAILURE;
+ }
+
+ bind_fbcon(true);
+
+ return IGT_EXIT_SUCCESS;
+}
+
+int
+igt_amdgpu_driver_unload(void)
+{
+ bind_fbcon(false);
+
+ if (igt_kmod_is_loaded("amdgpu")) {
+ if (igt_kmod_unload("amdgpu", 0)) {
+ igt_warn("Could not unload amdgpu\n");
+ igt_kmod_list_loaded();
+ igt_lsof("/dev/dri");
+ return IGT_EXIT_SKIP;
+ }
+ }
+
+ igt_kmod_unload("drm_kms_helper", 0);
+ igt_kmod_unload("drm", 0);
+
+ if (igt_kmod_is_loaded("amdgpu")) {
+ igt_warn("amdgpu.ko still loaded!\n");
+ return IGT_EXIT_FAILURE;
+ }
+
+ return IGT_EXIT_SUCCESS;
+}
+
static void kmsg_dump(int fd)
{
char record[4096 + 1];
diff --git a/lib/igt_kmod.h b/lib/igt_kmod.h
index c71ec147..04c87516 100644
--- a/lib/igt_kmod.h
+++ b/lib/igt_kmod.h
@@ -39,6 +39,9 @@ int igt_kmod_unload(const char *mod_name, unsigned int flags);
int igt_i915_driver_load(const char *opts);
int igt_i915_driver_unload(void);
+int igt_amdgpu_driver_load(const char *opts);
+int igt_amdgpu_driver_unload(void);
+
void igt_kselftests(const char *module_name,
const char *module_options,
const char *result_option,
diff --git a/tests/amdgpu/amd_module_load.c b/tests/amdgpu/amd_module_load.c
new file mode 100644
index 00000000..e682d2c5
--- /dev/null
+++ b/tests/amdgpu/amd_module_load.c
@@ -0,0 +1,77 @@
+/*
+ * Copyright 2020 Advanced Micro Devices, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ *
+ */
+
+#include "igt.h"
+#include "igt_kmod.h"
+
+#include <amdgpu.h>
+#include <amdgpu_drm.h>
+#include <sys/ioctl.h>
+
+/**
+ * Adapted from /tests/i915/i915_module_load.c
+ */
+static void
+sanity_check(void)
+{
+ int err = 0;
+ int fd;
+ int arg_ret;
+ struct drm_amdgpu_info args = {0};
+ args.return_pointer = (uintptr_t) &arg_ret;
+ args.return_size = sizeof(int);
+ args.query = AMDGPU_INFO_HW_IP_INFO;
+
+ fd = drm_open_driver(DRIVER_AMDGPU);
+ igt_set_timeout(1, "Module reload timeout!");
+
+ if (ioctl(fd, DRM_IOCTL_AMDGPU_INFO, &args) < 0)
+ err = -errno;
+
+ igt_set_timeout(0, NULL);
+ close(fd);
+
+ igt_assert_f(err, 0);
+}
+
+igt_main
+{
+ igt_subtest("reload") {
+ int err;
+ igt_amdgpu_driver_unload();
+
+ err = igt_amdgpu_driver_load(NULL);
+
+ igt_assert_eq(err, 0);
+
+ sanity_check();
+
+ igt_amdgpu_driver_unload();
+ }
+
+ igt_fixture
+ {
+ /* load the module back in */
+ igt_amdgpu_driver_load(NULL);
+ }
+}
diff --git a/tests/amdgpu/meson.build b/tests/amdgpu/meson.build
index b92aa22b..84179410 100644
--- a/tests/amdgpu/meson.build
+++ b/tests/amdgpu/meson.build
@@ -9,6 +9,7 @@ if libdrm_amdgpu.found()
'amd_cs_nop',
'amd_info',
'amd_prime',
+ 'amd_module_load',
]
amdgpu_deps += libdrm_amdgpu
endif
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] tests/amdgpu: Fix typo in amd_module_load
2021-06-14 15:35 [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test Anson Jacob
@ 2021-06-14 15:35 ` Anson Jacob
2021-06-14 19:39 ` Rodrigo Siqueira
` (2 more replies)
2021-06-14 15:55 ` [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test Mark Yacoub
` (4 subsequent siblings)
5 siblings, 3 replies; 11+ messages in thread
From: Anson Jacob @ 2021-06-14 15:35 UTC (permalink / raw)
To: igt-dev, Harry.Wentland, Rodrigo.Siqueira, markyacoub
Cc: Anson Jacob, Victor Lu
From: Victor Lu <victorchengchi.lu@amd.com>
A typo in amd_module_load was causing the test to fail.
igt_assert_f(err, 0) should have been igt_assert_eq(err, 0),
to check err == 0. Also added drm_fd >= 0 check and made
ioctl query more explicit.
Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
Acked-by: Anson Jacob <Anson.Jacob@amd.com>
---
tests/amdgpu/amd_module_load.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/amdgpu/amd_module_load.c b/tests/amdgpu/amd_module_load.c
index e682d2c5..8762b2a2 100644
--- a/tests/amdgpu/amd_module_load.c
+++ b/tests/amdgpu/amd_module_load.c
@@ -41,8 +41,10 @@ sanity_check(void)
args.return_pointer = (uintptr_t) &arg_ret;
args.return_size = sizeof(int);
args.query = AMDGPU_INFO_HW_IP_INFO;
+ args.query_hw_ip.type = AMDGPU_HW_IP_COMPUTE;
fd = drm_open_driver(DRIVER_AMDGPU);
+ igt_assert_f(fd >= 0, "Module failed to load\n");
igt_set_timeout(1, "Module reload timeout!");
if (ioctl(fd, DRM_IOCTL_AMDGPU_INFO, &args) < 0)
@@ -51,7 +53,7 @@ sanity_check(void)
igt_set_timeout(0, NULL);
close(fd);
- igt_assert_f(err, 0);
+ igt_assert_eq(err, 0);
}
igt_main
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test
2021-06-14 15:35 [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test Anson Jacob
2021-06-14 15:35 ` [igt-dev] [PATCH i-g-t 2/2] tests/amdgpu: Fix typo in amd_module_load Anson Jacob
@ 2021-06-14 15:55 ` Mark Yacoub
2021-06-14 16:30 ` Jacob, Anson
2021-06-14 16:39 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
` (3 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Mark Yacoub @ 2021-06-14 15:55 UTC (permalink / raw)
To: Anson Jacob; +Cc: igt-dev, Victor Lu, Mark Yacoub
On Mon, Jun 14, 2021 at 11:36 AM Anson Jacob <Anson.Jacob@amd.com> wrote:
>
> From: Victor Lu <victorchengchi.lu@amd.com>
>
> Based off of i915/i915_module_load, unloads and loads the
> amdgpu module.
>
> Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
> Acked-by: Anson Jacob <Anson.Jacob@amd.com>
> ---
> lib/igt_kmod.c | 41 ++++++++++++++++++
> lib/igt_kmod.h | 3 ++
> tests/amdgpu/amd_module_load.c | 77 ++++++++++++++++++++++++++++++++++
> tests/amdgpu/meson.build | 1 +
> 4 files changed, 122 insertions(+)
> create mode 100644 tests/amdgpu/amd_module_load.c
>
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index 55295fa5..69bdc810 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -433,6 +433,47 @@ igt_i915_driver_unload(void)
> return IGT_EXIT_SUCCESS;
> }
>
> +int
> +igt_amdgpu_driver_load(const char *opts)
> +{
> + if (opts)
> + igt_info("Reloading amdgpu with %s\n\n", opts);
> +
> + if (igt_kmod_load("amdgpu", opts)) {
> + igt_warn("Could not load amdgpu\n");
> + return IGT_EXIT_FAILURE;
> + }
> +
> + bind_fbcon(true);
> +
> + return IGT_EXIT_SUCCESS;
> +}
> +
> +int
> +igt_amdgpu_driver_unload(void)
> +{
> + bind_fbcon(false);
> +
> + if (igt_kmod_is_loaded("amdgpu")) {
> + if (igt_kmod_unload("amdgpu", 0)) {
> + igt_warn("Could not unload amdgpu\n");
> + igt_kmod_list_loaded();
> + igt_lsof("/dev/dri");
> + return IGT_EXIT_SKIP;
> + }
> + }
> +
> + igt_kmod_unload("drm_kms_helper", 0);
> + igt_kmod_unload("drm", 0);
> +
> + if (igt_kmod_is_loaded("amdgpu")) {
> + igt_warn("amdgpu.ko still loaded!\n");
> + return IGT_EXIT_FAILURE;
> + }
> +
> + return IGT_EXIT_SUCCESS;
> +}
> +
> static void kmsg_dump(int fd)
> {
> char record[4096 + 1];
> diff --git a/lib/igt_kmod.h b/lib/igt_kmod.h
> index c71ec147..04c87516 100644
> --- a/lib/igt_kmod.h
> +++ b/lib/igt_kmod.h
> @@ -39,6 +39,9 @@ int igt_kmod_unload(const char *mod_name, unsigned int flags);
> int igt_i915_driver_load(const char *opts);
> int igt_i915_driver_unload(void);
>
> +int igt_amdgpu_driver_load(const char *opts);
> +int igt_amdgpu_driver_unload(void);
> +
> void igt_kselftests(const char *module_name,
> const char *module_options,
> const char *result_option,
> diff --git a/tests/amdgpu/amd_module_load.c b/tests/amdgpu/amd_module_load.c
> new file mode 100644
> index 00000000..e682d2c5
> --- /dev/null
> +++ b/tests/amdgpu/amd_module_load.c
> @@ -0,0 +1,77 @@
> +/*
> + * Copyright 2020 Advanced Micro Devices, Inc.
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
> + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + *
> + */
> +
> +#include "igt.h"
> +#include "igt_kmod.h"
> +
> +#include <amdgpu.h>
> +#include <amdgpu_drm.h>
> +#include <sys/ioctl.h>
> +
> +/**
> + * Adapted from /tests/i915/i915_module_load.c
> + */
> +static void
> +sanity_check(void)
> +{
> + int err = 0;
> + int fd;
> + int arg_ret;
> + struct drm_amdgpu_info args = {0};
> + args.return_pointer = (uintptr_t) &arg_ret;
> + args.return_size = sizeof(int);
> + args.query = AMDGPU_INFO_HW_IP_INFO;
> +
> + fd = drm_open_driver(DRIVER_AMDGPU);
> + igt_set_timeout(1, "Module reload timeout!");
> +
> + if (ioctl(fd, DRM_IOCTL_AMDGPU_INFO, &args) < 0)
> + err = -errno;
> +
> + igt_set_timeout(0, NULL);
> + close(fd);
> +
> + igt_assert_f(err, 0);
> +}
> +
> +igt_main
> +{
> + igt_subtest("reload") {
I see the i915 equivalent test having 2 more subtests, are those gonna
be added in a follow up?
> + int err;
> + igt_amdgpu_driver_unload();
> +
> + err = igt_amdgpu_driver_load(NULL);
> +
> + igt_assert_eq(err, 0);
> +
> + sanity_check();
> +
> + igt_amdgpu_driver_unload();
> + }
> +
> + igt_fixture
> + {
> + /* load the module back in */
> + igt_amdgpu_driver_load(NULL);
> + }
> +}
> diff --git a/tests/amdgpu/meson.build b/tests/amdgpu/meson.build
> index b92aa22b..84179410 100644
> --- a/tests/amdgpu/meson.build
> +++ b/tests/amdgpu/meson.build
> @@ -9,6 +9,7 @@ if libdrm_amdgpu.found()
> 'amd_cs_nop',
> 'amd_info',
> 'amd_prime',
> + 'amd_module_load',
> ]
> amdgpu_deps += libdrm_amdgpu
> endif
> --
> 2.25.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test
2021-06-14 15:55 ` [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test Mark Yacoub
@ 2021-06-14 16:30 ` Jacob, Anson
0 siblings, 0 replies; 11+ messages in thread
From: Jacob, Anson @ 2021-06-14 16:30 UTC (permalink / raw)
To: Mark Yacoub; +Cc: igt-dev, Lu, Victor Cheng Chi (Victor), Mark Yacoub
[-- Attachment #1.1: Type: text/plain, Size: 7210 bytes --]
[AMD Official Use Only]
> I see the i915 equivalent test having 2 more subtests, are those gonna
> be added in a follow up?
No. We do not have those tests yet.
-- Anson
________________________________
From: Mark Yacoub <markyacoub@chromium.org>
Sent: Monday, June 14, 2021 11:55 AM
To: Jacob, Anson <Anson.Jacob@amd.com>
Cc: igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org>; Wentland, Harry <Harry.Wentland@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Mark Yacoub <markyacoub@google.com>; Lu, Victor Cheng Chi (Victor) <VictorChengChi.Lu@amd.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test
On Mon, Jun 14, 2021 at 11:36 AM Anson Jacob <Anson.Jacob@amd.com> wrote:
>
> From: Victor Lu <victorchengchi.lu@amd.com>
>
> Based off of i915/i915_module_load, unloads and loads the
> amdgpu module.
>
> Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
> Acked-by: Anson Jacob <Anson.Jacob@amd.com>
> ---
> lib/igt_kmod.c | 41 ++++++++++++++++++
> lib/igt_kmod.h | 3 ++
> tests/amdgpu/amd_module_load.c | 77 ++++++++++++++++++++++++++++++++++
> tests/amdgpu/meson.build | 1 +
> 4 files changed, 122 insertions(+)
> create mode 100644 tests/amdgpu/amd_module_load.c
>
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index 55295fa5..69bdc810 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -433,6 +433,47 @@ igt_i915_driver_unload(void)
> return IGT_EXIT_SUCCESS;
> }
>
> +int
> +igt_amdgpu_driver_load(const char *opts)
> +{
> + if (opts)
> + igt_info("Reloading amdgpu with %s\n\n", opts);
> +
> + if (igt_kmod_load("amdgpu", opts)) {
> + igt_warn("Could not load amdgpu\n");
> + return IGT_EXIT_FAILURE;
> + }
> +
> + bind_fbcon(true);
> +
> + return IGT_EXIT_SUCCESS;
> +}
> +
> +int
> +igt_amdgpu_driver_unload(void)
> +{
> + bind_fbcon(false);
> +
> + if (igt_kmod_is_loaded("amdgpu")) {
> + if (igt_kmod_unload("amdgpu", 0)) {
> + igt_warn("Could not unload amdgpu\n");
> + igt_kmod_list_loaded();
> + igt_lsof("/dev/dri");
> + return IGT_EXIT_SKIP;
> + }
> + }
> +
> + igt_kmod_unload("drm_kms_helper", 0);
> + igt_kmod_unload("drm", 0);
> +
> + if (igt_kmod_is_loaded("amdgpu")) {
> + igt_warn("amdgpu.ko still loaded!\n");
> + return IGT_EXIT_FAILURE;
> + }
> +
> + return IGT_EXIT_SUCCESS;
> +}
> +
> static void kmsg_dump(int fd)
> {
> char record[4096 + 1];
> diff --git a/lib/igt_kmod.h b/lib/igt_kmod.h
> index c71ec147..04c87516 100644
> --- a/lib/igt_kmod.h
> +++ b/lib/igt_kmod.h
> @@ -39,6 +39,9 @@ int igt_kmod_unload(const char *mod_name, unsigned int flags);
> int igt_i915_driver_load(const char *opts);
> int igt_i915_driver_unload(void);
>
> +int igt_amdgpu_driver_load(const char *opts);
> +int igt_amdgpu_driver_unload(void);
> +
> void igt_kselftests(const char *module_name,
> const char *module_options,
> const char *result_option,
> diff --git a/tests/amdgpu/amd_module_load.c b/tests/amdgpu/amd_module_load.c
> new file mode 100644
> index 00000000..e682d2c5
> --- /dev/null
> +++ b/tests/amdgpu/amd_module_load.c
> @@ -0,0 +1,77 @@
> +/*
> + * Copyright 2020 Advanced Micro Devices, Inc.
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
> + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + *
> + */
> +
> +#include "igt.h"
> +#include "igt_kmod.h"
> +
> +#include <amdgpu.h>
> +#include <amdgpu_drm.h>
> +#include <sys/ioctl.h>
> +
> +/**
> + * Adapted from /tests/i915/i915_module_load.c
> + */
> +static void
> +sanity_check(void)
> +{
> + int err = 0;
> + int fd;
> + int arg_ret;
> + struct drm_amdgpu_info args = {0};
> + args.return_pointer = (uintptr_t) &arg_ret;
> + args.return_size = sizeof(int);
> + args.query = AMDGPU_INFO_HW_IP_INFO;
> +
> + fd = drm_open_driver(DRIVER_AMDGPU);
> + igt_set_timeout(1, "Module reload timeout!");
> +
> + if (ioctl(fd, DRM_IOCTL_AMDGPU_INFO, &args) < 0)
> + err = -errno;
> +
> + igt_set_timeout(0, NULL);
> + close(fd);
> +
> + igt_assert_f(err, 0);
> +}
> +
> +igt_main
> +{
> + igt_subtest("reload") {
I see the i915 equivalent test having 2 more subtests, are those gonna
be added in a follow up?
> + int err;
> + igt_amdgpu_driver_unload();
> +
> + err = igt_amdgpu_driver_load(NULL);
> +
> + igt_assert_eq(err, 0);
> +
> + sanity_check();
> +
> + igt_amdgpu_driver_unload();
> + }
> +
> + igt_fixture
> + {
> + /* load the module back in */
> + igt_amdgpu_driver_load(NULL);
> + }
> +}
> diff --git a/tests/amdgpu/meson.build b/tests/amdgpu/meson.build
> index b92aa22b..84179410 100644
> --- a/tests/amdgpu/meson.build
> +++ b/tests/amdgpu/meson.build
> @@ -9,6 +9,7 @@ if libdrm_amdgpu.found()
> 'amd_cs_nop',
> 'amd_info',
> 'amd_prime',
> + 'amd_module_load',
> ]
> amdgpu_deps += libdrm_amdgpu
> endif
> --
> 2.25.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Figt-dev&data=04%7C01%7CAnson.Jacob%40amd.com%7C6748889419fa450691e308d92f4cd022%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637592829230568891%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=RFYYdhHiC5Ixzg20hK3UYdYXDgwdf8nbmTLpnXkcjAU%3D&reserved=0
[-- Attachment #1.2: Type: text/html, Size: 15264 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/amdgpu: Introduced new amdgpu module reload test
2021-06-14 15:35 [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test Anson Jacob
2021-06-14 15:35 ` [igt-dev] [PATCH i-g-t 2/2] tests/amdgpu: Fix typo in amd_module_load Anson Jacob
2021-06-14 15:55 ` [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test Mark Yacoub
@ 2021-06-14 16:39 ` Patchwork
2021-06-14 19:38 ` [igt-dev] [PATCH i-g-t 1/2] " Rodrigo Siqueira
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-06-14 16:39 UTC (permalink / raw)
To: Jacob, Anson; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 2746 bytes --]
== Series Details ==
Series: series starting with [i-g-t,1/2] tests/amdgpu: Introduced new amdgpu module reload test
URL : https://patchwork.freedesktop.org/series/91462/
State : success
== Summary ==
CI Bug Log - changes from IGT_6105 -> IGTPW_5918
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/index.html
Known issues
------------
Here are the changes found in IGTPW_5918 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-gfx:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +6 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/fi-kbl-soraka/igt@amdgpu/amd_basic@cs-gfx.html
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-apl-guc: NOTRUN -> [SKIP][2] ([fdo#109271]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/fi-apl-guc/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@i915_hangman@error-state-basic:
- fi-apl-guc: NOTRUN -> [DMESG-WARN][3] ([i915#1610])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/fi-apl-guc/igt@i915_hangman@error-state-basic.html
* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> [FAIL][4] ([i915#2426] / [i915#3363])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/fi-apl-guc/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
Participating hosts (43 -> 39)
------------------------------
Additional (1): fi-apl-guc
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-dg1-1 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6105 -> IGTPW_5918
CI-20190529: 20190529
CI_DRM_10219: 75a3dafbc374d49f0762a19e3aa83cc321ae0e62 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5918: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/index.html
IGT_6105: 598a154680374e7875ae9ffc98425abc57398b2f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Testlist changes ==
+igt@amdgpu/amd_module_load@reload
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/index.html
[-- Attachment #1.2: Type: text/html, Size: 3377 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test
2021-06-14 15:35 [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test Anson Jacob
` (2 preceding siblings ...)
2021-06-14 16:39 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
@ 2021-06-14 19:38 ` Rodrigo Siqueira
2021-06-14 20:58 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] " Patchwork
2021-06-15 8:19 ` [igt-dev] [i-g-t, 1/2] " Petri Latvala
5 siblings, 0 replies; 11+ messages in thread
From: Rodrigo Siqueira @ 2021-06-14 19:38 UTC (permalink / raw)
To: Anson Jacob; +Cc: igt-dev, Victor Lu, markyacoub
[-- Attachment #1.1: Type: text/plain, Size: 6104 bytes --]
Hi Anson and Victor,
First of all, thanks for sending this patch. See my comments inline.
On 06/14, Anson Jacob wrote:
> From: Victor Lu <victorchengchi.lu@amd.com>
>
> Based off of i915/i915_module_load, unloads and loads the
> amdgpu module.
Maybe expand this commit message to describe better why and how we test
our load and unload. Consider highlighting which ASIC you tested this
patch.
> Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
> Acked-by: Anson Jacob <Anson.Jacob@amd.com>
Anson, since you're working in this test, I think it make sense that you
add the tag "Co-developed-by: YOUR NAME <YOUR@EMAIL>" and your Sob.
> ---
> lib/igt_kmod.c | 41 ++++++++++++++++++
> lib/igt_kmod.h | 3 ++
> tests/amdgpu/amd_module_load.c | 77 ++++++++++++++++++++++++++++++++++
> tests/amdgpu/meson.build | 1 +
> 4 files changed, 122 insertions(+)
> create mode 100644 tests/amdgpu/amd_module_load.c
>
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index 55295fa5..69bdc810 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -433,6 +433,47 @@ igt_i915_driver_unload(void)
> return IGT_EXIT_SUCCESS;
> }
>
> +int
> +igt_amdgpu_driver_load(const char *opts)
> +{
> + if (opts)
> + igt_info("Reloading amdgpu with %s\n\n", opts);
> +
> + if (igt_kmod_load("amdgpu", opts)) {
> + igt_warn("Could not load amdgpu\n");
> + return IGT_EXIT_FAILURE;
> + }
> +
> + bind_fbcon(true);
> +
> + return IGT_EXIT_SUCCESS;
> +}
> +
> +int
> +igt_amdgpu_driver_unload(void)
> +{
> + bind_fbcon(false);
> +
> + if (igt_kmod_is_loaded("amdgpu")) {
> + if (igt_kmod_unload("amdgpu", 0)) {
> + igt_warn("Could not unload amdgpu\n");
> + igt_kmod_list_loaded();
> + igt_lsof("/dev/dri");
> + return IGT_EXIT_SKIP;
> + }
> + }
> +
> + igt_kmod_unload("drm_kms_helper", 0);
> + igt_kmod_unload("drm", 0);
> +
> + if (igt_kmod_is_loaded("amdgpu")) {
> + igt_warn("amdgpu.ko still loaded!\n");
> + return IGT_EXIT_FAILURE;
> + }
> +
> + return IGT_EXIT_SUCCESS;
> +}
> +
> static void kmsg_dump(int fd)
> {
> char record[4096 + 1];
> diff --git a/lib/igt_kmod.h b/lib/igt_kmod.h
> index c71ec147..04c87516 100644
> --- a/lib/igt_kmod.h
> +++ b/lib/igt_kmod.h
> @@ -39,6 +39,9 @@ int igt_kmod_unload(const char *mod_name, unsigned int flags);
> int igt_i915_driver_load(const char *opts);
> int igt_i915_driver_unload(void);
>
> +int igt_amdgpu_driver_load(const char *opts);
> +int igt_amdgpu_driver_unload(void);
> +
> void igt_kselftests(const char *module_name,
> const char *module_options,
> const char *result_option,
> diff --git a/tests/amdgpu/amd_module_load.c b/tests/amdgpu/amd_module_load.c
> new file mode 100644
> index 00000000..e682d2c5
> --- /dev/null
> +++ b/tests/amdgpu/amd_module_load.c
> @@ -0,0 +1,77 @@
> +/*
> + * Copyright 2020 Advanced Micro Devices, Inc.
s/2020/2021/
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
> + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + *
> + */
> +
> +#include "igt.h"
> +#include "igt_kmod.h"
> +
> +#include <amdgpu.h>
> +#include <amdgpu_drm.h>
> +#include <sys/ioctl.h>
> +
> +/**
> + * Adapted from /tests/i915/i915_module_load.c
> + */
Consider describing our way to run this sanity check instead of
referencing another file.
> +static void
> +sanity_check(void)
In this patch, I noticed that you declared functions with two and one
lines. How about keeping all functions declared in a single line (when
it is possible, ofc) to keep things consistent?
> +{
> + int err = 0;
> + int fd;
> + int arg_ret;
> + struct drm_amdgpu_info args = {0};
Add a new line to separate the declaration from the utilization.
> + args.return_pointer = (uintptr_t) &arg_ret;
> + args.return_size = sizeof(int);
> + args.query = AMDGPU_INFO_HW_IP_INFO;
> +
> + fd = drm_open_driver(DRIVER_AMDGPU);
> + igt_set_timeout(1, "Module reload timeout!");
> +
> + if (ioctl(fd, DRM_IOCTL_AMDGPU_INFO, &args) < 0)
> + err = -errno;
> +
> + igt_set_timeout(0, NULL);
> + close(fd);
> +
> + igt_assert_f(err, 0);
> +}
> +
> +igt_main
> +{
> + igt_subtest("reload") {
Add an igt_describe.
Best Regards
Siqueira
> + int err;
> + igt_amdgpu_driver_unload();
> +
> + err = igt_amdgpu_driver_load(NULL);
> +
> + igt_assert_eq(err, 0);
> +
> + sanity_check();
> +
> + igt_amdgpu_driver_unload();
> + }
> +
> + igt_fixture
> + {
> + /* load the module back in */
> + igt_amdgpu_driver_load(NULL);
> + }
> +}
> diff --git a/tests/amdgpu/meson.build b/tests/amdgpu/meson.build
> index b92aa22b..84179410 100644
> --- a/tests/amdgpu/meson.build
> +++ b/tests/amdgpu/meson.build
> @@ -9,6 +9,7 @@ if libdrm_amdgpu.found()
> 'amd_cs_nop',
> 'amd_info',
> 'amd_prime',
> + 'amd_module_load',
> ]
> amdgpu_deps += libdrm_amdgpu
> endif
> --
> 2.25.1
>
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] tests/amdgpu: Fix typo in amd_module_load
2021-06-14 15:35 ` [igt-dev] [PATCH i-g-t 2/2] tests/amdgpu: Fix typo in amd_module_load Anson Jacob
@ 2021-06-14 19:39 ` Rodrigo Siqueira
2021-06-15 8:10 ` [igt-dev] [i-g-t, " Petri Latvala
2021-06-15 8:20 ` Petri Latvala
2 siblings, 0 replies; 11+ messages in thread
From: Rodrigo Siqueira @ 2021-06-14 19:39 UTC (permalink / raw)
To: Anson Jacob; +Cc: igt-dev, Victor Lu, markyacoub
[-- Attachment #1.1: Type: text/plain, Size: 1447 bytes --]
Hi Anson,
Let's squash this patch with the previous one.
Thanks
On 06/14, Anson Jacob wrote:
> From: Victor Lu <victorchengchi.lu@amd.com>
>
> A typo in amd_module_load was causing the test to fail.
> igt_assert_f(err, 0) should have been igt_assert_eq(err, 0),
> to check err == 0. Also added drm_fd >= 0 check and made
> ioctl query more explicit.
>
> Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
> Acked-by: Anson Jacob <Anson.Jacob@amd.com>
> ---
> tests/amdgpu/amd_module_load.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/amdgpu/amd_module_load.c b/tests/amdgpu/amd_module_load.c
> index e682d2c5..8762b2a2 100644
> --- a/tests/amdgpu/amd_module_load.c
> +++ b/tests/amdgpu/amd_module_load.c
> @@ -41,8 +41,10 @@ sanity_check(void)
> args.return_pointer = (uintptr_t) &arg_ret;
> args.return_size = sizeof(int);
> args.query = AMDGPU_INFO_HW_IP_INFO;
> + args.query_hw_ip.type = AMDGPU_HW_IP_COMPUTE;
>
> fd = drm_open_driver(DRIVER_AMDGPU);
> + igt_assert_f(fd >= 0, "Module failed to load\n");
> igt_set_timeout(1, "Module reload timeout!");
>
> if (ioctl(fd, DRM_IOCTL_AMDGPU_INFO, &args) < 0)
> @@ -51,7 +53,7 @@ sanity_check(void)
> igt_set_timeout(0, NULL);
> close(fd);
>
> - igt_assert_f(err, 0);
> + igt_assert_eq(err, 0);
> }
>
> igt_main
> --
> 2.25.1
>
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] tests/amdgpu: Introduced new amdgpu module reload test
2021-06-14 15:35 [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test Anson Jacob
` (3 preceding siblings ...)
2021-06-14 19:38 ` [igt-dev] [PATCH i-g-t 1/2] " Rodrigo Siqueira
@ 2021-06-14 20:58 ` Patchwork
2021-06-15 8:19 ` [igt-dev] [i-g-t, 1/2] " Petri Latvala
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-06-14 20:58 UTC (permalink / raw)
To: Jacob, Anson; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 30305 bytes --]
== Series Details ==
Series: series starting with [i-g-t,1/2] tests/amdgpu: Introduced new amdgpu module reload test
URL : https://patchwork.freedesktop.org/series/91462/
State : success
== Summary ==
CI Bug Log - changes from IGT_6105_full -> IGTPW_5918_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/index.html
Known issues
------------
Here are the changes found in IGTPW_5918_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@display-4x:
- shard-iclb: NOTRUN -> [SKIP][1] ([i915#1839])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb4/igt@feature_discovery@display-4x.html
* igt@gem_create@create-massive:
- shard-iclb: NOTRUN -> [DMESG-WARN][2] ([i915#3002])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb1/igt@gem_create@create-massive.html
- shard-kbl: NOTRUN -> [DMESG-WARN][3] ([i915#3002])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl4/igt@gem_create@create-massive.html
- shard-tglb: NOTRUN -> [DMESG-WARN][4] ([i915#3002])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-tglb3/igt@gem_create@create-massive.html
- shard-glk: NOTRUN -> [DMESG-WARN][5] ([i915#3002])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-glk1/igt@gem_create@create-massive.html
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099]) +4 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-snb5/igt@gem_ctx_persistence@legacy-engines-mixed.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2846])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-kbl4/igt@gem_exec_fair@basic-deadline.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl7/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: NOTRUN -> [FAIL][9] ([i915#2842]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [PASS][10] -> [SKIP][11] ([fdo#109271]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-kbl7/igt@gem_exec_fair@basic-pace@rcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl6/igt@gem_exec_fair@basic-pace@rcs0.html
- shard-tglb: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-tglb2/igt@gem_exec_fair@basic-pace@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-tglb7/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][14] -> [FAIL][15] ([i915#2842]) +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-glk7/igt@gem_exec_fair@basic-throttle@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-glk3/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_whisper@basic-queues-forked:
- shard-glk: [PASS][16] -> [DMESG-WARN][17] ([i915#118] / [i915#95])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-glk6/igt@gem_exec_whisper@basic-queues-forked.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-glk2/igt@gem_exec_whisper@basic-queues-forked.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#2190])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl6/igt@gem_huc_copy@huc-copy.html
- shard-kbl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#2190])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl1/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-iclb: [PASS][20] -> [FAIL][21] ([i915#307])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-iclb1/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb6/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
* igt@gem_pread@exhaustion:
- shard-snb: NOTRUN -> [WARN][22] ([i915#2658])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-snb7/igt@gem_pread@exhaustion.html
* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][23] ([i915#768])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb7/igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3323])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl6/igt@gem_userptr_blits@dmabuf-sync.html
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3323])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl8/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][26] ([i915#3002]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl2/igt@gem_userptr_blits@input-checking.html
* igt@gen3_render_linear_blits:
- shard-iclb: NOTRUN -> [SKIP][27] ([fdo#109289])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb7/igt@gen3_render_linear_blits.html
* igt@gen9_exec_parse@bb-start-far:
- shard-iclb: NOTRUN -> [SKIP][28] ([fdo#112306])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb6/igt@gen9_exec_parse@bb-start-far.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][29] -> [SKIP][30] ([fdo#109271])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-apl7/igt@i915_pm_dc@dc9-dpms.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl6/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: NOTRUN -> [WARN][31] ([i915#1804] / [i915#2684])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: NOTRUN -> [INCOMPLETE][32] ([i915#2782])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-snb6/igt@i915_selftest@live@hangcheck.html
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-iclb: NOTRUN -> [SKIP][33] ([i915#1769])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb4/igt@kms_atomic_transition@plane-all-modeset-transition.html
- shard-tglb: NOTRUN -> [SKIP][34] ([i915#1769])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-tglb3/igt@kms_atomic_transition@plane-all-modeset-transition.html
* igt@kms_big_fb@yf-tiled-64bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][35] ([fdo#110723])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb7/igt@kms_big_fb@yf-tiled-64bpp-rotate-270.html
* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-kbl: NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +8 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl4/igt@kms_chamelium@hdmi-hpd-with-enabled-mode.html
* igt@kms_chamelium@vga-edid-read:
- shard-apl: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +17 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl3/igt@kms_chamelium@vga-edid-read.html
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109284] / [fdo#111827]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb2/igt@kms_chamelium@vga-edid-read.html
- shard-glk: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-glk9/igt@kms_chamelium@vga-edid-read.html
* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-snb: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +23 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-snb6/igt@kms_color_chamelium@pipe-a-ctm-0-25.html
* igt@kms_color_chamelium@pipe-d-ctm-red-to-blue:
- shard-tglb: NOTRUN -> [SKIP][41] ([fdo#109284] / [fdo#111827]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-tglb1/igt@kms_color_chamelium@pipe-d-ctm-red-to-blue.html
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb7/igt@kms_color_chamelium@pipe-d-ctm-red-to-blue.html
* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][43] ([i915#1319])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl1/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@mei_interface:
- shard-iclb: NOTRUN -> [SKIP][44] ([fdo#109300] / [fdo#111066])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb7/igt@kms_content_protection@mei_interface.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109278] / [fdo#109279])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb4/igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-snb: NOTRUN -> [SKIP][46] ([fdo#109271]) +265 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-snb5/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-top-edge:
- shard-iclb: NOTRUN -> [SKIP][47] ([fdo#109278]) +6 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb1/igt@kms_cursor_edge_walk@pipe-d-128x128-top-edge.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109274] / [fdo#109278])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb4/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic.html
* igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible:
- shard-tglb: NOTRUN -> [SKIP][49] ([fdo#111825]) +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-tglb8/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible.html
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109274]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb1/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
- shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#2642]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-glk: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#2642])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
- shard-kbl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#2642])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
- shard-glk: NOTRUN -> [SKIP][54] ([fdo#109271]) +5 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-glk3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][55] ([fdo#109280]) +10 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-plflip-blt.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][56] ([fdo#108145] / [i915#265]) +3 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][57] ([fdo#108145] / [i915#265]) +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl2/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2733])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl8/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-tglb: NOTRUN -> [SKIP][59] ([i915#2920]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-tglb2/igt@kms_psr2_sf@cursor-plane-update-sf.html
- shard-glk: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#658]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-glk6/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#658]) +4 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-kbl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#658]) +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-iclb: NOTRUN -> [SKIP][63] ([i915#658]) +3 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][64] -> [SKIP][65] ([fdo#109441]) +3 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-iclb2/igt@kms_psr@psr2_basic.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb3/igt@kms_psr@psr2_basic.html
* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> [FAIL][66] ([IGT#2])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl6/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271]) +249 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl7/igt@kms_vblank@pipe-d-ts-continuation-idle.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#533]) +4 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl6/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#2437]) +2 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl6/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-fb-id:
- shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#2437]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl2/igt@kms_writeback@writeback-fb-id.html
* igt@nouveau_crc@pipe-d-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][71] ([fdo#109278] / [i915#2530])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb6/igt@nouveau_crc@pipe-d-source-outp-complete.html
* igt@prime_nv_api@nv_i915_reimport_twice_check_flink_name:
- shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109291]) +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb4/igt@prime_nv_api@nv_i915_reimport_twice_check_flink_name.html
* igt@prime_nv_pcopy@test2:
- shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271]) +105 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl2/igt@prime_nv_pcopy@test2.html
* igt@prime_nv_pcopy@test3_1:
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#109291])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-tglb5/igt@prime_nv_pcopy@test3_1.html
* igt@sysfs_clients@create:
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#2994]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl3/igt@sysfs_clients@create.html
* igt@sysfs_clients@recycle-many:
- shard-kbl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#2994]) +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl7/igt@sysfs_clients@recycle-many.html
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-kbl: [DMESG-WARN][77] ([i915#180]) -> [PASS][78] +3 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl2/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][79] ([i915#2842]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [FAIL][81] ([i915#2842]) -> [PASS][82] +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-glk6/igt@gem_exec_fair@basic-pace@vcs0.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-glk7/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [FAIL][83] ([i915#2842]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-kbl7/igt@gem_exec_fair@basic-pace@vecs0.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl6/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][85] ([i915#2849]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-iclb4/igt@gem_exec_fair@basic-throttle@rcs0.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_whisper@basic-queues-priority:
- shard-glk: [DMESG-WARN][87] ([i915#118] / [i915#95]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-glk4/igt@gem_exec_whisper@basic-queues-priority.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-glk8/igt@gem_exec_whisper@basic-queues-priority.html
* igt@gem_mmap_gtt@big-copy:
- shard-glk: [FAIL][89] ([i915#307]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-glk5/igt@gem_mmap_gtt@big-copy.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-glk9/igt@gem_mmap_gtt@big-copy.html
* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-iclb: [FAIL][91] ([i915#307]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-iclb4/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb7/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled:
- shard-glk: [FAIL][93] ([i915#3451]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-glk8/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-glk5/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][95] ([i915#79]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-iclb: [INCOMPLETE][97] ([i915#1373]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-iclb3/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb1/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
* igt@kms_flip@wf_vblank-ts-check-interruptible@b-dp1:
- shard-kbl: [DMESG-WARN][99] ([i915#62]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-kbl2/igt@kms_flip@wf_vblank-ts-check-interruptible@b-dp1.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl2/igt@kms_flip@wf_vblank-ts-check-interruptible@b-dp1.html
* igt@kms_frontbuffer_tracking@fbcpsr-tiling-y:
- shard-iclb: [FAIL][101] -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-tiling-y.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-tiling-y.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-apl: [DMESG-WARN][103] ([i915#180]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-apl8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][105] ([fdo#109441]) -> [PASS][106] +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_vblank@pipe-a-wait-idle-hang:
- shard-tglb: [DMESG-WARN][107] ([i915#2868]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-tglb5/igt@kms_vblank@pipe-a-wait-idle-hang.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-tglb1/igt@kms_vblank@pipe-a-wait-idle-hang.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][109] ([i915#2684]) -> [WARN][110] ([i915#1804] / [i915#2684])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb3/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
- shard-iclb: [SKIP][111] ([i915#2920]) -> [SKIP][112] ([i915#658]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb8/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-iclb: [SKIP][113] ([i915#658]) -> [SKIP][114] ([i915#2920]) +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-iclb5/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][115] ([i915#180] / [i915#295]) -> [INCOMPLETE][116] ([i915#155])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2292] / [i915#3002] / [i915#3363] / [i915#602]) -> ([FAIL][123], [FAIL][124]) ([i915#2505] / [i915#3002] / [i915#3363])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-kbl3/igt@runner@aborted.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-kbl4/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-kbl7/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-kbl7/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-kbl7/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-kbl3/igt@runner@aborted.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl4/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-kbl6/igt@runner@aborted.html
- shard-apl: ([FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129]) ([fdo#109271] / [i915#1610] / [i915#180] / [i915#1814] / [i915#2292] / [i915#3363]) -> ([FAIL][130], [FAIL][131]) ([i915#3002] / [i915#3363])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-apl8/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-apl6/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-apl8/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-apl2/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6105/shard-apl8/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl2/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/shard-apl2/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112306]: https://bugs.freedesktop.org/show_bug.cgi?id=112306
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1373]: https://gitlab.freedesktop.org/drm/intel/issues/1373
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2292]: https://gitlab.freedesktop.org/drm/intel/issues/2292
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2642]: https://gitlab.freedesktop.org/drm/intel/issues/2642
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2733]: https://gitlab.freedesktop.org/drm/intel/issues/2733
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#307]: https://gitlab.freedesktop.o
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5918/index.html
[-- Attachment #1.2: Type: text/html, Size: 38535 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [i-g-t, 2/2] tests/amdgpu: Fix typo in amd_module_load
2021-06-14 15:35 ` [igt-dev] [PATCH i-g-t 2/2] tests/amdgpu: Fix typo in amd_module_load Anson Jacob
2021-06-14 19:39 ` Rodrigo Siqueira
@ 2021-06-15 8:10 ` Petri Latvala
2021-06-15 8:20 ` Petri Latvala
2 siblings, 0 replies; 11+ messages in thread
From: Petri Latvala @ 2021-06-15 8:10 UTC (permalink / raw)
To: Anson Jacob; +Cc: igt-dev, Victor Lu, markyacoub
On Mon, Jun 14, 2021 at 11:35:57AM -0400, Anson Jacob wrote:
> From: Victor Lu <victorchengchi.lu@amd.com>
>
> A typo in amd_module_load was causing the test to fail.
> igt_assert_f(err, 0) should have been igt_assert_eq(err, 0),
> to check err == 0. Also added drm_fd >= 0 check and made
> ioctl query more explicit.
>
> Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
> Acked-by: Anson Jacob <Anson.Jacob@amd.com>
Squash these two patches together.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [i-g-t, 1/2] tests/amdgpu: Introduced new amdgpu module reload test
2021-06-14 15:35 [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test Anson Jacob
` (4 preceding siblings ...)
2021-06-14 20:58 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] " Patchwork
@ 2021-06-15 8:19 ` Petri Latvala
5 siblings, 0 replies; 11+ messages in thread
From: Petri Latvala @ 2021-06-15 8:19 UTC (permalink / raw)
To: Anson Jacob; +Cc: igt-dev, Victor Lu, markyacoub
On Mon, Jun 14, 2021 at 11:35:56AM -0400, Anson Jacob wrote:
> From: Victor Lu <victorchengchi.lu@amd.com>
>
> Based off of i915/i915_module_load, unloads and loads the
> amdgpu module.
>
> Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
> Acked-by: Anson Jacob <Anson.Jacob@amd.com>
> ---
> lib/igt_kmod.c | 41 ++++++++++++++++++
> lib/igt_kmod.h | 3 ++
> tests/amdgpu/amd_module_load.c | 77 ++++++++++++++++++++++++++++++++++
> tests/amdgpu/meson.build | 1 +
> 4 files changed, 122 insertions(+)
> create mode 100644 tests/amdgpu/amd_module_load.c
>
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index 55295fa5..69bdc810 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -433,6 +433,47 @@ igt_i915_driver_unload(void)
> return IGT_EXIT_SUCCESS;
> }
>
> +int
> +igt_amdgpu_driver_load(const char *opts)
> +{
> + if (opts)
> + igt_info("Reloading amdgpu with %s\n\n", opts);
> +
> + if (igt_kmod_load("amdgpu", opts)) {
> + igt_warn("Could not load amdgpu\n");
> + return IGT_EXIT_FAILURE;
> + }
> +
> + bind_fbcon(true);
> +
> + return IGT_EXIT_SUCCESS;
> +}
> +
> +int
> +igt_amdgpu_driver_unload(void)
> +{
> + bind_fbcon(false);
> +
> + if (igt_kmod_is_loaded("amdgpu")) {
> + if (igt_kmod_unload("amdgpu", 0)) {
> + igt_warn("Could not unload amdgpu\n");
> + igt_kmod_list_loaded();
> + igt_lsof("/dev/dri");
> + return IGT_EXIT_SKIP;
> + }
> + }
> +
> + igt_kmod_unload("drm_kms_helper", 0);
> + igt_kmod_unload("drm", 0);
> +
> + if (igt_kmod_is_loaded("amdgpu")) {
> + igt_warn("amdgpu.ko still loaded!\n");
> + return IGT_EXIT_FAILURE;
> + }
> +
> + return IGT_EXIT_SUCCESS;
> +}
Add documentation for these functions please.
(Now that I mention it, the i915 equivalent functions have
documentation blocks but don't actually document the return values...)
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [i-g-t, 2/2] tests/amdgpu: Fix typo in amd_module_load
2021-06-14 15:35 ` [igt-dev] [PATCH i-g-t 2/2] tests/amdgpu: Fix typo in amd_module_load Anson Jacob
2021-06-14 19:39 ` Rodrigo Siqueira
2021-06-15 8:10 ` [igt-dev] [i-g-t, " Petri Latvala
@ 2021-06-15 8:20 ` Petri Latvala
2 siblings, 0 replies; 11+ messages in thread
From: Petri Latvala @ 2021-06-15 8:20 UTC (permalink / raw)
To: Anson Jacob; +Cc: igt-dev, Victor Lu, markyacoub
On Mon, Jun 14, 2021 at 11:35:57AM -0400, Anson Jacob wrote:
> From: Victor Lu <victorchengchi.lu@amd.com>
>
> A typo in amd_module_load was causing the test to fail.
> igt_assert_f(err, 0) should have been igt_assert_eq(err, 0),
> to check err == 0. Also added drm_fd >= 0 check and made
> ioctl query more explicit.
>
> Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
> Acked-by: Anson Jacob <Anson.Jacob@amd.com>
> ---
> tests/amdgpu/amd_module_load.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/amdgpu/amd_module_load.c b/tests/amdgpu/amd_module_load.c
> index e682d2c5..8762b2a2 100644
> --- a/tests/amdgpu/amd_module_load.c
> +++ b/tests/amdgpu/amd_module_load.c
> @@ -41,8 +41,10 @@ sanity_check(void)
> args.return_pointer = (uintptr_t) &arg_ret;
> args.return_size = sizeof(int);
> args.query = AMDGPU_INFO_HW_IP_INFO;
> + args.query_hw_ip.type = AMDGPU_HW_IP_COMPUTE;
>
> fd = drm_open_driver(DRIVER_AMDGPU);
> + igt_assert_f(fd >= 0, "Module failed to load\n");
drm_open_driver() already asserts that it's able to give you a proper
fd.
--
Petri Latvala
> igt_set_timeout(1, "Module reload timeout!");
>
> if (ioctl(fd, DRM_IOCTL_AMDGPU_INFO, &args) < 0)
> @@ -51,7 +53,7 @@ sanity_check(void)
> igt_set_timeout(0, NULL);
> close(fd);
>
> - igt_assert_f(err, 0);
> + igt_assert_eq(err, 0);
> }
>
> igt_main
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-06-15 8:18 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-14 15:35 [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test Anson Jacob
2021-06-14 15:35 ` [igt-dev] [PATCH i-g-t 2/2] tests/amdgpu: Fix typo in amd_module_load Anson Jacob
2021-06-14 19:39 ` Rodrigo Siqueira
2021-06-15 8:10 ` [igt-dev] [i-g-t, " Petri Latvala
2021-06-15 8:20 ` Petri Latvala
2021-06-14 15:55 ` [igt-dev] [PATCH i-g-t 1/2] tests/amdgpu: Introduced new amdgpu module reload test Mark Yacoub
2021-06-14 16:30 ` Jacob, Anson
2021-06-14 16:39 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2021-06-14 19:38 ` [igt-dev] [PATCH i-g-t 1/2] " Rodrigo Siqueira
2021-06-14 20:58 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] " Patchwork
2021-06-15 8:19 ` [igt-dev] [i-g-t, 1/2] " Petri Latvala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.