[PATCH] ssb: remove unreachable code

[PATCH] ssb: remove unreachable code

[Tian Tao]

The return value of ssb_bus_unregister can only be 0 or 1, so this
condition if (err == -EBUSY) will not hold, so delete it.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/ssb/main.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 0a26984..8fcf53c 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -431,9 +431,7 @@ void ssb_bus_unregister(struct ssb_bus *bus)
 	int err;
 
 	err = ssb_gpio_unregister(bus);
-	if (err == -EBUSY)
-		pr_debug("Some GPIOs are still in use\n");
-	else if (err)
+	if (err)
 		pr_debug("Can not unregister GPIO driver: %i\n", err);
 
 	ssb_buses_lock();
-- 
2.7.4

Re: [PATCH] ssb: remove unreachable code

[Michael Büsch]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

On Tue, 18 May 2021 10:52:32 +0800
Tian Tao <tiantao6@hisilicon.com> wrote:

> The return value of ssb_bus_unregister can only be 0 or 1, so this
> condition if (err == -EBUSY) will not hold, so delete it.

> @@ -431,9 +431,7 @@ void ssb_bus_unregister(struct ssb_bus *bus)
>  	int err;
>  
>  	err = ssb_gpio_unregister(bus);
> -	if (err == -EBUSY)
> -		pr_debug("Some GPIOs are still in use\n");
> -	else if (err)
> +	if (err)
>  		pr_debug("Can not unregister GPIO driver: %i\n", err);
>  
>  	ssb_buses_lock();

Good catch.
Minor correction: The return value can be 0 or -1.

Acked-by: Michael Büsch <m@bues.ch>

-- 
Michael

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] ssb: remove unreachable code

[tiantao (H)]

在 2021/5/21 0:51, Michael Büsch 写道:
> On Tue, 18 May 2021 10:52:32 +0800
> Tian Tao <tiantao6@hisilicon.com> wrote:
>
>> The return value of ssb_bus_unregister can only be 0 or 1, so this
>> condition if (err == -EBUSY) will not hold, so delete it.
>> @@ -431,9 +431,7 @@ void ssb_bus_unregister(struct ssb_bus *bus)
>>   	int err;
>>   
>>   	err = ssb_gpio_unregister(bus);
>> -	if (err == -EBUSY)
>> -		pr_debug("Some GPIOs are still in use\n");
>> -	else if (err)
>> +	if (err)
>>   		pr_debug("Can not unregister GPIO driver: %i\n", err);
>>   
>>   	ssb_buses_lock();
> Good catch.
> Minor correction: The return value can be 0 or -1.
yes, you are right. thanks again.:-)
>
> Acked-by: Michael Büsch <m@bues.ch>
>

Re: [PATCH] ssb: remove unreachable code

[Kalle Valo]

"tiantao (H)" <tiantao6@huawei.com> writes:

> 在 2021/5/21 0:51, Michael Büsch 写道:
>> On Tue, 18 May 2021 10:52:32 +0800
>> Tian Tao <tiantao6@hisilicon.com> wrote:
>>
>>> The return value of ssb_bus_unregister can only be 0 or 1, so this
>>> condition if (err == -EBUSY) will not hold, so delete it.
>>> @@ -431,9 +431,7 @@ void ssb_bus_unregister(struct ssb_bus *bus)
>>>   	int err;
>>>     	err = ssb_gpio_unregister(bus);
>>> -	if (err == -EBUSY)
>>> -		pr_debug("Some GPIOs are still in use\n");
>>> -	else if (err)
>>> +	if (err)
>>>   		pr_debug("Can not unregister GPIO driver: %i\n", err);
>>>     	ssb_buses_lock();
>> Good catch.
>> Minor correction: The return value can be 0 or -1.
>
> yes, you are right. thanks again.:-)

I'll fix the commit log to match that.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: ssb: remove unreachable code

[Kalle Valo]

Tian Tao <tiantao6@hisilicon.com> wrote:

> The return value of ssb_bus_unregister can only be 0 or -1, so this
> condition if (err == -EBUSY) will not hold, so delete it.
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> Acked-by: Michael Büsch <m@bues.ch>

Patch applied to wireless-drivers-next.git, thanks.

233bc2837282 ssb: remove unreachable code

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1621306352-3632-1-git-send-email-tiantao6@hisilicon.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches