* [PATCH] rsi: Assign beacon rate settings to the correct rate_info descriptor field
@ 2021-05-07 21:31 Marek Vasut
2021-06-15 13:37 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2021-05-07 21:31 UTC (permalink / raw)
To: linux-wireless
Cc: Marek Vasut, Amitkumar Karwar, Angus Ainslie, David S . Miller,
Jakub Kicinski, Kalle Valo, Karun Eagalapati, Martin Kepplinger,
Prameela Rani Garnepudi, Sebastian Krzyszkowiak,
Siva Rebbagondla, netdev, stable
The RSI_RATE_x bits must be assigned to struct rsi_data_desc rate_info
field. The rest of the driver does it correctly, except this one place,
so fix it. This is also aligned with the RSI downstream vendor driver.
Without this patch, an AP operating at 5 GHz does not transmit any
beacons at all, this patch fixes that.
Fixes: d26a9559403c ("rsi: add beacon changes for AP mode")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Amitkumar Karwar <amit.karwar@redpinesignals.com>
Cc: Angus Ainslie <angus@akkea.ca>
Cc: David S. Miller <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: Karun Eagalapati <karun256@gmail.com>
Cc: Martin Kepplinger <martink@posteo.de>
Cc: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Cc: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Cc: Siva Rebbagondla <siva8118@gmail.com>
Cc: netdev@vger.kernel.org
Cc: stable@vger.kernel.org
---
drivers/net/wireless/rsi/rsi_91x_hal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_hal.c b/drivers/net/wireless/rsi/rsi_91x_hal.c
index ce9892152f4d..ab837921d9a4 100644
--- a/drivers/net/wireless/rsi/rsi_91x_hal.c
+++ b/drivers/net/wireless/rsi/rsi_91x_hal.c
@@ -470,9 +470,9 @@ int rsi_prepare_beacon(struct rsi_common *common, struct sk_buff *skb)
}
if (common->band == NL80211_BAND_2GHZ)
- bcn_frm->bbp_info |= cpu_to_le16(RSI_RATE_1);
+ bcn_frm->rate_info |= cpu_to_le16(RSI_RATE_1);
else
- bcn_frm->bbp_info |= cpu_to_le16(RSI_RATE_6);
+ bcn_frm->rate_info |= cpu_to_le16(RSI_RATE_6);
if (mac_bcn->data[tim_offset + 2] == 0)
bcn_frm->frame_info |= cpu_to_le16(RSI_DATA_DESC_DTIM_BEACON);
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rsi: Assign beacon rate settings to the correct rate_info descriptor field
2021-05-07 21:31 [PATCH] rsi: Assign beacon rate settings to the correct rate_info descriptor field Marek Vasut
@ 2021-06-15 13:37 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-06-15 13:37 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-wireless, Marek Vasut, Amitkumar Karwar, Angus Ainslie,
David S . Miller, Jakub Kicinski, Karun Eagalapati,
Martin Kepplinger, Prameela Rani Garnepudi,
Sebastian Krzyszkowiak, Siva Rebbagondla, netdev, stable
Marek Vasut <marex@denx.de> wrote:
> The RSI_RATE_x bits must be assigned to struct rsi_data_desc rate_info
> field. The rest of the driver does it correctly, except this one place,
> so fix it. This is also aligned with the RSI downstream vendor driver.
> Without this patch, an AP operating at 5 GHz does not transmit any
> beacons at all, this patch fixes that.
>
> Fixes: d26a9559403c ("rsi: add beacon changes for AP mode")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Amitkumar Karwar <amit.karwar@redpinesignals.com>
> Cc: Angus Ainslie <angus@akkea.ca>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: Karun Eagalapati <karun256@gmail.com>
> Cc: Martin Kepplinger <martink@posteo.de>
> Cc: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
> Cc: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> Cc: Siva Rebbagondla <siva8118@gmail.com>
> Cc: netdev@vger.kernel.org
> Cc: stable@vger.kernel.org
Patch applied to wireless-drivers-next.git, thanks.
b1c3a24897bd rsi: Assign beacon rate settings to the correct rate_info descriptor field
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210507213105.140138-1-marex@denx.de/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-15 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07 21:31 [PATCH] rsi: Assign beacon rate settings to the correct rate_info descriptor field Marek Vasut
2021-06-15 13:37 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.