* [PATCH -next] ACPI: PRM: make symbol 'prm_module_list' static
@ 2021-06-15 17:21 Wei Yongjun
2021-06-17 12:41 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2021-06-15 17:21 UTC (permalink / raw)
To: weiyongjun1, Erik Kaneda, Rafael J. Wysocki, Len Brown
Cc: linux-acpi, kernel-janitors, Hulk Robot
The sparse tool complains as follows:
drivers/acpi/prmt.c:53:1: warning:
symbol 'prm_module_list' was not declared. Should it be static?
This symbol is not used outside of prmt.c, so marks it static.
Fixes: cefc7ca46235 ("ACPI: PRM: implement OperationRegion handler for the PlatformRtMechanism subtype")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/acpi/prmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/prmt.c b/drivers/acpi/prmt.c
index 33c274698d07..31cf9aee5edd 100644
--- a/drivers/acpi/prmt.c
+++ b/drivers/acpi/prmt.c
@@ -50,7 +50,7 @@ struct prm_context_buffer {
#pragma pack()
-LIST_HEAD(prm_module_list);
+static LIST_HEAD(prm_module_list);
struct prm_handler_info {
guid_t guid;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ACPI: PRM: make symbol 'prm_module_list' static
2021-06-15 17:21 [PATCH -next] ACPI: PRM: make symbol 'prm_module_list' static Wei Yongjun
@ 2021-06-17 12:41 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2021-06-17 12:41 UTC (permalink / raw)
To: Wei Yongjun
Cc: Erik Kaneda, Rafael J. Wysocki, Len Brown,
ACPI Devel Maling List, kernel-janitors, Hulk Robot
On Tue, Jun 15, 2021 at 7:11 PM Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> The sparse tool complains as follows:
>
> drivers/acpi/prmt.c:53:1: warning:
> symbol 'prm_module_list' was not declared. Should it be static?
>
> This symbol is not used outside of prmt.c, so marks it static.
>
> Fixes: cefc7ca46235 ("ACPI: PRM: implement OperationRegion handler for the PlatformRtMechanism subtype")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/acpi/prmt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/prmt.c b/drivers/acpi/prmt.c
> index 33c274698d07..31cf9aee5edd 100644
> --- a/drivers/acpi/prmt.c
> +++ b/drivers/acpi/prmt.c
> @@ -50,7 +50,7 @@ struct prm_context_buffer {
> #pragma pack()
>
>
> -LIST_HEAD(prm_module_list);
> +static LIST_HEAD(prm_module_list);
>
> struct prm_handler_info {
> guid_t guid;
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-17 12:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 17:21 [PATCH -next] ACPI: PRM: make symbol 'prm_module_list' static Wei Yongjun
2021-06-17 12:41 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.