* [linux-next:master 8852/10007] drivers/net/mhi/net.c:385:23: sparse: sparse: symbol 'mhi_wwan_ops' was not declared. Should it be static?
@ 2021-06-15 18:14 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-06-15 18:14 UTC (permalink / raw)
To: Loic Poulain; +Cc: kbuild-all, Linux Memory Management List
[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 19ae1f2bd9c091059f80646604ccef8a1e614f57
commit: 13adac032982c61bb590669e8e87e51558917ca1 [8852/10007] net: mhi_net: Register wwan_ops for link creation
config: x86_64-randconfig-s021-20210615 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=13adac032982c61bb590669e8e87e51558917ca1
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 13adac032982c61bb590669e8e87e51558917ca1
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/net/mhi/net.c:385:23: sparse: sparse: symbol 'mhi_wwan_ops' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37625 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [linux-next:master 8852/10007] drivers/net/mhi/net.c:385:23: sparse: sparse: symbol 'mhi_wwan_ops' was not declared. Should it be static?
@ 2021-06-15 18:14 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-06-15 18:14 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 19ae1f2bd9c091059f80646604ccef8a1e614f57
commit: 13adac032982c61bb590669e8e87e51558917ca1 [8852/10007] net: mhi_net: Register wwan_ops for link creation
config: x86_64-randconfig-s021-20210615 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=13adac032982c61bb590669e8e87e51558917ca1
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 13adac032982c61bb590669e8e87e51558917ca1
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/net/mhi/net.c:385:23: sparse: sparse: symbol 'mhi_wwan_ops' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37625 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFC PATCH linux-next] net: mhi_net: mhi_wwan_ops can be static
2021-06-15 18:14 ` kernel test robot
@ 2021-06-15 18:14 ` kernel test robot
-1 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-06-15 18:14 UTC (permalink / raw)
To: Loic Poulain; +Cc: kbuild-all, Linux Memory Management List
drivers/net/mhi/net.c:385:23: warning: symbol 'mhi_wwan_ops' was not declared. Should it be static?
Fixes: 13adac032982 ("net: mhi_net: Register wwan_ops for link creation")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mhi/net.c b/drivers/net/mhi/net.c
index 64af1e518484e..832d9de42f623 100644
--- a/drivers/net/mhi/net.c
+++ b/drivers/net/mhi/net.c
@@ -382,7 +382,7 @@ static void mhi_net_dellink(void *ctxt, struct net_device *ndev,
dev_set_drvdata(&mhi_dev->dev, NULL);
}
-const struct wwan_ops mhi_wwan_ops = {
+static const struct wwan_ops mhi_wwan_ops = {
.owner = THIS_MODULE,
.priv_size = sizeof(struct mhi_net_dev),
.setup = mhi_net_setup,
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RFC PATCH linux-next] net: mhi_net: mhi_wwan_ops can be static
@ 2021-06-15 18:14 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-06-15 18:14 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
drivers/net/mhi/net.c:385:23: warning: symbol 'mhi_wwan_ops' was not declared. Should it be static?
Fixes: 13adac032982 ("net: mhi_net: Register wwan_ops for link creation")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mhi/net.c b/drivers/net/mhi/net.c
index 64af1e518484e..832d9de42f623 100644
--- a/drivers/net/mhi/net.c
+++ b/drivers/net/mhi/net.c
@@ -382,7 +382,7 @@ static void mhi_net_dellink(void *ctxt, struct net_device *ndev,
dev_set_drvdata(&mhi_dev->dev, NULL);
}
-const struct wwan_ops mhi_wwan_ops = {
+static const struct wwan_ops mhi_wwan_ops = {
.owner = THIS_MODULE,
.priv_size = sizeof(struct mhi_net_dev),
.setup = mhi_net_setup,
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-15 18:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 18:14 [linux-next:master 8852/10007] drivers/net/mhi/net.c:385:23: sparse: sparse: symbol 'mhi_wwan_ops' was not declared. Should it be static? kernel test robot
2021-06-15 18:14 ` kernel test robot
2021-06-15 18:14 ` [RFC PATCH linux-next] net: mhi_net: mhi_wwan_ops can be static kernel test robot
2021-06-15 18:14 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.