* [PATCH][1.48] bitbake: providers: selected version not available should be a warning
@ 2021-05-11 9:27 Ross Burton
2021-06-15 20:13 ` [bitbake-devel] " Denys Dmytriyenko
0 siblings, 1 reply; 2+ messages in thread
From: Ross Burton @ 2021-05-11 9:27 UTC (permalink / raw)
To: bitbake-devel
From: Ross Burton <ross@burtonini.com>
If the selected version if not available, bitbake will happily attempt
to build something else. This should be a loud warning not a small note.
(Bitbake rev: 78cd63285713fde59506eb2e71a7b7ee59a594ff)
Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
bitbake/lib/bb/providers.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bitbake/lib/bb/providers.py b/bitbake/lib/bb/providers.py
index 81459c36d56..3f66a3d99fa 100644
--- a/bitbake/lib/bb/providers.py
+++ b/bitbake/lib/bb/providers.py
@@ -151,7 +151,7 @@ def findPreferredProvider(pn, cfgData, dataCache, pkg_pn = None, item = None):
if item:
itemstr = " (for item %s)" % item
if preferred_file is None:
- logger.info("preferred version %s of %s not available%s", pv_str, pn, itemstr)
+ logger.warn("preferred version %s of %s not available%s", pv_str, pn, itemstr)
available_vers = []
for file_set in pkg_pn:
for f in file_set:
@@ -163,7 +163,7 @@ def findPreferredProvider(pn, cfgData, dataCache, pkg_pn = None, item = None):
available_vers.append(ver_str)
if available_vers:
available_vers.sort()
- logger.info("versions of %s available: %s", pn, ' '.join(available_vers))
+ logger.warn("versions of %s available: %s", pn, ' '.join(available_vers))
else:
logger.debug(1, "selecting %s as PREFERRED_VERSION %s of package %s%s", preferred_file, pv_str, pn, itemstr)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [bitbake-devel] [PATCH][1.48] bitbake: providers: selected version not available should be a warning
2021-05-11 9:27 [PATCH][1.48] bitbake: providers: selected version not available should be a warning Ross Burton
@ 2021-06-15 20:13 ` Denys Dmytriyenko
0 siblings, 0 replies; 2+ messages in thread
From: Denys Dmytriyenko @ 2021-06-15 20:13 UTC (permalink / raw)
To: Ross Burton; +Cc: bitbake-devel
This has been picked up into 1.46/dunfell and now gives these extra warnings:
WARNING: .../bitbake/lib/bb/providers.py:154: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
logger.warn("preferred version %s of %s not available%s", pv_str, pn, itemstr)
WARNING: .../bitbake/lib/bb/providers.py:166: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
logger.warn("versions of %s available: %s", pn, ' '.join(available_vers))
On Tue, May 11, 2021 at 10:27:23AM +0100, Ross Burton wrote:
> From: Ross Burton <ross@burtonini.com>
>
> If the selected version if not available, bitbake will happily attempt
> to build something else. This should be a loud warning not a small note.
>
> (Bitbake rev: 78cd63285713fde59506eb2e71a7b7ee59a594ff)
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> bitbake/lib/bb/providers.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bitbake/lib/bb/providers.py b/bitbake/lib/bb/providers.py
> index 81459c36d56..3f66a3d99fa 100644
> --- a/bitbake/lib/bb/providers.py
> +++ b/bitbake/lib/bb/providers.py
> @@ -151,7 +151,7 @@ def findPreferredProvider(pn, cfgData, dataCache, pkg_pn = None, item = None):
> if item:
> itemstr = " (for item %s)" % item
> if preferred_file is None:
> - logger.info("preferred version %s of %s not available%s", pv_str, pn, itemstr)
> + logger.warn("preferred version %s of %s not available%s", pv_str, pn, itemstr)
> available_vers = []
> for file_set in pkg_pn:
> for f in file_set:
> @@ -163,7 +163,7 @@ def findPreferredProvider(pn, cfgData, dataCache, pkg_pn = None, item = None):
> available_vers.append(ver_str)
> if available_vers:
> available_vers.sort()
> - logger.info("versions of %s available: %s", pn, ' '.join(available_vers))
> + logger.warn("versions of %s available: %s", pn, ' '.join(available_vers))
> else:
> logger.debug(1, "selecting %s as PREFERRED_VERSION %s of package %s%s", preferred_file, pv_str, pn, itemstr)
>
> --
> 2.25.1
>
--
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186 6D76 4209 0272 9A92 C964
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-15 20:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 9:27 [PATCH][1.48] bitbake: providers: selected version not available should be a warning Ross Burton
2021-06-15 20:13 ` [bitbake-devel] " Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.