* [PATCH v1] tools: ipxe: update for fixing build with GCC11
@ 2021-06-15 21:26 Olaf Hering
2021-06-16 12:33 ` Andrew Cooper
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2021-06-15 21:26 UTC (permalink / raw)
To: xen-devel; +Cc: Olaf Hering, Ian Jackson, Wei Liu
Use a snapshot which includes commit
f3f568e382a5f19824b3bfc6081cde39eee661e8 ("[crypto] Add
memory output constraints for big-integer inline assembly"),
which fixes build with gcc11.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
tools/firmware/etherboot/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile
index ed9e11305f..23b3f6ca9d 100644
--- a/tools/firmware/etherboot/Makefile
+++ b/tools/firmware/etherboot/Makefile
@@ -10,7 +10,8 @@ else
IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
endif
-IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c
+# put an updated tar.gz on xenbits after changes to this variable
+IPXE_GIT_TAG := bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e
IPXE_TARBALL_URL ?= $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1] tools: ipxe: update for fixing build with GCC11
2021-06-15 21:26 [PATCH v1] tools: ipxe: update for fixing build with GCC11 Olaf Hering
@ 2021-06-16 12:33 ` Andrew Cooper
2021-06-16 12:58 ` Olaf Hering
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cooper @ 2021-06-16 12:33 UTC (permalink / raw)
To: Olaf Hering, xen-devel; +Cc: Ian Jackson, Wei Liu
On 15/06/2021 22:26, Olaf Hering wrote:
> Use a snapshot which includes commit
> f3f568e382a5f19824b3bfc6081cde39eee661e8 ("[crypto] Add
> memory output constraints for big-integer inline assembly"),
> which fixes build with gcc11.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
> tools/firmware/etherboot/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile
> index ed9e11305f..23b3f6ca9d 100644
> --- a/tools/firmware/etherboot/Makefile
> +++ b/tools/firmware/etherboot/Makefile
> @@ -10,7 +10,8 @@ else
> IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
> endif
>
> -IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c
> +# put an updated tar.gz on xenbits after changes to this variable
> +IPXE_GIT_TAG := bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e
CI says no.
Gitlab CI is currently fairly red because of a clang build fix which
hasn't made its way into master yet, but this job:
https://gitlab.com/xen-project/patchew/xen/-/jobs/1349871230
shows a real failure on CentOS 7.
...
[VERSION] bin/version.rtl8139.rom.o
[AR] bin/blib.a
ar: creating bin/blib.a
objcopy: invalid option -- 'D'
Usage: objcopy [option(s)] in-file [out-file]
...
~Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1] tools: ipxe: update for fixing build with GCC11
2021-06-16 12:33 ` Andrew Cooper
@ 2021-06-16 12:58 ` Olaf Hering
2021-06-16 13:33 ` Bernhard M. Wiedemann
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2021-06-16 12:58 UTC (permalink / raw)
To: Michael Brown, Bernhard M. Wiedemann
Cc: Andrew Cooper, xen-devel, Ian Jackson, Wei Liu
[-- Attachment #1: Type: text/plain, Size: 1803 bytes --]
Please revert bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e in ipxe.git, CentOS 7 apparently fails to handle '-D'.
It worked in my testing with SLE12SP5 and SLE15SP3 as a base system.
See below.
I guess for xen.git, updating to just bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e^ will be good enough.
Olaf
Am Wed, 16 Jun 2021 13:33:52 +0100
schrieb Andrew Cooper <andrew.cooper3@citrix.com>:
> On 15/06/2021 22:26, Olaf Hering wrote:
> > Use a snapshot which includes commit
> > f3f568e382a5f19824b3bfc6081cde39eee661e8 ("[crypto] Add
> > memory output constraints for big-integer inline assembly"),
> > which fixes build with gcc11.
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > ---
> > tools/firmware/etherboot/Makefile | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile
> > index ed9e11305f..23b3f6ca9d 100644
> > --- a/tools/firmware/etherboot/Makefile
> > +++ b/tools/firmware/etherboot/Makefile
> > @@ -10,7 +10,8 @@ else
> > IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
> > endif
> >
> > -IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c
> > +# put an updated tar.gz on xenbits after changes to this variable
> > +IPXE_GIT_TAG := bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e
>
> CI says no.
>
> Gitlab CI is currently fairly red because of a clang build fix which
> hasn't made its way into master yet, but this job:
>
> https://gitlab.com/xen-project/patchew/xen/-/jobs/1349871230
>
> shows a real failure on CentOS 7.
>
> ...
> [VERSION] bin/version.rtl8139.rom.o
> [AR] bin/blib.a
> ar: creating bin/blib.a
> objcopy: invalid option -- 'D'
> Usage: objcopy [option(s)] in-file [out-file]
> ...
>
> ~Andrew
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1] tools: ipxe: update for fixing build with GCC11
2021-06-16 12:58 ` Olaf Hering
@ 2021-06-16 13:33 ` Bernhard M. Wiedemann
2021-06-17 12:55 ` Michael Brown
0 siblings, 1 reply; 6+ messages in thread
From: Bernhard M. Wiedemann @ 2021-06-16 13:33 UTC (permalink / raw)
To: Olaf Hering, Michael Brown; +Cc: Andrew Cooper, xen-devel, Ian Jackson, Wei Liu
So this means, CentOS7 binutils has
9cb80f72d8b from 2011-12-21
but not
git blame binutils/objcopy.c|grep enable-determini
955d0b3bd75 (Roland McGrath 2013-01-07 17:40:59 +0000 549) -D
--enable-deterministic-archives\n\
2e30cb575a1 (Cary Coutant 2012-04-25 17:50:14 +0000 555) -D
--enable-deterministic-archives\n\
one way out could be to call objcopy -D $PARAMS || objcopy $PARAMS
On 16/06/2021 14.58, Olaf Hering wrote:
> Please revert bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e in ipxe.git, CentOS 7 apparently fails to handle '-D'.
>
> It worked in my testing with SLE12SP5 and SLE15SP3 as a base system.
>
> See below.
>
>
> I guess for xen.git, updating to just bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e^ will be good enough.
>
> Olaf
>
> Am Wed, 16 Jun 2021 13:33:52 +0100
> schrieb Andrew Cooper <andrew.cooper3@citrix.com>:
>
>> On 15/06/2021 22:26, Olaf Hering wrote:
>>> Use a snapshot which includes commit
>>> f3f568e382a5f19824b3bfc6081cde39eee661e8 ("[crypto] Add
>>> memory output constraints for big-integer inline assembly"),
>>> which fixes build with gcc11.
>>>
>>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>>> ---
>>> tools/firmware/etherboot/Makefile | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile
>>> index ed9e11305f..23b3f6ca9d 100644
>>> --- a/tools/firmware/etherboot/Makefile
>>> +++ b/tools/firmware/etherboot/Makefile
>>> @@ -10,7 +10,8 @@ else
>>> IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
>>> endif
>>>
>>> -IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c
>>> +# put an updated tar.gz on xenbits after changes to this variable
>>> +IPXE_GIT_TAG := bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e
>>
>> CI says no.
>>
>> Gitlab CI is currently fairly red because of a clang build fix which
>> hasn't made its way into master yet, but this job:
>>
>> https://gitlab.com/xen-project/patchew/xen/-/jobs/1349871230
>>
>> shows a real failure on CentOS 7.
>>
>> ...
>> [VERSION] bin/version.rtl8139.rom.o
>> [AR] bin/blib.a
>> ar: creating bin/blib.a
>> objcopy: invalid option -- 'D'
>> Usage: objcopy [option(s)] in-file [out-file]
>> ...
>>
>> ~Andrew
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1] tools: ipxe: update for fixing build with GCC11
2021-06-16 13:33 ` Bernhard M. Wiedemann
@ 2021-06-17 12:55 ` Michael Brown
2021-06-17 13:47 ` Michael Brown
0 siblings, 1 reply; 6+ messages in thread
From: Michael Brown @ 2021-06-17 12:55 UTC (permalink / raw)
To: Bernhard M. Wiedemann, Olaf Hering
Cc: Andrew Cooper, xen-devel, Ian Jackson, Wei Liu
On 16/06/2021 14:33, Bernhard M. Wiedemann wrote:
> So this means, CentOS7 binutils has
> 9cb80f72d8b from 2011-12-21
> but not
> git blame binutils/objcopy.c|grep enable-determini
> 955d0b3bd75 (Roland McGrath 2013-01-07 17:40:59 +0000 549) -D
> --enable-deterministic-archives\n\
> 2e30cb575a1 (Cary Coutant 2012-04-25 17:50:14 +0000 555) -D
> --enable-deterministic-archives\n\
>
> one way out could be to call objcopy -D $PARAMS || objcopy $PARAMS
Testing on a clean "centos:7" container shows that "objcopy -D" works as
expected (and "objcopy --help" shows the option as existing).
This container environment has /etc/centos-release showing:
CentOS Linux release 7.6.1810 (Core)
Could you provide a simple environment in which to reproduce the problem?
Thanks,
Michael
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] tools: ipxe: update for fixing build with GCC11
2021-06-17 12:55 ` Michael Brown
@ 2021-06-17 13:47 ` Michael Brown
0 siblings, 0 replies; 6+ messages in thread
From: Michael Brown @ 2021-06-17 13:47 UTC (permalink / raw)
To: Bernhard M. Wiedemann, Olaf Hering
Cc: Andrew Cooper, xen-devel, Ian Jackson, Wei Liu
On 17/06/2021 13:55, Michael Brown wrote:
>> one way out could be to call objcopy -D $PARAMS || objcopy $PARAMS
>
> Testing on a clean "centos:7" container shows that "objcopy -D" works as
> expected (and "objcopy --help" shows the option as existing).
>
> This container environment has /etc/centos-release showing:
>
> CentOS Linux release 7.6.1810 (Core)
>
> Could you provide a simple environment in which to reproduce the problem?
I've managed to reproduce it using "centos:7.0.1406". It should be
fixed in commit
https://github.com/ipxe/ipxe/commit/51c88a4a6
Thanks for the report!
Michael
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-17 13:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 21:26 [PATCH v1] tools: ipxe: update for fixing build with GCC11 Olaf Hering
2021-06-16 12:33 ` Andrew Cooper
2021-06-16 12:58 ` Olaf Hering
2021-06-16 13:33 ` Bernhard M. Wiedemann
2021-06-17 12:55 ` Michael Brown
2021-06-17 13:47 ` Michael Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.