* [PATCH] erofs-utils: correct the only tail-end data comment in __allocate_inode_bh_data()
@ 2021-06-16 8:01 Yue Hu
2021-06-16 12:54 ` Gao Xiang
0 siblings, 1 reply; 2+ messages in thread
From: Yue Hu @ 2021-06-16 8:01 UTC (permalink / raw)
To: linux-erofs, xiang; +Cc: huyue2, zbestahu
From: Yue Hu <huyue2@yulong.com>
nblocks = 0 means only tail-end data which may be inlined or not(ENOSPC).
Acturally, we also observed this non-inline tail-end data case.
Signed-off-by: Yue Hu <huyue2@yulong.com>
---
lib/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/inode.c b/lib/inode.c
index ca8952e..b6108db 100644
--- a/lib/inode.c
+++ b/lib/inode.c
@@ -119,7 +119,7 @@ static int __allocate_inode_bh_data(struct erofs_inode *inode,
int ret;
if (!nblocks) {
- /* it has only tail-end inlined data */
+ /* it has only tail-end data */
inode->u.i_blkaddr = NULL_ADDR;
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] erofs-utils: correct the only tail-end data comment in __allocate_inode_bh_data()
2021-06-16 8:01 [PATCH] erofs-utils: correct the only tail-end data comment in __allocate_inode_bh_data() Yue Hu
@ 2021-06-16 12:54 ` Gao Xiang
0 siblings, 0 replies; 2+ messages in thread
From: Gao Xiang @ 2021-06-16 12:54 UTC (permalink / raw)
To: Yue Hu; +Cc: zbestahu, huyue2, xiang, linux-erofs
On Wed, Jun 16, 2021 at 04:01:12PM +0800, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
>
> nblocks = 0 means only tail-end data which may be inlined or not(ENOSPC).
> Acturally, we also observed this non-inline tail-end data case.
>
> Signed-off-by: Yue Hu <huyue2@yulong.com>
Reviewed-by: Gao Xiang <xiang@kernel.org>
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-16 12:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 8:01 [PATCH] erofs-utils: correct the only tail-end data comment in __allocate_inode_bh_data() Yue Hu
2021-06-16 12:54 ` Gao Xiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.