[PATCH] audio: Fix format specifications of debug logs

[PATCH] audio: Fix format specifications of debug logs

[Akihiko Odaki]

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
---
 audio/audio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/audio/audio.c b/audio/audio.c
index 534278edfed..6eba208cdba 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -704,7 +704,7 @@ static size_t audio_pcm_sw_write(SWVoiceOut *sw, void *buf, size_t size)
 
     if (live == hwsamples) {
 #ifdef DEBUG_OUT
-        dolog ("%s is full %d\n", sw->name, live);
+        dolog ("%s is full %zu\n", sw->name, live);
 #endif
         return 0;
     }
@@ -994,7 +994,7 @@ static size_t audio_get_avail (SWVoiceIn *sw)
     }
 
     ldebug (
-        "%s: get_avail live %d ret %" PRId64 "\n",
+        "%s: get_avail live %zu ret %" PRId64 "\n",
         SW_NAME (sw),
         live, (((int64_t) live << 32) / sw->ratio) * sw->info.bytes_per_frame
         );
@@ -1021,7 +1021,7 @@ static size_t audio_get_free(SWVoiceOut *sw)
     dead = sw->hw->mix_buf->size - live;
 
 #ifdef DEBUG_OUT
-    dolog ("%s: get_free live %d dead %d ret %" PRId64 "\n",
+    dolog ("%s: get_free live %zu dead %zu ret %" PRId64 "\n",
            SW_NAME (sw),
            live, dead, (((int64_t) dead << 32) / sw->ratio) *
            sw->info.bytes_per_frame);
-- 
2.30.1 (Apple Git-130)

Re: [PATCH] audio: Fix format specifications of debug logs

[no-reply]

Patchew URL: https://patchew.org/QEMU/20210616141411.53892-1-akihiko.odaki@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210616141411.53892-1-akihiko.odaki@gmail.com
Subject: [PATCH] audio: Fix format specifications of debug logs

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   1ea06ab..1dd259a  master     -> master
 - [tag update]      patchew/20210609155551.44437-1-mreitz@redhat.com -> patchew/20210609155551.44437-1-mreitz@redhat.com
 - [tag update]      patchew/20210610133538.608390-1-pbonzini@redhat.com -> patchew/20210610133538.608390-1-pbonzini@redhat.com
 - [tag update]      patchew/20210614144245.17660-1-alex.bennee@linaro.org -> patchew/20210614144245.17660-1-alex.bennee@linaro.org
 - [tag update]      patchew/20210615175523.439830-1-peterx@redhat.com -> patchew/20210615175523.439830-1-peterx@redhat.com
 - [tag update]      patchew/20210616011209.1446045-1-richard.henderson@linaro.org -> patchew/20210616011209.1446045-1-richard.henderson@linaro.org
 * [new tag]         patchew/20210616141411.53892-1-akihiko.odaki@gmail.com -> patchew/20210616141411.53892-1-akihiko.odaki@gmail.com
Switched to a new branch 'test'
a5aeaae audio: Fix format specifications of debug logs

=== OUTPUT BEGIN ===
ERROR: space prohibited between function name and open parenthesis '('
#22: FILE: audio/audio.c:707:
+        dolog ("%s is full %zu\n", sw->name, live);

ERROR: space prohibited between function name and open parenthesis '('
#40: FILE: audio/audio.c:1024:
+    dolog ("%s: get_free live %zu dead %zu ret %" PRId64 "\n",

total: 2 errors, 0 warnings, 24 lines checked

Commit a5aeaae8bcc1 (audio: Fix format specifications of debug logs) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210616141411.53892-1-akihiko.odaki@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PATCH] audio: Fix format specifications of debug logs

[Gerd Hoffmann]

On Wed, Jun 16, 2021 at 11:14:11PM +0900, Akihiko Odaki wrote:
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
>  audio/audio.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/audio/audio.c b/audio/audio.c
> index 534278edfed..6eba208cdba 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -704,7 +704,7 @@ static size_t audio_pcm_sw_write(SWVoiceOut *sw, void *buf, size_t size)
>  
>      if (live == hwsamples) {
>  #ifdef DEBUG_OUT
> -        dolog ("%s is full %d\n", sw->name, live);
> +        dolog ("%s is full %zu\n", sw->name, live);
>  #endif
>          return 0;
>      }
> @@ -994,7 +994,7 @@ static size_t audio_get_avail (SWVoiceIn *sw)
>      }
>  
>      ldebug (
> -        "%s: get_avail live %d ret %" PRId64 "\n",
> +        "%s: get_avail live %zu ret %" PRId64 "\n",
>          SW_NAME (sw),
>          live, (((int64_t) live << 32) / sw->ratio) * sw->info.bytes_per_frame
>          );
> @@ -1021,7 +1021,7 @@ static size_t audio_get_free(SWVoiceOut *sw)
>      dead = sw->hw->mix_buf->size - live;
>  
>  #ifdef DEBUG_OUT
> -    dolog ("%s: get_free live %d dead %d ret %" PRId64 "\n",
> +    dolog ("%s: get_free live %zu dead %zu ret %" PRId64 "\n",
>             SW_NAME (sw),
>             live, dead, (((int64_t) dead << 32) / sw->ratio) *
>             sw->info.bytes_per_frame);

Added to audio queue.

thanks,
  Gerd