[PATCH] drm/amd/display: Increase stutter watermark for dcn302 and dcn303

[PATCH] drm/amd/display: Increase stutter watermark for dcn302 and dcn303

[Aurabindo Pillai]

[Why]
Current watermarks end up programming lowers watermarks which
results in screen flickering and underflow for certain modes like 1440p.

[How]
Add 11us to stutter exit & stutter enter plus exit watermark.

Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
 drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 4 ++--
 drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
index b16d19a25d88..628b227f0a13 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
@@ -164,8 +164,8 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_02_soc = {
 
 		.min_dcfclk = 500.0, /* TODO: set this to actual min DCFCLK */
 		.num_states = 1,
-		.sr_exit_time_us = 15.5,
-		.sr_enter_plus_exit_time_us = 20,
+		.sr_exit_time_us = 26.5,
+		.sr_enter_plus_exit_time_us = 31,
 		.urgent_latency_us = 4.0,
 		.urgent_latency_pixel_data_only_us = 4.0,
 		.urgent_latency_pixel_mixed_with_vm_data_us = 4.0,
diff --git a/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c b/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c
index 758f89ba0192..88b609c32b0a 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c
@@ -146,8 +146,8 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_03_soc = {
 
 		.min_dcfclk = 500.0, /* TODO: set this to actual min DCFCLK */
 		.num_states = 1,
-		.sr_exit_time_us = 15.5,
-		.sr_enter_plus_exit_time_us = 20,
+		.sr_exit_time_us = 26.5,
+		.sr_enter_plus_exit_time_us = 31,
 		.urgent_latency_us = 4.0,
 		.urgent_latency_pixel_data_only_us = 4.0,
 		.urgent_latency_pixel_mixed_with_vm_data_us = 4.0,
-- 
2.32.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/display: Increase stutter watermark for dcn302 and dcn303

[Rodrigo Siqueira]

[-- Attachment #1.1: Type: text/plain, Size: 2712 bytes --]

On 06/16, Aurabindo Pillai wrote:
> [Why]
> Current watermarks end up programming lowers watermarks which
> results in screen flickering and underflow for certain modes like 1440p.
> 
> [How]
> Add 11us to stutter exit & stutter enter plus exit watermark.
> 
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 4 ++--
>  drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
> index b16d19a25d88..628b227f0a13 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
> @@ -164,8 +164,8 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_02_soc = {
>  
>  		.min_dcfclk = 500.0, /* TODO: set this to actual min DCFCLK */
>  		.num_states = 1,
> -		.sr_exit_time_us = 15.5,
> -		.sr_enter_plus_exit_time_us = 20,
> +		.sr_exit_time_us = 26.5,
> +		.sr_enter_plus_exit_time_us = 31,
>  		.urgent_latency_us = 4.0,
>  		.urgent_latency_pixel_data_only_us = 4.0,
>  		.urgent_latency_pixel_mixed_with_vm_data_us = 4.0,
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c b/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c
> index 758f89ba0192..88b609c32b0a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c
> @@ -146,8 +146,8 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_03_soc = {
>  
>  		.min_dcfclk = 500.0, /* TODO: set this to actual min DCFCLK */
>  		.num_states = 1,
> -		.sr_exit_time_us = 15.5,
> -		.sr_enter_plus_exit_time_us = 20,
> +		.sr_exit_time_us = 26.5,
> +		.sr_enter_plus_exit_time_us = 31,

Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

>  		.urgent_latency_us = 4.0,
>  		.urgent_latency_pixel_data_only_us = 4.0,
>  		.urgent_latency_pixel_mixed_with_vm_data_us = 4.0,
> -- 
> 2.32.0
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7CRodrigo.Siqueira%40amd.com%7C80a7c82e99294a159f5e08d930d59d86%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637594516309239608%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=VgD4IVqXp5IMbFizvKTSwlFObtJ465nSX1hvWVKEnus%3D&amp;reserved=0

-- 
Rodrigo Siqueira
https://siqueira.tech

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx