From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: lvivier@redhat.com, thuth@redhat.com, philmd@redhat.com, mst@redhat.com
Subject: [RFC 0/3] qtest: pick tests that require KVM at runtime
Date: Wed, 16 Jun 2021 11:24:52 -0400 [thread overview]
Message-ID: <20210616152455.1270264-1-imammedo@redhat.com> (raw)
Sometimes it's necessary to execute a test that depends on KVM,
however qtest is not aware if tested QEMU binary supports KVM
on the host it the test is executed.
For an example:
test q35 machine with intel_iommu
This test will run only is KVM is available and fail
to start QEMU if it fallsback to TCG, thus failing whole test.
So if test is executed in VM where nested KVM is not enabled
or on other than x86 host, it will break 'make check-qtest'
Series adds a lightweight qtest_has_kvm() check, which abuses
build system and should help to avoid running KVM only tests
on hosts that do not support it.
PS:
there is an alternative 'query-accels' QMP command proposal
https://patchwork.kernel.org/project/qemu-devel/patch/20210503211020.894589-3-philmd@redhat.com/
which I think is more robust compared to qtest_has_kvm() and
could be extended to take into account machine type.
But it's more complex and what I dislike about it most,
it requires execution of 'probing' QEMU instance to find
execute 'query-accels' QMP command, which is rather resource
consuming. So I'd use query-accels approach only when it's
the only possible option to minimize load on CI systems.
Igor Mammedov (2):
tests: acpi: q35: test for x2APIC entries in SRAT
tests: acpi: update expected tables blobs
root (1):
tests: qtest: add qtest_has_kvm() to check if tested bynary supports
KVM
tests/qtest/libqos/libqtest.h | 7 +++++++
meson.build | 1 +
tests/data/acpi/q35/APIC.numamem | Bin 0 -> 2686 bytes
tests/data/acpi/q35/DSDT.numamem | Bin 7865 -> 35222 bytes
tests/data/acpi/q35/FACP.numamem | Bin 0 -> 244 bytes
tests/data/acpi/q35/SRAT.numamem | Bin 224 -> 5080 bytes
tests/qtest/bios-tables-test.c | 10 +++++++---
tests/qtest/libqtest.c | 20 ++++++++++++++++++++
8 files changed, 35 insertions(+), 3 deletions(-)
create mode 100644 tests/data/acpi/q35/APIC.numamem
create mode 100644 tests/data/acpi/q35/FACP.numamem
--
2.27.0
next reply other threads:[~2021-06-16 15:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 15:24 Igor Mammedov [this message]
2021-06-16 15:24 ` [RFC 1/3] tests: qtest: add qtest_has_kvm() to check if tested binary supports KVM Igor Mammedov
2021-06-17 10:00 ` [RFC v2 " Igor Mammedov
2021-06-17 16:28 ` Igor Mammedov
2021-06-16 15:24 ` [RFC 2/3] tests: acpi: q35: test for x2APIC entries in SRAT Igor Mammedov
2021-06-16 15:24 ` [RFC 3/3] tests: acpi: update expected tables blobs Igor Mammedov
2021-06-16 15:30 ` [RFC 0/3] qtest: pick tests that require KVM at runtime no-reply
2021-06-17 16:49 ` Claudio Fontana
2021-06-18 11:26 ` Igor Mammedov
2021-06-18 12:43 ` Claudio Fontana
2021-06-18 13:29 ` Igor Mammedov
2021-06-22 8:07 ` Alex Bennée
2021-06-22 8:22 ` Philippe Mathieu-Daudé
2021-06-22 10:36 ` Igor Mammedov
2021-06-22 11:27 ` Philippe Mathieu-Daudé
2021-06-18 15:58 ` Igor Mammedov
2021-06-22 6:58 ` Claudio Fontana
2021-06-22 7:20 ` Thomas Huth
2021-06-22 7:26 ` Philippe Mathieu-Daudé
2021-06-22 7:59 ` Thomas Huth
2021-06-22 10:54 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616152455.1270264-1-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.