All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/net/ethernet/broadcom/bnxt/bnxt.c:7654 bnxt_accumulate_all_stats() error: potentially dereferencing uninitialized 'ring0_stats'.
@ 2021-06-16 18:42 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-06-16 18:42 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 4714 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Michael Chan <michael.chan@broadcom.com>
CC: Vasundhara Volam <vasundhara-v.volam@broadcom.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   6b00bc639f1f2beeff3595e1bab9faaa51d23b01
commit: fea6b3335527f41bc729466fb2a95e48a98827ac bnxt_en: Accumulate all counters.
date:   11 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 11 months ago
config: x86_64-randconfig-m001-20210616 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/net/ethernet/broadcom/bnxt/bnxt.c:7654 bnxt_accumulate_all_stats() error: potentially dereferencing uninitialized 'ring0_stats'.

Old smatch warnings:
drivers/net/ethernet/broadcom/bnxt/bnxt.c:12283 bnxt_init_one() warn: missing error code 'rc'

vim +/ring0_stats +7654 drivers/net/ethernet/broadcom/bnxt/bnxt.c

fea6b3335527f4 Michael Chan 2020-07-27  7633  
fea6b3335527f4 Michael Chan 2020-07-27  7634  static void bnxt_accumulate_all_stats(struct bnxt *bp)
fea6b3335527f4 Michael Chan 2020-07-27  7635  {
fea6b3335527f4 Michael Chan 2020-07-27  7636  	struct bnxt_stats_mem *ring0_stats;
fea6b3335527f4 Michael Chan 2020-07-27  7637  	bool ignore_zero = false;
fea6b3335527f4 Michael Chan 2020-07-27  7638  	int i;
fea6b3335527f4 Michael Chan 2020-07-27  7639  
fea6b3335527f4 Michael Chan 2020-07-27  7640  	/* Chip bug.  Counter intermittently becomes 0. */
fea6b3335527f4 Michael Chan 2020-07-27  7641  	if (bp->flags & BNXT_FLAG_CHIP_P5)
fea6b3335527f4 Michael Chan 2020-07-27  7642  		ignore_zero = true;
fea6b3335527f4 Michael Chan 2020-07-27  7643  
fea6b3335527f4 Michael Chan 2020-07-27  7644  	for (i = 0; i < bp->cp_nr_rings; i++) {
fea6b3335527f4 Michael Chan 2020-07-27  7645  		struct bnxt_napi *bnapi = bp->bnapi[i];
fea6b3335527f4 Michael Chan 2020-07-27  7646  		struct bnxt_cp_ring_info *cpr;
fea6b3335527f4 Michael Chan 2020-07-27  7647  		struct bnxt_stats_mem *stats;
fea6b3335527f4 Michael Chan 2020-07-27  7648  
fea6b3335527f4 Michael Chan 2020-07-27  7649  		cpr = &bnapi->cp_ring;
fea6b3335527f4 Michael Chan 2020-07-27  7650  		stats = &cpr->stats;
fea6b3335527f4 Michael Chan 2020-07-27  7651  		if (!i)
fea6b3335527f4 Michael Chan 2020-07-27  7652  			ring0_stats = stats;
fea6b3335527f4 Michael Chan 2020-07-27  7653  		__bnxt_accumulate_stats(stats->hw_stats, stats->sw_stats,
fea6b3335527f4 Michael Chan 2020-07-27 @7654  					ring0_stats->hw_masks,
fea6b3335527f4 Michael Chan 2020-07-27  7655  					ring0_stats->len / 8, ignore_zero);
fea6b3335527f4 Michael Chan 2020-07-27  7656  	}
fea6b3335527f4 Michael Chan 2020-07-27  7657  	if (bp->flags & BNXT_FLAG_PORT_STATS) {
fea6b3335527f4 Michael Chan 2020-07-27  7658  		struct bnxt_stats_mem *stats = &bp->port_stats;
fea6b3335527f4 Michael Chan 2020-07-27  7659  		__le64 *hw_stats = stats->hw_stats;
fea6b3335527f4 Michael Chan 2020-07-27  7660  		u64 *sw_stats = stats->sw_stats;
fea6b3335527f4 Michael Chan 2020-07-27  7661  		u64 *masks = stats->hw_masks;
fea6b3335527f4 Michael Chan 2020-07-27  7662  		int cnt;
fea6b3335527f4 Michael Chan 2020-07-27  7663  
fea6b3335527f4 Michael Chan 2020-07-27  7664  		cnt = sizeof(struct rx_port_stats) / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7665  		__bnxt_accumulate_stats(hw_stats, sw_stats, masks, cnt, false);
fea6b3335527f4 Michael Chan 2020-07-27  7666  
fea6b3335527f4 Michael Chan 2020-07-27  7667  		hw_stats += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7668  		sw_stats += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7669  		masks += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7670  		cnt = sizeof(struct tx_port_stats) / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7671  		__bnxt_accumulate_stats(hw_stats, sw_stats, masks, cnt, false);
fea6b3335527f4 Michael Chan 2020-07-27  7672  	}
fea6b3335527f4 Michael Chan 2020-07-27  7673  	if (bp->flags & BNXT_FLAG_PORT_STATS_EXT) {
fea6b3335527f4 Michael Chan 2020-07-27  7674  		bnxt_accumulate_stats(&bp->rx_port_stats_ext);
fea6b3335527f4 Michael Chan 2020-07-27  7675  		bnxt_accumulate_stats(&bp->tx_port_stats_ext);
fea6b3335527f4 Michael Chan 2020-07-27  7676  	}
fea6b3335527f4 Michael Chan 2020-07-27  7677  }
fea6b3335527f4 Michael Chan 2020-07-27  7678  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33621 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* drivers/net/ethernet/broadcom/bnxt/bnxt.c:7654 bnxt_accumulate_all_stats() error: potentially dereferencing uninitialized 'ring0_stats'.
@ 2023-11-12 20:54 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-11-12 20:54 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Michael Chan <michael.chan@broadcom.com>
CC: Vasundhara Volam <vasundhara-v.volam@broadcom.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e257da5715365b853439243f89cf5d8a9d382355
commit: fea6b3335527f41bc729466fb2a95e48a98827ac bnxt_en: Accumulate all counters.
date:   3 years, 4 months ago
:::::: branch date: 67 minutes ago
:::::: commit date: 3 years, 4 months ago
config: i386-randconfig-141-20230912 (https://download.01.org/0day-ci/archive/20231113/202311130439.ZGMx2oxn-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231113/202311130439.ZGMx2oxn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202311130439.ZGMx2oxn-lkp@intel.com/

New smatch warnings:
drivers/net/ethernet/broadcom/bnxt/bnxt.c:7654 bnxt_accumulate_all_stats() error: potentially dereferencing uninitialized 'ring0_stats'.

Old smatch warnings:
drivers/net/ethernet/broadcom/bnxt/bnxt.c:8600 bnxt_request_irq() warn: 'irq->vector' from request_irq() not released on lines: 8600.
drivers/net/ethernet/broadcom/bnxt/bnxt.c:11208 bnxt_init_board() warn: missing error code 'rc'
drivers/net/ethernet/broadcom/bnxt/bnxt.c:12283 bnxt_init_one() warn: missing error code 'rc'

vim +/ring0_stats +7654 drivers/net/ethernet/broadcom/bnxt/bnxt.c

fea6b3335527f41b Michael Chan 2020-07-27  7633  
fea6b3335527f41b Michael Chan 2020-07-27  7634  static void bnxt_accumulate_all_stats(struct bnxt *bp)
fea6b3335527f41b Michael Chan 2020-07-27  7635  {
fea6b3335527f41b Michael Chan 2020-07-27  7636  	struct bnxt_stats_mem *ring0_stats;
fea6b3335527f41b Michael Chan 2020-07-27  7637  	bool ignore_zero = false;
fea6b3335527f41b Michael Chan 2020-07-27  7638  	int i;
fea6b3335527f41b Michael Chan 2020-07-27  7639  
fea6b3335527f41b Michael Chan 2020-07-27  7640  	/* Chip bug.  Counter intermittently becomes 0. */
fea6b3335527f41b Michael Chan 2020-07-27  7641  	if (bp->flags & BNXT_FLAG_CHIP_P5)
fea6b3335527f41b Michael Chan 2020-07-27  7642  		ignore_zero = true;
fea6b3335527f41b Michael Chan 2020-07-27  7643  
fea6b3335527f41b Michael Chan 2020-07-27  7644  	for (i = 0; i < bp->cp_nr_rings; i++) {
fea6b3335527f41b Michael Chan 2020-07-27  7645  		struct bnxt_napi *bnapi = bp->bnapi[i];
fea6b3335527f41b Michael Chan 2020-07-27  7646  		struct bnxt_cp_ring_info *cpr;
fea6b3335527f41b Michael Chan 2020-07-27  7647  		struct bnxt_stats_mem *stats;
fea6b3335527f41b Michael Chan 2020-07-27  7648  
fea6b3335527f41b Michael Chan 2020-07-27  7649  		cpr = &bnapi->cp_ring;
fea6b3335527f41b Michael Chan 2020-07-27  7650  		stats = &cpr->stats;
fea6b3335527f41b Michael Chan 2020-07-27  7651  		if (!i)
fea6b3335527f41b Michael Chan 2020-07-27  7652  			ring0_stats = stats;
fea6b3335527f41b Michael Chan 2020-07-27  7653  		__bnxt_accumulate_stats(stats->hw_stats, stats->sw_stats,
fea6b3335527f41b Michael Chan 2020-07-27 @7654  					ring0_stats->hw_masks,
fea6b3335527f41b Michael Chan 2020-07-27  7655  					ring0_stats->len / 8, ignore_zero);
fea6b3335527f41b Michael Chan 2020-07-27  7656  	}
fea6b3335527f41b Michael Chan 2020-07-27  7657  	if (bp->flags & BNXT_FLAG_PORT_STATS) {
fea6b3335527f41b Michael Chan 2020-07-27  7658  		struct bnxt_stats_mem *stats = &bp->port_stats;
fea6b3335527f41b Michael Chan 2020-07-27  7659  		__le64 *hw_stats = stats->hw_stats;
fea6b3335527f41b Michael Chan 2020-07-27  7660  		u64 *sw_stats = stats->sw_stats;
fea6b3335527f41b Michael Chan 2020-07-27  7661  		u64 *masks = stats->hw_masks;
fea6b3335527f41b Michael Chan 2020-07-27  7662  		int cnt;
fea6b3335527f41b Michael Chan 2020-07-27  7663  
fea6b3335527f41b Michael Chan 2020-07-27  7664  		cnt = sizeof(struct rx_port_stats) / 8;
fea6b3335527f41b Michael Chan 2020-07-27  7665  		__bnxt_accumulate_stats(hw_stats, sw_stats, masks, cnt, false);
fea6b3335527f41b Michael Chan 2020-07-27  7666  
fea6b3335527f41b Michael Chan 2020-07-27  7667  		hw_stats += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8;
fea6b3335527f41b Michael Chan 2020-07-27  7668  		sw_stats += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8;
fea6b3335527f41b Michael Chan 2020-07-27  7669  		masks += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8;
fea6b3335527f41b Michael Chan 2020-07-27  7670  		cnt = sizeof(struct tx_port_stats) / 8;
fea6b3335527f41b Michael Chan 2020-07-27  7671  		__bnxt_accumulate_stats(hw_stats, sw_stats, masks, cnt, false);
fea6b3335527f41b Michael Chan 2020-07-27  7672  	}
fea6b3335527f41b Michael Chan 2020-07-27  7673  	if (bp->flags & BNXT_FLAG_PORT_STATS_EXT) {
fea6b3335527f41b Michael Chan 2020-07-27  7674  		bnxt_accumulate_stats(&bp->rx_port_stats_ext);
fea6b3335527f41b Michael Chan 2020-07-27  7675  		bnxt_accumulate_stats(&bp->tx_port_stats_ext);
fea6b3335527f41b Michael Chan 2020-07-27  7676  	}
fea6b3335527f41b Michael Chan 2020-07-27  7677  }
fea6b3335527f41b Michael Chan 2020-07-27  7678  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 4+ messages in thread

* drivers/net/ethernet/broadcom/bnxt/bnxt.c:7654 bnxt_accumulate_all_stats() error: potentially dereferencing uninitialized 'ring0_stats'.
@ 2021-07-05  7:14 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-07-05  7:14 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 4931 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Michael Chan <michael.chan@broadcom.com>
CC: Vasundhara Volam <vasundhara-v.volam@broadcom.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a180bd1d7e16173d965b263c5a536aa40afa2a2a
commit: fea6b3335527f41bc729466fb2a95e48a98827ac bnxt_en: Accumulate all counters.
date:   11 months ago
:::::: branch date: 8 hours ago
:::::: commit date: 11 months ago
config: parisc-randconfig-m031-20210705 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/net/ethernet/broadcom/bnxt/bnxt.c:7654 bnxt_accumulate_all_stats() error: potentially dereferencing uninitialized 'ring0_stats'.

Old smatch warnings:
drivers/net/ethernet/broadcom/bnxt/bnxt.c:1539 bnxt_tpa_end() warn: bitwise AND condition is false here
drivers/net/ethernet/broadcom/bnxt/bnxt.c:4876 bnxt_hwrm_vnic_set_tpa() warn: bitwise AND condition is false here
drivers/net/ethernet/broadcom/bnxt/bnxt.c:12283 bnxt_init_one() warn: missing error code 'rc'

vim +/ring0_stats +7654 drivers/net/ethernet/broadcom/bnxt/bnxt.c

fea6b3335527f4 Michael Chan 2020-07-27  7633  
fea6b3335527f4 Michael Chan 2020-07-27  7634  static void bnxt_accumulate_all_stats(struct bnxt *bp)
fea6b3335527f4 Michael Chan 2020-07-27  7635  {
fea6b3335527f4 Michael Chan 2020-07-27  7636  	struct bnxt_stats_mem *ring0_stats;
fea6b3335527f4 Michael Chan 2020-07-27  7637  	bool ignore_zero = false;
fea6b3335527f4 Michael Chan 2020-07-27  7638  	int i;
fea6b3335527f4 Michael Chan 2020-07-27  7639  
fea6b3335527f4 Michael Chan 2020-07-27  7640  	/* Chip bug.  Counter intermittently becomes 0. */
fea6b3335527f4 Michael Chan 2020-07-27  7641  	if (bp->flags & BNXT_FLAG_CHIP_P5)
fea6b3335527f4 Michael Chan 2020-07-27  7642  		ignore_zero = true;
fea6b3335527f4 Michael Chan 2020-07-27  7643  
fea6b3335527f4 Michael Chan 2020-07-27  7644  	for (i = 0; i < bp->cp_nr_rings; i++) {
fea6b3335527f4 Michael Chan 2020-07-27  7645  		struct bnxt_napi *bnapi = bp->bnapi[i];
fea6b3335527f4 Michael Chan 2020-07-27  7646  		struct bnxt_cp_ring_info *cpr;
fea6b3335527f4 Michael Chan 2020-07-27  7647  		struct bnxt_stats_mem *stats;
fea6b3335527f4 Michael Chan 2020-07-27  7648  
fea6b3335527f4 Michael Chan 2020-07-27  7649  		cpr = &bnapi->cp_ring;
fea6b3335527f4 Michael Chan 2020-07-27  7650  		stats = &cpr->stats;
fea6b3335527f4 Michael Chan 2020-07-27  7651  		if (!i)
fea6b3335527f4 Michael Chan 2020-07-27  7652  			ring0_stats = stats;
fea6b3335527f4 Michael Chan 2020-07-27  7653  		__bnxt_accumulate_stats(stats->hw_stats, stats->sw_stats,
fea6b3335527f4 Michael Chan 2020-07-27 @7654  					ring0_stats->hw_masks,
fea6b3335527f4 Michael Chan 2020-07-27  7655  					ring0_stats->len / 8, ignore_zero);
fea6b3335527f4 Michael Chan 2020-07-27  7656  	}
fea6b3335527f4 Michael Chan 2020-07-27  7657  	if (bp->flags & BNXT_FLAG_PORT_STATS) {
fea6b3335527f4 Michael Chan 2020-07-27  7658  		struct bnxt_stats_mem *stats = &bp->port_stats;
fea6b3335527f4 Michael Chan 2020-07-27  7659  		__le64 *hw_stats = stats->hw_stats;
fea6b3335527f4 Michael Chan 2020-07-27  7660  		u64 *sw_stats = stats->sw_stats;
fea6b3335527f4 Michael Chan 2020-07-27  7661  		u64 *masks = stats->hw_masks;
fea6b3335527f4 Michael Chan 2020-07-27  7662  		int cnt;
fea6b3335527f4 Michael Chan 2020-07-27  7663  
fea6b3335527f4 Michael Chan 2020-07-27  7664  		cnt = sizeof(struct rx_port_stats) / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7665  		__bnxt_accumulate_stats(hw_stats, sw_stats, masks, cnt, false);
fea6b3335527f4 Michael Chan 2020-07-27  7666  
fea6b3335527f4 Michael Chan 2020-07-27  7667  		hw_stats += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7668  		sw_stats += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7669  		masks += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7670  		cnt = sizeof(struct tx_port_stats) / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7671  		__bnxt_accumulate_stats(hw_stats, sw_stats, masks, cnt, false);
fea6b3335527f4 Michael Chan 2020-07-27  7672  	}
fea6b3335527f4 Michael Chan 2020-07-27  7673  	if (bp->flags & BNXT_FLAG_PORT_STATS_EXT) {
fea6b3335527f4 Michael Chan 2020-07-27  7674  		bnxt_accumulate_stats(&bp->rx_port_stats_ext);
fea6b3335527f4 Michael Chan 2020-07-27  7675  		bnxt_accumulate_stats(&bp->tx_port_stats_ext);
fea6b3335527f4 Michael Chan 2020-07-27  7676  	}
fea6b3335527f4 Michael Chan 2020-07-27  7677  }
fea6b3335527f4 Michael Chan 2020-07-27  7678  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31067 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* drivers/net/ethernet/broadcom/bnxt/bnxt.c:7654 bnxt_accumulate_all_stats() error: potentially dereferencing uninitialized 'ring0_stats'.
@ 2021-04-05  7:27 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-04-05  7:27 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 4940 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Michael Chan <michael.chan@broadcom.com>
CC: Vasundhara Volam <vasundhara-v.volam@broadcom.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e49d033bddf5b565044e2abe4241353959bc9120
commit: fea6b3335527f41bc729466fb2a95e48a98827ac bnxt_en: Accumulate all counters.
date:   8 months ago
:::::: branch date: 10 hours ago
:::::: commit date: 8 months ago
config: microblaze-randconfig-m031-20210405 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/net/ethernet/broadcom/bnxt/bnxt.c:7654 bnxt_accumulate_all_stats() error: potentially dereferencing uninitialized 'ring0_stats'.

Old smatch warnings:
drivers/net/ethernet/broadcom/bnxt/bnxt.c:1539 bnxt_tpa_end() warn: bitwise AND condition is false here
drivers/net/ethernet/broadcom/bnxt/bnxt.c:4876 bnxt_hwrm_vnic_set_tpa() warn: bitwise AND condition is false here
drivers/net/ethernet/broadcom/bnxt/bnxt.c:12283 bnxt_init_one() warn: missing error code 'rc'

vim +/ring0_stats +7654 drivers/net/ethernet/broadcom/bnxt/bnxt.c

fea6b3335527f4 Michael Chan 2020-07-27  7633  
fea6b3335527f4 Michael Chan 2020-07-27  7634  static void bnxt_accumulate_all_stats(struct bnxt *bp)
fea6b3335527f4 Michael Chan 2020-07-27  7635  {
fea6b3335527f4 Michael Chan 2020-07-27  7636  	struct bnxt_stats_mem *ring0_stats;
fea6b3335527f4 Michael Chan 2020-07-27  7637  	bool ignore_zero = false;
fea6b3335527f4 Michael Chan 2020-07-27  7638  	int i;
fea6b3335527f4 Michael Chan 2020-07-27  7639  
fea6b3335527f4 Michael Chan 2020-07-27  7640  	/* Chip bug.  Counter intermittently becomes 0. */
fea6b3335527f4 Michael Chan 2020-07-27  7641  	if (bp->flags & BNXT_FLAG_CHIP_P5)
fea6b3335527f4 Michael Chan 2020-07-27  7642  		ignore_zero = true;
fea6b3335527f4 Michael Chan 2020-07-27  7643  
fea6b3335527f4 Michael Chan 2020-07-27  7644  	for (i = 0; i < bp->cp_nr_rings; i++) {
fea6b3335527f4 Michael Chan 2020-07-27  7645  		struct bnxt_napi *bnapi = bp->bnapi[i];
fea6b3335527f4 Michael Chan 2020-07-27  7646  		struct bnxt_cp_ring_info *cpr;
fea6b3335527f4 Michael Chan 2020-07-27  7647  		struct bnxt_stats_mem *stats;
fea6b3335527f4 Michael Chan 2020-07-27  7648  
fea6b3335527f4 Michael Chan 2020-07-27  7649  		cpr = &bnapi->cp_ring;
fea6b3335527f4 Michael Chan 2020-07-27  7650  		stats = &cpr->stats;
fea6b3335527f4 Michael Chan 2020-07-27  7651  		if (!i)
fea6b3335527f4 Michael Chan 2020-07-27  7652  			ring0_stats = stats;
fea6b3335527f4 Michael Chan 2020-07-27  7653  		__bnxt_accumulate_stats(stats->hw_stats, stats->sw_stats,
fea6b3335527f4 Michael Chan 2020-07-27 @7654  					ring0_stats->hw_masks,
fea6b3335527f4 Michael Chan 2020-07-27  7655  					ring0_stats->len / 8, ignore_zero);
fea6b3335527f4 Michael Chan 2020-07-27  7656  	}
fea6b3335527f4 Michael Chan 2020-07-27  7657  	if (bp->flags & BNXT_FLAG_PORT_STATS) {
fea6b3335527f4 Michael Chan 2020-07-27  7658  		struct bnxt_stats_mem *stats = &bp->port_stats;
fea6b3335527f4 Michael Chan 2020-07-27  7659  		__le64 *hw_stats = stats->hw_stats;
fea6b3335527f4 Michael Chan 2020-07-27  7660  		u64 *sw_stats = stats->sw_stats;
fea6b3335527f4 Michael Chan 2020-07-27  7661  		u64 *masks = stats->hw_masks;
fea6b3335527f4 Michael Chan 2020-07-27  7662  		int cnt;
fea6b3335527f4 Michael Chan 2020-07-27  7663  
fea6b3335527f4 Michael Chan 2020-07-27  7664  		cnt = sizeof(struct rx_port_stats) / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7665  		__bnxt_accumulate_stats(hw_stats, sw_stats, masks, cnt, false);
fea6b3335527f4 Michael Chan 2020-07-27  7666  
fea6b3335527f4 Michael Chan 2020-07-27  7667  		hw_stats += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7668  		sw_stats += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7669  		masks += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7670  		cnt = sizeof(struct tx_port_stats) / 8;
fea6b3335527f4 Michael Chan 2020-07-27  7671  		__bnxt_accumulate_stats(hw_stats, sw_stats, masks, cnt, false);
fea6b3335527f4 Michael Chan 2020-07-27  7672  	}
fea6b3335527f4 Michael Chan 2020-07-27  7673  	if (bp->flags & BNXT_FLAG_PORT_STATS_EXT) {
fea6b3335527f4 Michael Chan 2020-07-27  7674  		bnxt_accumulate_stats(&bp->rx_port_stats_ext);
fea6b3335527f4 Michael Chan 2020-07-27  7675  		bnxt_accumulate_stats(&bp->tx_port_stats_ext);
fea6b3335527f4 Michael Chan 2020-07-27  7676  	}
fea6b3335527f4 Michael Chan 2020-07-27  7677  }
fea6b3335527f4 Michael Chan 2020-07-27  7678  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27483 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-11-12 20:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 18:42 drivers/net/ethernet/broadcom/bnxt/bnxt.c:7654 bnxt_accumulate_all_stats() error: potentially dereferencing uninitialized 'ring0_stats' kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2023-11-12 20:54 kernel test robot
2021-07-05  7:14 kernel test robot
2021-04-05  7:27 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.