Re: [PATCH] cfg80211: expose the rfkill device to the low level driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 7596 bytes --]

Hi Emmanuel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mac80211-next/master]
[also build test ERROR on mac80211/master v5.13-rc6 next-20210616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Emmanuel-Grumbach/cfg80211-expose-the-rfkill-device-to-the-low-level-driver/20210616-211511
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: ia64-randconfig-r015-20210615 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8b25a459eed15aebc25c2ce0a5bf20fea8eab638
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Emmanuel-Grumbach/cfg80211-expose-the-rfkill-device-to-the-low-level-driver/20210616-211511
        git checkout 8b25a459eed15aebc25c2ce0a5bf20fea8eab638
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from drivers/net/wireless/intel/ipw2x00/libipw.h:30,
                    from drivers/net/wireless/intel/ipw2x00/ipw2100.h:35,
                    from drivers/net/wireless/intel/ipw2x00/ipw2100.c:154:
   include/net/cfg80211.h: In function 'wiphy_rfkill_stop_polling':
>> include/net/cfg80211.h:6669:2: error: implicit declaration of function 'rfkill_pause_polling' [-Werror=implicit-function-declaration]
    6669 |  rfkill_pause_polling(wiphy->rfkill);
         |  ^~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/intel/ipw2x00/ipw2100.c: In function 'isr_indicate_associated':
   drivers/net/wireless/intel/ipw2x00/ipw2100.c:1992:8: warning: variable 'txratename' set but not used [-Wunused-but-set-variable]
    1992 |  char *txratename;
         |        ^~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from drivers/net/wireless/intel/ipw2x00/libipw.h:30,
                    from drivers/net/wireless/intel/ipw2x00/ipw2200.h:42,
                    from drivers/net/wireless/intel/ipw2x00/ipw2200.c:22:
   include/net/cfg80211.h: In function 'wiphy_rfkill_stop_polling':
>> include/net/cfg80211.h:6669:2: error: implicit declaration of function 'rfkill_pause_polling' [-Werror=implicit-function-declaration]
    6669 |  rfkill_pause_polling(wiphy->rfkill);
         |  ^~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/intel/ipw2x00/ipw2200.c: In function 'ipw_fw_dma_dump_command_block':
   drivers/net/wireless/intel/ipw2x00/ipw2200.c:2822:6: warning: variable 'register_value' set but not used [-Wunused-but-set-variable]
    2822 |  u32 register_value = 0;
         |      ^~~~~~~~~~~~~~
   drivers/net/wireless/intel/ipw2x00/ipw2200.c: In function 'ipw_is_qos_active':
   drivers/net/wireless/intel/ipw2x00/ipw2200.c:7154:14: warning: variable 'supported' set but not used [-Wunused-but-set-variable]
    7154 |  int active, supported;
         |              ^~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from drivers/net/wireless/intel/ipw2x00/libipw.h:30,
                    from drivers/net/wireless/intel/ipw2x00/libipw_module.c:39:
   include/net/cfg80211.h: In function 'wiphy_rfkill_stop_polling':
>> include/net/cfg80211.h:6669:2: error: implicit declaration of function 'rfkill_pause_polling' [-Werror=implicit-function-declaration]
    6669 |  rfkill_pause_polling(wiphy->rfkill);
         |  ^~~~~~~~~~~~~~~~~~~~
   At top level:
   drivers/net/wireless/intel/ipw2x00/libipw_module.c:243:30: warning: 'debug_level_proc_ops' defined but not used [-Wunused-const-variable=]
     243 | static const struct proc_ops debug_level_proc_ops = {
         |                              ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from drivers/net/wireless/intel/ipw2x00/libipw.h:30,
                    from drivers/net/wireless/intel/ipw2x00/libipw_tx.c:30:
   include/net/cfg80211.h: In function 'wiphy_rfkill_stop_polling':
>> include/net/cfg80211.h:6669:2: error: implicit declaration of function 'rfkill_pause_polling' [-Werror=implicit-function-declaration]
    6669 |  rfkill_pause_polling(wiphy->rfkill);
         |  ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from net/wireless/core.c:26:
   include/net/cfg80211.h: In function 'wiphy_rfkill_stop_polling':
>> include/net/cfg80211.h:6669:2: error: implicit declaration of function 'rfkill_pause_polling' [-Werror=implicit-function-declaration]
    6669 |  rfkill_pause_polling(wiphy->rfkill);
         |  ^~~~~~~~~~~~~~~~~~~~
   In file included from net/wireless/core.h:14,
                    from net/wireless/nl80211.h:9,
                    from net/wireless/core.c:27:
   include/linux/rfkill.h: At top level:
>> include/linux/rfkill.h:110:6: warning: conflicting types for 'rfkill_pause_polling'
     110 | void rfkill_pause_polling(struct rfkill *rfkill);
         |      ^~~~~~~~~~~~~~~~~~~~
   In file included from net/wireless/core.c:26:
   include/net/cfg80211.h:6669:2: note: previous implicit declaration of 'rfkill_pause_polling' was here
    6669 |  rfkill_pause_polling(wiphy->rfkill);
         |  ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from net/wireless/trace.h:12,
                    from net/wireless/trace.c:5:
   include/net/cfg80211.h: In function 'wiphy_rfkill_stop_polling':
>> include/net/cfg80211.h:6669:2: error: implicit declaration of function 'rfkill_pause_polling' [-Werror=implicit-function-declaration]
    6669 |  rfkill_pause_polling(wiphy->rfkill);
         |  ^~~~~~~~~~~~~~~~~~~~
   In file included from net/wireless/core.h:14,
                    from net/wireless/trace.h:13,
                    from net/wireless/trace.c:5:
   include/linux/rfkill.h: At top level:
>> include/linux/rfkill.h:110:6: warning: conflicting types for 'rfkill_pause_polling'
     110 | void rfkill_pause_polling(struct rfkill *rfkill);
         |      ^~~~~~~~~~~~~~~~~~~~
   In file included from net/wireless/trace.h:12,
                    from net/wireless/trace.c:5:
   include/net/cfg80211.h:6669:2: note: previous implicit declaration of 'rfkill_pause_polling' was here
    6669 |  rfkill_pause_polling(wiphy->rfkill);
         |  ^~~~~~~~~~~~~~~~~~~~
   In file included from net/wireless/trace.h:3574,
                    from net/wireless/trace.c:5:
   include/trace/define_trace.h:95:42: fatal error: ./trace.h: No such file or directory
      95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
         |                                          ^
   cc1: some warnings being treated as errors
   compilation terminated.


vim +/rfkill_pause_polling +6669 include/net/cfg80211.h

  6662	
  6663	/**
  6664	 * wiphy_rfkill_stop_polling - stop polling rfkill
  6665	 * @wiphy: the wiphy
  6666	 */
  6667	static inline void wiphy_rfkill_stop_polling(struct wiphy *wiphy)
  6668	{
> 6669		rfkill_pause_polling(wiphy->rfkill);
  6670	}
  6671	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37722 bytes --]