* [PATCH 1/2] ASoC: rt711: remap buttons @ 2021-06-17 9:08 shumingf 2021-06-17 12:39 ` Mark Brown 0 siblings, 1 reply; 9+ messages in thread From: shumingf @ 2021-06-17 9:08 UTC (permalink / raw) To: broonie, lgirdwood Cc: oder_chiou, jack.yu, alsa-devel, lars, Shuming Fan, jairaj.arava, derek.fang, bard.liao, sathya.prakash.m.r, flove From: Shuming Fan <shumingf@realtek.com> This patch uses the same mapping as the machine driver: BTN_0 : KEY_PLAYPAUSE BTN_1 : KEY_VOICECOMMAND BTN_2 : KEY_VOLUMEUP BTN_3 : KEY_VOLUMEDOWN Signed-off-by: Shuming Fan <shumingf@realtek.com> --- sound/soc/codecs/rt711.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt711.c b/sound/soc/codecs/rt711.c index 9f5b2dc16c54..c3a82b462a93 100644 --- a/sound/soc/codecs/rt711.c +++ b/sound/soc/codecs/rt711.c @@ -154,26 +154,26 @@ static unsigned int rt711_button_detect(struct rt711_priv *rt711) case 0x0200: case 0x0100: case 0x0080: - btn_type |= SND_JACK_BTN_0; + btn_type |= SND_JACK_BTN_2; break; case 0x0001: - btn_type |= SND_JACK_BTN_3; + btn_type |= SND_JACK_BTN_1; break; } switch (val81) { case 0x8000: case 0x4000: case 0x2000: - btn_type |= SND_JACK_BTN_1; + btn_type |= SND_JACK_BTN_0; break; case 0x1000: case 0x0800: case 0x0400: - btn_type |= SND_JACK_BTN_2; + btn_type |= SND_JACK_BTN_3; break; case 0x0200: case 0x0100: - btn_type |= SND_JACK_BTN_3; + btn_type |= SND_JACK_BTN_1; break; } read_error: -- 2.31.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ASoC: rt711: remap buttons 2021-06-17 9:08 [PATCH 1/2] ASoC: rt711: remap buttons shumingf @ 2021-06-17 12:39 ` Mark Brown [not found] ` <d6374c5158c844d69b4f546fd741f07f@realtek.com> 0 siblings, 1 reply; 9+ messages in thread From: Mark Brown @ 2021-06-17 12:39 UTC (permalink / raw) To: shumingf Cc: oder_chiou, jack.yu, alsa-devel, lars, lgirdwood, jairaj.arava, derek.fang, bard.liao, sathya.prakash.m.r, flove [-- Attachment #1: Type: text/plain, Size: 403 bytes --] On Thu, Jun 17, 2021 at 05:08:09PM +0800, shumingf@realtek.com wrote: > From: Shuming Fan <shumingf@realtek.com> > > This patch uses the same mapping as the machine driver: > BTN_0 : KEY_PLAYPAUSE > BTN_1 : KEY_VOICECOMMAND > BTN_2 : KEY_VOLUMEUP > BTN_3 : KEY_VOLUMEDOWN Which machine driver? Can't there be multiple machine drivers, and if they're already overriding things why do this? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <d6374c5158c844d69b4f546fd741f07f@realtek.com>]
* Re: [PATCH 1/2] ASoC: rt711: remap buttons [not found] ` <d6374c5158c844d69b4f546fd741f07f@realtek.com> @ 2021-06-17 13:27 ` Mark Brown 2021-06-17 14:23 ` Pierre-Louis Bossart 0 siblings, 1 reply; 9+ messages in thread From: Mark Brown @ 2021-06-17 13:27 UTC (permalink / raw) To: Shuming [范書銘] Cc: Oder Chiou, Jack Yu, alsa-devel, lars, lgirdwood, jairaj.arava, Derek [方德義], bard.liao, sathya.prakash.m.r, Flove(HsinFu) [-- Attachment #1: Type: text/plain, Size: 1124 bytes --] On Thu, Jun 17, 2021 at 01:19:05PM +0000, Shuming [范書銘] wrote: > > > This patch uses the same mapping as the machine driver: > > > BTN_0 : KEY_PLAYPAUSE > > > BTN_1 : KEY_VOICECOMMAND > > > BTN_2 : KEY_VOLUMEUP > > > BTN_3 : KEY_VOLUMEDOWN > > Which machine driver? Can't there be multiple machine drivers, and if > > they're already overriding things why do this? > The rt711 codec is designed in the Intel platform only for now. I'm sure your sales team would be happy to change that! > The machine driver is 'sof_sdw.c' that resides under sound/soc/intel/boards. > It seems Intel uses the same mapping in all other Intel machine drivers. > Please check the commit as below. > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=1f64a08bd5a9a218deb37c03c1e98e9567379698 Sure, but if the machine drivers for these platforms already do the right thing why change the CODEC driver? > Hi Sathya, > Do you know why the m/c driver uses this mapping? I'd guess it's just because that's the standard set of headphone buttons that Intel uses for their platforms. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ASoC: rt711: remap buttons 2021-06-17 13:27 ` Mark Brown @ 2021-06-17 14:23 ` Pierre-Louis Bossart 2021-06-24 18:06 ` Curtis Malainey 2021-06-25 0:56 ` Lu, Brent 0 siblings, 2 replies; 9+ messages in thread From: Pierre-Louis Bossart @ 2021-06-17 14:23 UTC (permalink / raw) To: Mark Brown, Shuming [范書銘] Cc: Oder Chiou, Jack Yu, alsa-devel, lars, Jimmy Cheng-Yi Chiang, lgirdwood, jairaj.arava, Derek [方德義], Flove(HsinFu), sathya.prakash.m.r, Curtis Malainey, Lu, Brent, bard.liao On 6/17/21 8:27 AM, Mark Brown wrote: > On Thu, Jun 17, 2021 at 01:19:05PM +0000, Shuming [范書銘] wrote: > >>>> This patch uses the same mapping as the machine driver: >>>> BTN_0 : KEY_PLAYPAUSE >>>> BTN_1 : KEY_VOICECOMMAND >>>> BTN_2 : KEY_VOLUMEUP >>>> BTN_3 : KEY_VOLUMEDOWN > >>> Which machine driver? Can't there be multiple machine drivers, and if >>> they're already overriding things why do this? > >> The rt711 codec is designed in the Intel platform only for now. > > I'm sure your sales team would be happy to change that! > >> The machine driver is 'sof_sdw.c' that resides under sound/soc/intel/boards. >> It seems Intel uses the same mapping in all other Intel machine drivers. >> Please check the commit as below. >> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=1f64a08bd5a9a218deb37c03c1e98e9567379698 > > Sure, but if the machine drivers for these platforms already do the > right thing why change the CODEC driver? > >> Hi Sathya, >> Do you know why the m/c driver uses this mapping? > > I'd guess it's just because that's the standard set of headphone buttons > that Intel uses for their platforms. Intel has no specific requirement, we just follow what the Google 4-button description says [1] That said, I can't recall why half of the machine drivers follow one pattern and the other half a different one. Same as spec: sof_da7219_max98373.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); sof_da7219_max98373.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP); sof_da7219_max98373.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN); sof_da7219_max98373.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND); sof_cs42l42.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); sof_cs42l42.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP); sof_cs42l42.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN); sof_cs42l42.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND); swap wrt. spec: sof_sdw_rt711.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOICECOMMAND); sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEUP); sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN); kbl_rt5663_max98927.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOICECOMMAND); kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEUP); kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN); Brent, Curtis, Jimmy, can you comment on the order? [1] https://source.android.com/devices/accessories/headset/plug-headset-spec#control-function_mapping ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ASoC: rt711: remap buttons 2021-06-17 14:23 ` Pierre-Louis Bossart @ 2021-06-24 18:06 ` Curtis Malainey 2021-06-25 18:31 ` Curtis Malainey 2021-06-25 0:56 ` Lu, Brent 1 sibling, 1 reply; 9+ messages in thread From: Curtis Malainey @ 2021-06-24 18:06 UTC (permalink / raw) To: Pierre-Louis Bossart Cc: Oder Chiou, Jack Yu, alsa-devel, lars, Jimmy Cheng-Yi Chiang, Curtis Malainey, lgirdwood, sathya.prakash.m.r, Mark Brown, Derek [方德義], Flove(HsinFu), Shuming [范書銘], jairaj.arava, Lu, Brent, bard.liao On Thu, Jun 17, 2021 at 7:23 AM Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> wrote: > > > > On 6/17/21 8:27 AM, Mark Brown wrote: > > On Thu, Jun 17, 2021 at 01:19:05PM +0000, Shuming [范書銘] wrote: > > > >>>> This patch uses the same mapping as the machine driver: > >>>> BTN_0 : KEY_PLAYPAUSE > >>>> BTN_1 : KEY_VOICECOMMAND > >>>> BTN_2 : KEY_VOLUMEUP > >>>> BTN_3 : KEY_VOLUMEDOWN > > > >>> Which machine driver? Can't there be multiple machine drivers, and if > >>> they're already overriding things why do this? > > > >> The rt711 codec is designed in the Intel platform only for now. > > > > I'm sure your sales team would be happy to change that! > > > >> The machine driver is 'sof_sdw.c' that resides under sound/soc/intel/boards. > >> It seems Intel uses the same mapping in all other Intel machine drivers. > >> Please check the commit as below. > >> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=1f64a08bd5a9a218deb37c03c1e98e9567379698 > > > > Sure, but if the machine drivers for these platforms already do the > > right thing why change the CODEC driver? > > > >> Hi Sathya, > >> Do you know why the m/c driver uses this mapping? > > > > I'd guess it's just because that's the standard set of headphone buttons > > that Intel uses for their platforms. > > Intel has no specific requirement, we just follow what the Google 4-button description says [1] > > That said, I can't recall why half of the machine drivers follow one pattern and the other half a different one. > > Same as spec: > sof_da7219_max98373.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); > sof_da7219_max98373.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP); > sof_da7219_max98373.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN); > sof_da7219_max98373.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND); > > sof_cs42l42.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); > sof_cs42l42.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP); > sof_cs42l42.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN); > sof_cs42l42.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND); > > swap wrt. spec: > sof_sdw_rt711.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOICECOMMAND); > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEUP); > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN); > > kbl_rt5663_max98927.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOICECOMMAND); > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEUP); > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN); > > Brent, Curtis, Jimmy, can you comment on the order? Sorry for the late reply, I couldn't figure out why this slipped by my email filter, I guess I should look closer next time. Soraka has been checked (kbl_rt5663_max98927) and yes the mapping does appear to be incorrect, volume up key returns voice command in evtest. Sathya will have to check the headset button mapping, on rt711 but my guess is it is also incorrect. > > > [1] https://source.android.com/devices/accessories/headset/plug-headset-spec#control-function_mapping > > > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ASoC: rt711: remap buttons 2021-06-24 18:06 ` Curtis Malainey @ 2021-06-25 18:31 ` Curtis Malainey 2021-06-30 6:01 ` Shuming [范書銘] 0 siblings, 1 reply; 9+ messages in thread From: Curtis Malainey @ 2021-06-25 18:31 UTC (permalink / raw) To: Pierre-Louis Bossart Cc: Oder Chiou, Jack Yu, alsa-devel, lars, Jimmy Cheng-Yi Chiang, Curtis Malainey, lgirdwood, sathya.prakash.m.r, Mark Brown, Derek [方德義], Flove(HsinFu), Shuming [范書銘], jairaj.arava, Lu, Brent, bard.liao > > Intel has no specific requirement, we just follow what the Google 4-button description says [1] > > > > That said, I can't recall why half of the machine drivers follow one pattern and the other half a different one. > > > > Same as spec: > > sof_da7219_max98373.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); > > sof_da7219_max98373.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP); > > sof_da7219_max98373.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN); > > sof_da7219_max98373.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND); > > > > sof_cs42l42.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); > > sof_cs42l42.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP); > > sof_cs42l42.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN); > > sof_cs42l42.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND); > > > > swap wrt. spec: > > sof_sdw_rt711.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); > > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOICECOMMAND); > > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEUP); > > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN); > > > > kbl_rt5663_max98927.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); > > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOICECOMMAND); > > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEUP); > > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN); > > > > Brent, Curtis, Jimmy, can you comment on the order? > > Sorry for the late reply, I couldn't figure out why this slipped by my > email filter, I guess I should look closer next time. Soraka has been > checked (kbl_rt5663_max98927) and yes the mapping does appear to be > incorrect, volume up key returns voice command in evtest. Sathya will > have to check the headset button mapping, on rt711 but my guess is it > is also incorrect. I stand corrected, misread the datasheet. So rt711 and rt5663 are correct based on datasheet specs but when grabbing an off the shelf headphone they did not work with the volume up. Hmm, I wonder if this split is "what usually works" and "what is correct." ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH 1/2] ASoC: rt711: remap buttons 2021-06-25 18:31 ` Curtis Malainey @ 2021-06-30 6:01 ` Shuming [范書銘] 2021-06-30 13:07 ` Mark Brown 0 siblings, 1 reply; 9+ messages in thread From: Shuming [范書銘] @ 2021-06-30 6:01 UTC (permalink / raw) To: Mark Brown, Curtis Malainey, Pierre-Louis Bossart Cc: Oder Chiou, Jack Yu, alsa-devel, lars, Jimmy Cheng-Yi Chiang, lgirdwood, jairaj.arava, Derek [方德義], Flove(HsinFu), sathya.prakash.m.r, Curtis Malainey, Lu, Brent, bard.liao > > > > > > swap wrt. spec: > > > sof_sdw_rt711.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, > KEY_PLAYPAUSE); > > > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, > KEY_VOICECOMMAND); > > > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, > KEY_VOLUMEUP); > > > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, > KEY_VOLUMEDOWN); > > > > > > kbl_rt5663_max98927.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, > > > KEY_PLAYPAUSE); > > > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, > > > KEY_VOICECOMMAND); > > > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, > > > KEY_VOLUMEUP); > > > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, > > > KEY_VOLUMEDOWN); > > > > > > Brent, Curtis, Jimmy, can you comment on the order? > > > > Sorry for the late reply, I couldn't figure out why this slipped by my > > email filter, I guess I should look closer next time. Soraka has been > > checked (kbl_rt5663_max98927) and yes the mapping does appear to be > > incorrect, volume up key returns voice command in evtest. Sathya will > > have to check the headset button mapping, on rt711 but my guess is it > > is also incorrect. > > I stand corrected, misread the datasheet. So rt711 and rt5663 are correct > based on datasheet specs but when grabbing an off the shelf headphone they > did not work with the volume up. Hmm, I wonder if this split is "what usually > works" and "what is correct." Thanks for your reply, Curtis. This patch just changes the mapping to let the button function work properly. Hi Mark, Do I need to resend the patch? Or any comments? > ------Please consider the environment before printing this e-mail. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ASoC: rt711: remap buttons 2021-06-30 6:01 ` Shuming [范書銘] @ 2021-06-30 13:07 ` Mark Brown 0 siblings, 0 replies; 9+ messages in thread From: Mark Brown @ 2021-06-30 13:07 UTC (permalink / raw) To: Shuming [范書銘] Cc: Oder Chiou, Jack Yu, alsa-devel, lars, Jimmy Cheng-Yi Chiang, Curtis Malainey, Pierre-Louis Bossart, lgirdwood, jairaj.arava, Derek [方德義], Flove(HsinFu), sathya.prakash.m.r, Curtis Malainey, Lu, Brent, bard.liao [-- Attachment #1: Type: text/plain, Size: 339 bytes --] On Wed, Jun 30, 2021 at 06:01:52AM +0000, Shuming [范書銘] wrote: > Do I need to resend the patch? Or any comments? None of this has answered my original question - to repeat why would we change the defaults in the CODEC driver given that the machines can already set what they want anyway and apparently are already doing so? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH 1/2] ASoC: rt711: remap buttons 2021-06-17 14:23 ` Pierre-Louis Bossart 2021-06-24 18:06 ` Curtis Malainey @ 2021-06-25 0:56 ` Lu, Brent 1 sibling, 0 replies; 9+ messages in thread From: Lu, Brent @ 2021-06-25 0:56 UTC (permalink / raw) To: Pierre-Louis Bossart, Mark Brown, Shuming [范書銘] Cc: Oder Chiou, Jack Yu, alsa-devel, lars, Jimmy Cheng-Yi Chiang, lgirdwood, Arava, Jairaj, Derek [方德義], Flove(HsinFu), M R, Sathya Prakash, Curtis Malainey, Liao, Bard > > Intel has no specific requirement, we just follow what the Google 4-button > description says [1] > > That said, I can't recall why half of the machine drivers follow one pattern and > the other half a different one. > > Same as spec: > sof_da7219_max98373.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, > KEY_PLAYPAUSE); > sof_da7219_max98373.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, > KEY_VOLUMEUP); > sof_da7219_max98373.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, > KEY_VOLUMEDOWN); > sof_da7219_max98373.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, > KEY_VOICECOMMAND); > > sof_cs42l42.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, > KEY_PLAYPAUSE); > sof_cs42l42.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, > KEY_VOLUMEUP); > sof_cs42l42.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, > KEY_VOLUMEDOWN); > sof_cs42l42.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, > KEY_VOICECOMMAND); > > swap wrt. spec: > sof_sdw_rt711.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, > KEY_PLAYPAUSE); > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, > KEY_VOICECOMMAND); > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, > KEY_VOLUMEUP); > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, > KEY_VOLUMEDOWN); > > kbl_rt5663_max98927.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, > KEY_PLAYPAUSE); > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, > KEY_VOICECOMMAND); > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, > KEY_VOLUMEUP); > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, > KEY_VOLUMEDOWN); > > Brent, Curtis, Jimmy, can you comment on the order? > > > [1] https://source.android.com/devices/accessories/headset/plug-headset- > spec#control-function_mapping > Hi Pierre, I just shared the link [1] with ODM and codec vendor to double check the mapping is following the requirement. Regards, Brent ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-06-30 13:09 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 9:08 [PATCH 1/2] ASoC: rt711: remap buttons shumingf
2021-06-17 12:39 ` Mark Brown
[not found] ` <d6374c5158c844d69b4f546fd741f07f@realtek.com>
2021-06-17 13:27 ` Mark Brown
2021-06-17 14:23 ` Pierre-Louis Bossart
2021-06-24 18:06 ` Curtis Malainey
2021-06-25 18:31 ` Curtis Malainey
2021-06-30 6:01 ` Shuming [范書銘]
2021-06-30 13:07 ` Mark Brown
2021-06-25 0:56 ` Lu, Brent
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.