From: kernel test robot <lkp@intel.com> To: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: kbuild-all@lists.01.org, linux-media@vger.kernel.org, linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/11] media: adv7842: better document EDID block size Date: Thu, 17 Jun 2021 16:15:21 +0800 [thread overview] Message-ID: <202106171628.SvSYvKAE-lkp@intel.com> (raw) In-Reply-To: <6bed7a69367856080a62e3ee89df6a2a3d0d5f20.1623846327.git.mchehab+huawei@kernel.org> [-- Attachment #1: Type: text/plain, Size: 3707 bytes --] Hi Mauro, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20210616] [cannot apply to v5.13-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Address-some-smatch-warnings/20210617-091510 base: git://linuxtv.org/media_tree.git master config: alpha-randconfig-r025-20210617 (attached as .config) compiler: alpha-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/3bdf84a7467fed26b64ffe547f5989d73060a30e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mauro-Carvalho-Chehab/Address-some-smatch-warnings/20210617-091510 git checkout 3bdf84a7467fed26b64ffe547f5989d73060a30e # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All error/warnings (new ones prefixed by >>): drivers/media/i2c/adv7842.c: In function 'edid_write_vga_segment': >> drivers/media/i2c/adv7842.c:739:19: warning: comparison between pointer and integer 739 | for (i = 0; && i < blocks * EDID_BLOCK_SIZE; i += I2C_SMBUS_BLOCK_MAX) { | ^ >> drivers/media/i2c/adv7842.c:739:2: error: label 'i' used but not defined 739 | for (i = 0; && i < blocks * EDID_BLOCK_SIZE; i += I2C_SMBUS_BLOCK_MAX) { | ^~~ vim +/i +739 drivers/media/i2c/adv7842.c 715 716 static int edid_write_vga_segment(struct v4l2_subdev *sd) 717 { 718 struct i2c_client *client = v4l2_get_subdevdata(sd); 719 struct adv7842_state *state = to_state(sd); 720 const u8 *edid = state->vga_edid.edid; 721 u32 blocks = state->vga_edid.blocks; 722 int err = 0; 723 int i; 724 725 v4l2_dbg(2, debug, sd, "%s: write EDID on VGA port\n", __func__); 726 727 if (!state->vga_edid.present) 728 return 0; 729 730 /* HPA disable on port A and B */ 731 io_write_and_or(sd, 0x20, 0xcf, 0x00); 732 733 /* Disable I2C access to internal EDID ram from VGA DDC port */ 734 rep_write_and_or(sd, 0x7f, 0x7f, 0x00); 735 736 /* edid segment pointer '1' for VGA port */ 737 rep_write_and_or(sd, 0x77, 0xef, 0x10); 738 > 739 for (i = 0; && i < blocks * EDID_BLOCK_SIZE; i += I2C_SMBUS_BLOCK_MAX) { 740 err = i2c_smbus_write_i2c_block_data(state->i2c_edid, i, 741 I2C_SMBUS_BLOCK_MAX, 742 edid + i); 743 if (err) 744 return err; 745 } 746 747 /* Calculates the checksums and enables I2C access 748 * to internal EDID ram from VGA DDC port. 749 */ 750 rep_write_and_or(sd, 0x7f, 0x7f, 0x80); 751 752 for (i = 0; i < 1000; i++) { 753 if (rep_read(sd, 0x79) & 0x20) 754 break; 755 mdelay(1); 756 } 757 if (i == 1000) { 758 v4l_err(client, "error enabling edid on VGA port\n"); 759 return -EIO; 760 } 761 762 /* enable hotplug after 200 ms */ 763 schedule_delayed_work(&state->delayed_work_enable_hotplug, HZ / 5); 764 765 return 0; 766 } 767 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 28567 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH 08/11] media: adv7842: better document EDID block size Date: Thu, 17 Jun 2021 16:15:21 +0800 [thread overview] Message-ID: <202106171628.SvSYvKAE-lkp@intel.com> (raw) In-Reply-To: <6bed7a69367856080a62e3ee89df6a2a3d0d5f20.1623846327.git.mchehab+huawei@kernel.org> [-- Attachment #1: Type: text/plain, Size: 3807 bytes --] Hi Mauro, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20210616] [cannot apply to v5.13-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Address-some-smatch-warnings/20210617-091510 base: git://linuxtv.org/media_tree.git master config: alpha-randconfig-r025-20210617 (attached as .config) compiler: alpha-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/3bdf84a7467fed26b64ffe547f5989d73060a30e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mauro-Carvalho-Chehab/Address-some-smatch-warnings/20210617-091510 git checkout 3bdf84a7467fed26b64ffe547f5989d73060a30e # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All error/warnings (new ones prefixed by >>): drivers/media/i2c/adv7842.c: In function 'edid_write_vga_segment': >> drivers/media/i2c/adv7842.c:739:19: warning: comparison between pointer and integer 739 | for (i = 0; && i < blocks * EDID_BLOCK_SIZE; i += I2C_SMBUS_BLOCK_MAX) { | ^ >> drivers/media/i2c/adv7842.c:739:2: error: label 'i' used but not defined 739 | for (i = 0; && i < blocks * EDID_BLOCK_SIZE; i += I2C_SMBUS_BLOCK_MAX) { | ^~~ vim +/i +739 drivers/media/i2c/adv7842.c 715 716 static int edid_write_vga_segment(struct v4l2_subdev *sd) 717 { 718 struct i2c_client *client = v4l2_get_subdevdata(sd); 719 struct adv7842_state *state = to_state(sd); 720 const u8 *edid = state->vga_edid.edid; 721 u32 blocks = state->vga_edid.blocks; 722 int err = 0; 723 int i; 724 725 v4l2_dbg(2, debug, sd, "%s: write EDID on VGA port\n", __func__); 726 727 if (!state->vga_edid.present) 728 return 0; 729 730 /* HPA disable on port A and B */ 731 io_write_and_or(sd, 0x20, 0xcf, 0x00); 732 733 /* Disable I2C access to internal EDID ram from VGA DDC port */ 734 rep_write_and_or(sd, 0x7f, 0x7f, 0x00); 735 736 /* edid segment pointer '1' for VGA port */ 737 rep_write_and_or(sd, 0x77, 0xef, 0x10); 738 > 739 for (i = 0; && i < blocks * EDID_BLOCK_SIZE; i += I2C_SMBUS_BLOCK_MAX) { 740 err = i2c_smbus_write_i2c_block_data(state->i2c_edid, i, 741 I2C_SMBUS_BLOCK_MAX, 742 edid + i); 743 if (err) 744 return err; 745 } 746 747 /* Calculates the checksums and enables I2C access 748 * to internal EDID ram from VGA DDC port. 749 */ 750 rep_write_and_or(sd, 0x7f, 0x7f, 0x80); 751 752 for (i = 0; i < 1000; i++) { 753 if (rep_read(sd, 0x79) & 0x20) 754 break; 755 mdelay(1); 756 } 757 if (i == 1000) { 758 v4l_err(client, "error enabling edid on VGA port\n"); 759 return -EIO; 760 } 761 762 /* enable hotplug after 200 ms */ 763 schedule_delayed_work(&state->delayed_work_enable_hotplug, HZ / 5); 764 765 return 0; 766 } 767 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 28567 bytes --]
next prev parent reply other threads:[~2021-06-17 8:17 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-16 12:28 [PATCH 00/11] Address some smatch warnings Mauro Carvalho Chehab 2021-06-16 12:28 ` Mauro Carvalho Chehab 2021-06-16 12:28 ` Mauro Carvalho Chehab 2021-06-16 12:28 ` [PATCH 01/11] media: dvb_ca_en50221: avoid speculation from CA slot Mauro Carvalho Chehab 2021-06-16 12:28 ` [PATCH 02/11] media: dvb_net: avoid speculation from net slot Mauro Carvalho Chehab 2021-06-16 12:28 ` [PATCH 03/11] media: dvbdev: fix error logic at dvb_register_device() Mauro Carvalho Chehab 2021-06-16 12:28 ` [PATCH 04/11] media: sun6i-csi: add a missing return code Mauro Carvalho Chehab 2021-06-16 12:28 ` Mauro Carvalho Chehab 2021-06-16 12:28 ` Mauro Carvalho Chehab 2021-06-17 5:37 ` yong 2021-06-17 5:37 ` yong 2021-06-16 12:28 ` [PATCH 05/11] media: saa7134: use more meaninful goto labels Mauro Carvalho Chehab 2021-06-16 12:28 ` [PATCH 06/11] media: saa7134: fix saa7134_initdev error handling logic Mauro Carvalho Chehab 2021-06-16 12:28 ` [PATCH 07/11] media: siano: fix device register error path Mauro Carvalho Chehab 2021-06-16 12:28 ` [PATCH 08/11] media: adv7842: better document EDID block size Mauro Carvalho Chehab 2021-06-16 12:32 ` Hans Verkuil 2021-06-17 6:26 ` kernel test robot 2021-06-17 6:26 ` kernel test robot 2021-06-17 8:15 ` kernel test robot [this message] 2021-06-17 8:15 ` kernel test robot 2021-06-16 12:28 ` [PATCH 09/11] media: ttusb-dec: cleanup an error handling logic Mauro Carvalho Chehab 2021-06-16 12:28 ` [PATCH 10/11] media: dvb-core: frontend: make GET/SET safer Mauro Carvalho Chehab 2021-06-16 12:28 ` [PATCH 11/11] media: xilinx: simplify get fourcc logic Mauro Carvalho Chehab 2021-06-16 12:28 ` Mauro Carvalho Chehab
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202106171628.SvSYvKAE-lkp@intel.com \ --to=lkp@intel.com \ --cc=hverkuil@xs4all.nl \ --cc=kbuild-all@lists.01.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=mauro.chehab@huawei.com \ --cc=mchehab@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.