From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> To: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au Cc: Nathan Lynch <nathanl@linux.ibm.com>, David Gibson <david@gibson.dropbear.id.au>, Daniel Henrique Barboza <danielhb413@gmail.com>, nvdimm@lists.linux.dev, dan.j.williams@intel.com, "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> Subject: [PATCH v4 6/7] powerpc/pseries: Add a helper for form1 cpu distance Date: Thu, 17 Jun 2021 22:21:04 +0530 [thread overview] Message-ID: <20210617165105.574178-7-aneesh.kumar@linux.ibm.com> (raw) In-Reply-To: <20210617165105.574178-1-aneesh.kumar@linux.ibm.com> This helper is only used with the dispatch trace log collection. A later patch will add Form2 affinity support and this change helps in keeping that simpler. Also add a comment explaining we don't expect the code to be called with FORM0 Reviewed-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> --- arch/powerpc/mm/numa.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index c481f08d565b..d32729f235b8 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch/powerpc/mm/numa.c @@ -166,7 +166,7 @@ static void unmap_cpu_from_node(unsigned long cpu) } #endif /* CONFIG_HOTPLUG_CPU || CONFIG_PPC_SPLPAR */ -int cpu_distance(__be32 *cpu1_assoc, __be32 *cpu2_assoc) +static int __cpu_form1_distance(__be32 *cpu1_assoc, __be32 *cpu2_assoc) { int dist = 0; @@ -182,6 +182,14 @@ int cpu_distance(__be32 *cpu1_assoc, __be32 *cpu2_assoc) return dist; } +int cpu_distance(__be32 *cpu1_assoc, __be32 *cpu2_assoc) +{ + /* We should not get called with FORM0 */ + VM_WARN_ON(affinity_form == FORM0_AFFINITY); + + return __cpu_form1_distance(cpu1_assoc, cpu2_assoc); +} + /* must hold reference to node during call */ static const __be32 *of_get_associativity(struct device_node *dev) { -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> To: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au Cc: Nathan Lynch <nathanl@linux.ibm.com>, nvdimm@lists.linux.dev, "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, dan.j.williams@intel.com, David Gibson <david@gibson.dropbear.id.au> Subject: [PATCH v4 6/7] powerpc/pseries: Add a helper for form1 cpu distance Date: Thu, 17 Jun 2021 22:21:04 +0530 [thread overview] Message-ID: <20210617165105.574178-7-aneesh.kumar@linux.ibm.com> (raw) In-Reply-To: <20210617165105.574178-1-aneesh.kumar@linux.ibm.com> This helper is only used with the dispatch trace log collection. A later patch will add Form2 affinity support and this change helps in keeping that simpler. Also add a comment explaining we don't expect the code to be called with FORM0 Reviewed-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> --- arch/powerpc/mm/numa.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index c481f08d565b..d32729f235b8 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch/powerpc/mm/numa.c @@ -166,7 +166,7 @@ static void unmap_cpu_from_node(unsigned long cpu) } #endif /* CONFIG_HOTPLUG_CPU || CONFIG_PPC_SPLPAR */ -int cpu_distance(__be32 *cpu1_assoc, __be32 *cpu2_assoc) +static int __cpu_form1_distance(__be32 *cpu1_assoc, __be32 *cpu2_assoc) { int dist = 0; @@ -182,6 +182,14 @@ int cpu_distance(__be32 *cpu1_assoc, __be32 *cpu2_assoc) return dist; } +int cpu_distance(__be32 *cpu1_assoc, __be32 *cpu2_assoc) +{ + /* We should not get called with FORM0 */ + VM_WARN_ON(affinity_form == FORM0_AFFINITY); + + return __cpu_form1_distance(cpu1_assoc, cpu2_assoc); +} + /* must hold reference to node during call */ static const __be32 *of_get_associativity(struct device_node *dev) { -- 2.31.1
next prev parent reply other threads:[~2021-06-17 16:51 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-17 16:50 [PATCH v4 0/7] Add support for FORM2 associativity Aneesh Kumar K.V 2021-06-17 16:50 ` Aneesh Kumar K.V 2021-06-17 16:50 ` [PATCH v4 1/7] powerpc/pseries: rename min_common_depth to primary_domain_index Aneesh Kumar K.V 2021-06-17 16:50 ` Aneesh Kumar K.V 2021-06-24 1:46 ` David Gibson 2021-06-24 1:46 ` David Gibson 2021-06-17 16:51 ` [PATCH v4 2/7] powerpc/pseries: rename distance_ref_points_depth to max_associativity_domain_index Aneesh Kumar K.V 2021-06-17 16:51 ` Aneesh Kumar K.V 2021-06-24 3:10 ` David Gibson 2021-06-24 3:10 ` David Gibson 2021-06-17 16:51 ` [PATCH v4 3/7] powerpc/pseries: Rename TYPE1_AFFINITY to FORM1_AFFINITY Aneesh Kumar K.V 2021-06-17 16:51 ` Aneesh Kumar K.V 2021-06-17 16:51 ` [PATCH v4 4/7] powerpc/pseries: Consolidate DLPAR NUMA distance update Aneesh Kumar K.V 2021-06-17 16:51 ` Aneesh Kumar K.V 2021-06-24 3:11 ` David Gibson 2021-06-24 3:11 ` David Gibson 2021-06-17 16:51 ` [PATCH v4 5/7] powerpc/pseries: Consolidate NUMA distance update during boot Aneesh Kumar K.V 2021-06-17 16:51 ` Aneesh Kumar K.V 2021-06-17 16:51 ` Aneesh Kumar K.V [this message] 2021-06-17 16:51 ` [PATCH v4 6/7] powerpc/pseries: Add a helper for form1 cpu distance Aneesh Kumar K.V 2021-06-17 16:51 ` [PATCH v4 7/7] powerpc/pseries: Add support for FORM2 associativity Aneesh Kumar K.V 2021-06-17 16:51 ` Aneesh Kumar K.V 2021-06-21 22:02 ` Daniel Henrique Barboza 2021-06-21 22:02 ` Daniel Henrique Barboza 2021-06-22 12:07 ` Aneesh Kumar K.V 2021-06-22 12:07 ` Aneesh Kumar K.V 2021-06-22 16:04 ` Daniel Henrique Barboza 2021-06-22 16:04 ` Daniel Henrique Barboza 2021-06-24 3:08 ` David Gibson 2021-06-24 3:08 ` David Gibson 2021-06-24 8:20 ` Aneesh Kumar K.V 2021-06-24 8:20 ` Aneesh Kumar K.V 2021-06-28 6:18 ` David Gibson 2021-06-28 6:18 ` David Gibson 2021-06-28 15:04 ` Aneesh Kumar K.V 2021-06-28 15:04 ` Aneesh Kumar K.V 2021-06-24 10:33 ` Laurent Dufour 2021-06-24 10:33 ` Laurent Dufour 2021-06-24 10:55 ` Aneesh Kumar K.V 2021-06-24 10:55 ` Aneesh Kumar K.V
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210617165105.574178-7-aneesh.kumar@linux.ibm.com \ --to=aneesh.kumar@linux.ibm.com \ --cc=dan.j.williams@intel.com \ --cc=danielhb413@gmail.com \ --cc=david@gibson.dropbear.id.au \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=nathanl@linux.ibm.com \ --cc=nvdimm@lists.linux.dev \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.