* [BlueZ PATCH v1] adv_monitor: Avoid skipping non-discoverable dev on Monitor match
@ 2021-06-18 4:58 Manish Mandlik
2021-06-18 5:40 ` [BlueZ,v1] " bluez.test.bot
[not found] ` <CAGPPCLCCvnsbgF9x4dFMDq+ZCr5KZ-+-NuSu++8NpFDCM8iiMA@mail.gmail.com>
0 siblings, 2 replies; 3+ messages in thread
From: Manish Mandlik @ 2021-06-18 4:58 UTC (permalink / raw)
To: marcel, luiz.dentz
Cc: linux-bluetooth, chromeos-bluetooth-upstreaming, Manish Mandlik,
mcchou, alainmichaud
Do no skip a non-discoverable device if it matches any Advertisement
Monitor.
Reviewed-by: mcchou@google.com
Reviewed-by: alainmichaud@google.com
Signed-off-by: Manish Mandlik <mmandlik@google.com>
---
src/adapter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/adapter.c b/src/adapter.c
index 98fc78f1e..2175120f4 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -6656,7 +6656,7 @@ static void update_found_devices(struct btd_adapter *adapter,
dev = btd_adapter_find_device(adapter, bdaddr, bdaddr_type);
if (!dev) {
- if (!discoverable) {
+ if (!discoverable && !matched_monitors) {
eir_data_free(&eir_data);
return;
}
--
2.32.0.288.g62a8d224e6-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [BlueZ,v1] adv_monitor: Avoid skipping non-discoverable dev on Monitor match
2021-06-18 4:58 [BlueZ PATCH v1] adv_monitor: Avoid skipping non-discoverable dev on Monitor match Manish Mandlik
@ 2021-06-18 5:40 ` bluez.test.bot
[not found] ` <CAGPPCLCCvnsbgF9x4dFMDq+ZCr5KZ-+-NuSu++8NpFDCM8iiMA@mail.gmail.com>
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2021-06-18 5:40 UTC (permalink / raw)
To: linux-bluetooth, mmandlik
[-- Attachment #1: Type: text/plain, Size: 1953 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=502943
---Test result---
Test Summary:
CheckPatch PASS 0.52 seconds
GitLint PASS 0.15 seconds
Prep - Setup ELL PASS 47.36 seconds
Build - Prep PASS 0.11 seconds
Build - Configure PASS 8.29 seconds
Build - Make PASS 203.05 seconds
Make Check PASS 8.86 seconds
Make Distcheck PASS 243.32 seconds
Build w/ext ELL - Configure PASS 8.30 seconds
Build w/ext ELL - Make PASS 191.56 seconds
Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint
##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL
##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build
##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree
##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree
##############################
Test: Make Check - PASS
Desc: Run 'make check'
##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution
##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration
##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <CAGPPCLCCvnsbgF9x4dFMDq+ZCr5KZ-+-NuSu++8NpFDCM8iiMA@mail.gmail.com>]
* Re: [BlueZ PATCH v1] adv_monitor: Avoid skipping non-discoverable dev on Monitor match
[not found] ` <CAGPPCLCCvnsbgF9x4dFMDq+ZCr5KZ-+-NuSu++8NpFDCM8iiMA@mail.gmail.com>
@ 2021-06-24 20:12 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2021-06-24 20:12 UTC (permalink / raw)
To: Manish Mandlik
Cc: Marcel Holtmann, linux-bluetooth, ChromeOS Bluetooth Upstreaming,
Miao-chen Chou, Alain Michaud
Hi Manish,
On Thu, Jun 24, 2021 at 10:10 AM Manish Mandlik <mmandlik@google.com> wrote:
>
> Friendly reminder to review this patch.
>
> Regards,
> Manish.
>
>
> On Thu, Jun 17, 2021 at 9:58 PM Manish Mandlik <mmandlik@google.com> wrote:
>>
>> Do no skip a non-discoverable device if it matches any Advertisement
>> Monitor.
>>
>> Reviewed-by: mcchou@google.com
>> Reviewed-by: alainmichaud@google.com
>> Signed-off-by: Manish Mandlik <mmandlik@google.com>
>> ---
>>
>> src/adapter.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/adapter.c b/src/adapter.c
>> index 98fc78f1e..2175120f4 100644
>> --- a/src/adapter.c
>> +++ b/src/adapter.c
>> @@ -6656,7 +6656,7 @@ static void update_found_devices(struct btd_adapter *adapter,
>>
>> dev = btd_adapter_find_device(adapter, bdaddr, bdaddr_type);
>> if (!dev) {
>> - if (!discoverable) {
>> + if (!discoverable && !matched_monitors) {
>> eir_data_free(&eir_data);
>> return;
>> }
>> --
>> 2.32.0.288.g62a8d224e6-goog
>>
Applied, thanks.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-24 20:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18 4:58 [BlueZ PATCH v1] adv_monitor: Avoid skipping non-discoverable dev on Monitor match Manish Mandlik
2021-06-18 5:40 ` [BlueZ,v1] " bluez.test.bot
[not found] ` <CAGPPCLCCvnsbgF9x4dFMDq+ZCr5KZ-+-NuSu++8NpFDCM8iiMA@mail.gmail.com>
2021-06-24 20:12 ` [BlueZ PATCH v1] " Luiz Augusto von Dentz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.