From: kernel test robot <lkp@intel.com> To: Wesley Cheng <wcheng@codeaurora.org>, balbi@kernel.org, gregkh@linuxfoundation.org, robh+dt@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, frowand.list@gmail.com Cc: kbuild-all@lists.01.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v10 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Date: Fri, 18 Jun 2021 02:01:16 +0800 [thread overview] Message-ID: <202106180149.f7LhHIwz-lkp@intel.com> (raw) In-Reply-To: <1623923899-16759-4-git-send-email-wcheng@codeaurora.org> [-- Attachment #1: Type: text/plain, Size: 3656 bytes --] Hi Wesley, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on robh/for-next v5.13-rc6 next-20210617] [cannot apply to balbi-usb/testing/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Wesley-Cheng/Re-introduce-TX-FIFO-resize-for-larger-EP-bursting/20210617-180037 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/94892083cf17e46a29d4ef33a044af04854162e6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Wesley-Cheng/Re-introduce-TX-FIFO-resize-for-larger-EP-bursting/20210617-180037 git checkout 94892083cf17e46a29d4ef33a044af04854162e6 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/usb/dwc3/gadget.c: In function 'dwc3_gadget_clear_tx_fifos': >> drivers/usb/dwc3/gadget.c:671:18: warning: variable 'dep' set but not used [-Wunused-but-set-variable] 671 | struct dwc3_ep *dep; | ^~~ -- drivers/usb/dwc3/gadget.c:648: warning: Function parameter or member 'mult' not described in 'dwc3_gadget_calc_tx_fifo_size' drivers/usb/dwc3/gadget.c:648: warning: Excess function parameter 'nfifos' description in 'dwc3_gadget_calc_tx_fifo_size' >> drivers/usb/dwc3/gadget.c:670: warning: expecting prototype for dwc3_gadget_clear_tx_fifo_size(). Prototype was for dwc3_gadget_clear_tx_fifos() instead vim +/dep +671 drivers/usb/dwc3/gadget.c 661 662 /** 663 * dwc3_gadget_clear_tx_fifo_size - Clears txfifo allocation 664 * @dwc: pointer to the DWC3 context 665 * 666 * Iterates through all the endpoint registers and clears the previous txfifo 667 * allocations. 668 */ 669 void dwc3_gadget_clear_tx_fifos(struct dwc3 *dwc) > 670 { > 671 struct dwc3_ep *dep; 672 int fifo_depth; 673 int size; 674 int num; 675 676 if (!dwc->do_fifo_resize) 677 return; 678 679 /* Read ep0IN related TXFIFO size */ 680 dep = dwc->eps[1]; 681 size = dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(0)); 682 if (DWC3_IP_IS(DWC3)) 683 fifo_depth = DWC3_GTXFIFOSIZ_TXFDEP(size); 684 else 685 fifo_depth = DWC31_GTXFIFOSIZ_TXFDEP(size); 686 687 dwc->last_fifo_depth = fifo_depth; 688 /* Clear existing TXFIFO for all IN eps except ep0 */ 689 for (num = 3; num < min_t(int, dwc->num_eps, DWC3_ENDPOINTS_NUM); 690 num += 2) { 691 dep = dwc->eps[num]; 692 /* Don't change TXFRAMNUM on usb31 version */ 693 size = DWC3_IP_IS(DWC3) ? 0 : 694 dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1)) & 695 DWC31_GTXFIFOSIZ_TXFRAMNUM; 696 697 dwc3_writel(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1), size); 698 } 699 dwc->num_ep_resized = 0; 700 } 701 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 60446 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH v10 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Date: Fri, 18 Jun 2021 02:01:16 +0800 [thread overview] Message-ID: <202106180149.f7LhHIwz-lkp@intel.com> (raw) In-Reply-To: <1623923899-16759-4-git-send-email-wcheng@codeaurora.org> [-- Attachment #1: Type: text/plain, Size: 3745 bytes --] Hi Wesley, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on robh/for-next v5.13-rc6 next-20210617] [cannot apply to balbi-usb/testing/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Wesley-Cheng/Re-introduce-TX-FIFO-resize-for-larger-EP-bursting/20210617-180037 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/94892083cf17e46a29d4ef33a044af04854162e6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Wesley-Cheng/Re-introduce-TX-FIFO-resize-for-larger-EP-bursting/20210617-180037 git checkout 94892083cf17e46a29d4ef33a044af04854162e6 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/usb/dwc3/gadget.c: In function 'dwc3_gadget_clear_tx_fifos': >> drivers/usb/dwc3/gadget.c:671:18: warning: variable 'dep' set but not used [-Wunused-but-set-variable] 671 | struct dwc3_ep *dep; | ^~~ -- drivers/usb/dwc3/gadget.c:648: warning: Function parameter or member 'mult' not described in 'dwc3_gadget_calc_tx_fifo_size' drivers/usb/dwc3/gadget.c:648: warning: Excess function parameter 'nfifos' description in 'dwc3_gadget_calc_tx_fifo_size' >> drivers/usb/dwc3/gadget.c:670: warning: expecting prototype for dwc3_gadget_clear_tx_fifo_size(). Prototype was for dwc3_gadget_clear_tx_fifos() instead vim +/dep +671 drivers/usb/dwc3/gadget.c 661 662 /** 663 * dwc3_gadget_clear_tx_fifo_size - Clears txfifo allocation 664 * @dwc: pointer to the DWC3 context 665 * 666 * Iterates through all the endpoint registers and clears the previous txfifo 667 * allocations. 668 */ 669 void dwc3_gadget_clear_tx_fifos(struct dwc3 *dwc) > 670 { > 671 struct dwc3_ep *dep; 672 int fifo_depth; 673 int size; 674 int num; 675 676 if (!dwc->do_fifo_resize) 677 return; 678 679 /* Read ep0IN related TXFIFO size */ 680 dep = dwc->eps[1]; 681 size = dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(0)); 682 if (DWC3_IP_IS(DWC3)) 683 fifo_depth = DWC3_GTXFIFOSIZ_TXFDEP(size); 684 else 685 fifo_depth = DWC31_GTXFIFOSIZ_TXFDEP(size); 686 687 dwc->last_fifo_depth = fifo_depth; 688 /* Clear existing TXFIFO for all IN eps except ep0 */ 689 for (num = 3; num < min_t(int, dwc->num_eps, DWC3_ENDPOINTS_NUM); 690 num += 2) { 691 dep = dwc->eps[num]; 692 /* Don't change TXFRAMNUM on usb31 version */ 693 size = DWC3_IP_IS(DWC3) ? 0 : 694 dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1)) & 695 DWC31_GTXFIFOSIZ_TXFRAMNUM; 696 697 dwc3_writel(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1), size); 698 } 699 dwc->num_ep_resized = 0; 700 } 701 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 60446 bytes --]
next prev parent reply other threads:[~2021-06-17 18:02 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-17 9:58 [PATCH v10 0/6] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng 2021-06-17 9:58 ` [PATCH v10 1/6] usb: gadget: udc: core: Introduce check_config to verify USB configuration Wesley Cheng 2021-06-17 11:09 ` Greg KH 2021-06-22 5:27 ` Wesley Cheng 2021-06-17 9:58 ` [PATCH v10 2/6] usb: gadget: configfs: Check USB configuration before adding Wesley Cheng 2021-06-17 11:07 ` Greg KH 2021-06-22 5:27 ` Wesley Cheng 2021-06-22 6:05 ` Greg KH 2021-06-23 9:38 ` Wesley Cheng 2021-06-23 11:35 ` Greg KH 2021-06-23 21:44 ` Wesley Cheng 2021-06-24 12:09 ` Greg KH 2021-06-17 9:58 ` [PATCH v10 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng 2021-06-17 11:10 ` Greg KH 2021-06-22 5:27 ` Wesley Cheng 2021-06-22 6:06 ` Greg KH 2021-06-17 17:56 ` kernel test robot 2021-06-17 17:56 ` kernel test robot 2021-06-17 18:01 ` kernel test robot [this message] 2021-06-17 18:01 ` kernel test robot 2021-06-17 9:58 ` [PATCH v10 4/6] of: Add stub for of_add_property() Wesley Cheng 2021-06-17 9:58 ` [PATCH v10 5/6] usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default Wesley Cheng 2021-06-17 11:12 ` Greg KH 2021-06-17 18:04 ` kernel test robot 2021-06-17 18:04 ` kernel test robot 2021-06-18 4:35 ` Jack Pham 2021-06-18 4:35 ` Jack Pham 2021-06-17 9:58 ` [PATCH v10 6/6] dt-bindings: usb: dwc3: Update dwc3 TX fifo properties Wesley Cheng 2021-06-17 21:01 ` [PATCH v10 0/6] Re-introduce TX FIFO resize for larger EP bursting Ferry Toth 2021-06-17 21:48 ` Wesley Cheng [not found] ` <f5ed0ee7-e333-681f-0f1a-d0227562204b@gmail.com> 2021-06-17 22:25 ` Wesley Cheng 2021-06-19 12:40 ` Ferry Toth 2021-06-22 18:38 ` Wesley Cheng 2021-06-22 20:09 ` Ferry Toth 2021-06-22 22:00 ` Wesley Cheng 2021-06-22 22:12 ` Ferry Toth 2021-06-23 7:50 ` Wesley Cheng 2021-06-25 21:10 ` Ferry Toth 2021-06-25 21:19 ` Wesley Cheng 2021-06-25 22:31 ` Ferry Toth 2021-07-22 18:43 ` Ferry Toth 2021-07-23 6:59 ` Felipe Balbi [not found] ` <d9aef50c-4bd1-4957-13d8-0b6a14b9fcd0@gmail.com> 2021-07-23 11:23 ` Felipe Balbi 2021-07-24 20:59 ` Ferry Toth 2021-07-24 21:19 ` Andy Shevchenko 2021-07-24 22:56 ` Ferry Toth 2021-07-25 6:05 ` Felipe Balbi 2021-07-25 13:32 ` Ferry Toth 2021-07-25 14:05 ` Felipe Balbi 2021-07-25 16:54 ` Ferry Toth 2021-07-26 5:57 ` Felipe Balbi 2021-07-26 14:33 ` Wesley Cheng 2021-07-26 21:51 ` Ferry Toth 2021-08-15 20:56 ` Ferry Toth 2021-08-16 5:18 ` Felipe Balbi 2021-08-17 22:00 ` Ferry Toth 2021-08-18 19:07 ` Ferry Toth 2021-08-19 7:51 ` Pavel Hofman 2021-08-19 20:10 ` Ferry Toth 2021-08-19 21:04 ` Pavel Hofman 2021-08-21 2:57 ` Thinh Nguyen 2021-08-22 20:10 ` Ferry Toth 2021-08-23 7:57 ` Pavel Hofman 2021-09-02 0:28 ` Jack Pham 2021-09-02 22:58 ` Thinh Nguyen 2021-08-22 19:43 ` Ferry Toth 2021-08-23 14:59 ` Pavel Hofman 2021-08-23 15:21 ` Andy Shevchenko 2021-08-23 15:34 ` Pavel Hofman 2021-08-23 18:54 ` Ferry Toth 2021-08-23 22:50 ` Thinh Nguyen 2021-08-24 5:39 ` Pavel Hofman 2021-08-24 13:44 ` Ferry Toth [not found] ` <7ffab777-0f77-f949-f70f-7bf34c504381@gmail.com> 2021-08-26 1:18 ` Thinh Nguyen 2021-08-26 7:30 ` Ferry Toth 2021-08-26 13:35 ` Pavel Hofman 2021-08-19 7:55 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202106180149.f7LhHIwz-lkp@intel.com \ --to=lkp@intel.com \ --cc=agross@kernel.org \ --cc=balbi@kernel.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=frowand.list@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=kbuild-all@lists.01.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=wcheng@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.